Rewrite, improve documentation for `core::hash::BuildHasherDefault`. by frewsxcv · Pull Request #38334 · rust-lang/rust

frewsxcv · 2016-12-13T02:03:44Z

rust-highfive · 2016-12-13T02:03:52Z

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @aturon (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

frewsxcv · 2016-12-13T02:05:10Z

r? @rust-lang/docs

cc @rust-lang/libs to make sure I'm using BuildHasherDefault correctly here.

steveklabnik · 2016-12-13T02:44:26Z

@bors: delegate=kmcallister

bors · 2016-12-13T02:44:27Z

✌️ @kmcallister can now approve this pull request

sfackler · 2016-12-13T03:21:13Z

LGTM

GuillaumeGomez · 2016-12-13T11:19:38Z

You even added all urls. T_T What a great day!

@bors: r+ rollup

bors · 2016-12-13T11:19:39Z

📌 Commit ce1fbad has been approved by GuillaumeGomez

…laumeGomez Rewrite, improve documentation for `core::hash::BuildHasherDefault`. Fixesrust-lang#31242.

bors · 2016-12-16T11:56:57Z

⌛ Testing commit ce1fbad with merge 652b82e...

bors · 2016-12-16T11:59:14Z

💔 Test failed - auto-mac-64-opt-rustbuild

frewsxcv · 2016-12-16T13:01:14Z

@bors retry

bors · 2016-12-16T13:01:22Z

⌛ Testing commit ce1fbad with merge d10ae8d...

bors · 2016-12-16T13:03:16Z

💔 Test failed - auto-mac-64-opt

GuillaumeGomez · 2016-12-16T15:48:51Z

@bors: retry

oyvindln · 2016-12-16T15:57:02Z

There is a failing doctest from this PR in the rollup #38407. Looks like there are some spelling issues.

frewsxcv · 2016-12-16T15:58:35Z

@bors r-

frewsxcv · 2016-12-16T16:01:07Z

@oyvindln Woops, thanks for letting me know! Spelling fixed in the latest force push.

@bors r=GuillaumeGomez rollup

bors · 2016-12-16T16:01:08Z

📌 Commit 17eac5d has been approved by GuillaumeGomez

bors · 2016-12-16T16:02:23Z

⌛ Testing commit 17eac5d with merge 953b687...

bors · 2016-12-16T16:04:14Z

💔 Test failed - auto-mac-64-opt-rustbuild

alexcrichton · 2016-12-16T17:24:30Z

@bors: retry

…

On Fri, Dec 16, 2016 at 8:04 AM, bors ***@***.***> wrote: 💔 Test failed - auto-mac-64-opt-rustbuild <https://buildbot.rust-lang.org/builders/auto-mac-64-opt-rustbuild/builds/3279> — You are receiving this because you are on a team that was mentioned. Reply to this email directly, view it on GitHub <#38334 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAD95BkRgybDREqXI2z49KojW5cmkWvzks5rIraAgaJpZM4LLQVO> .

Fixesrust-lang#31242.

frewsxcv · 2016-12-16T17:27:21Z

Travis found another typo.

@bors r=GuillaumeGomez

bors · 2016-12-16T17:27:22Z

📌 Commit d409fc3 has been approved by GuillaumeGomez

…laumeGomez Rewrite, improve documentation for `core::hash::BuildHasherDefault`. Fixesrust-lang#31242.

Rollup of 9 pull requests - Successful merges: #38334, #38397, #38413, #38421, #38422, #38433, #38438, #38445, #38459 - Failed merges:

rust-highfive assigned aturon Dec 13, 2016

rust-highfive unassigned aturon Dec 13, 2016

frewsxcv mentioned this pull request Dec 13, 2016
clarify BuilderHasherDefault summary #31242
Closed

GuillaumeGomez mentioned this pull request Dec 15, 2016
Rollup of 6 pull requests #38387
Closed

GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Dec 15, 2016
Rollup merge ofrust-lang#38334- frewsxcv:BuildHasherDefault, r=Guil…
24d2260
…laumeGomez Rewrite, improve documentation for `core::hash::BuildHasherDefault`. Fixesrust-lang#31242.

GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Dec 16, 2016
Rollup merge ofrust-lang#38334- frewsxcv:BuildHasherDefault, r=Guil…
5f1f0e1
…laumeGomez Rewrite, improve documentation for `core::hash::BuildHasherDefault`. Fixesrust-lang#31242.

GuillaumeGomez mentioned this pull request Dec 16, 2016
Rollup of 7 pull requests #38407
Closed

frewsxcv force-pushed the BuildHasherDefault branch from ce1fbad to 17eac5dCompare December 16, 2016 16:00

Rewrite, improve documentation for core::hash::BuildHasherDefault.
d409fc3
Fixesrust-lang#31242.

frewsxcv force-pushed the BuildHasherDefault branch from 17eac5d to d409fc3Compare December 16, 2016 17:27

GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Dec 18, 2016
Rollup merge ofrust-lang#38334- frewsxcv:BuildHasherDefault, r=Guil…
ca8f287
…laumeGomez Rewrite, improve documentation for `core::hash::BuildHasherDefault`. Fixesrust-lang#31242.

GuillaumeGomez mentioned this pull request Dec 18, 2016
Rollup of 9 pull requests #38450
Closed

sanxiyn added a commit to sanxiyn/rust that referenced this pull request Dec 19, 2016
Rollup merge ofrust-lang#38334- frewsxcv:BuildHasherDefault, r=Guil…
86cf922
…laumeGomez Rewrite, improve documentation for `core::hash::BuildHasherDefault`. Fixesrust-lang#31242.

sanxiyn mentioned this pull request Dec 19, 2016
Rollup of 9 pull requests #38466
Merged

bors added a commit that referenced this pull request Dec 19, 2016
Auto merge of#38466- sanxiyn:rollup, r=sanxiyn
10271ea
Rollup of 9 pull requests - Successful merges: #38334, #38397, #38413, #38421, #38422, #38433, #38438, #38445, #38459 - Failed merges:

bors merged commit d409fc3 into rust-lang:masterDec 19, 2016

Uh oh!

Uh oh!

Conversation

frewsxcv commented Dec 13, 2016

Uh oh!

rust-highfive commented Dec 13, 2016

Uh oh!

frewsxcv commented Dec 13, 2016

Uh oh!

steveklabnik commented Dec 13, 2016

Uh oh!

bors commented Dec 13, 2016

Uh oh!

sfackler commented Dec 13, 2016

Uh oh!

GuillaumeGomez commented Dec 13, 2016

Uh oh!

bors commented Dec 13, 2016

Uh oh!

bors commented Dec 16, 2016

Uh oh!

bors commented Dec 16, 2016

Uh oh!

frewsxcv commented Dec 16, 2016

Uh oh!

bors commented Dec 16, 2016

Uh oh!

bors commented Dec 16, 2016

Uh oh!

GuillaumeGomez commented Dec 16, 2016

Uh oh!

oyvindln commented Dec 16, 2016

Uh oh!

frewsxcv commented Dec 16, 2016

Uh oh!

frewsxcv commented Dec 16, 2016

Uh oh!

bors commented Dec 16, 2016

Uh oh!

bors commented Dec 16, 2016

Uh oh!

bors commented Dec 16, 2016

Uh oh!

alexcrichton commented Dec 16, 2016 via email

Uh oh!

frewsxcv commented Dec 16, 2016

Uh oh!

bors commented Dec 16, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants