Uh oh!
There was an error while loading. Please reload this page.
Rollup of 9 pull requests - #38466
Merged
Merged
Conversation
We thought Google's ABI for arvm7 required neon, but it is currently optional, perhaps because there is a significant population of Tegra 2 devices still in use. This turns off neon code generation outside #[target-feature] blocks just like we do on armv7-unknown-linux-gnu, but unlike most other armv7 targets. LLVM defaults to +neon for this target, so an explicit disable is necessary. See https://developer.android.com/ndk/guides/abis.html#v7a for instruction set extension requirements. Closesrust-lang#38402.
Hopefully these references will be stable and provide guidance when requirements change in the future.
This tiny patch merely applies @bluss's suggestion for how to get a more informative error message when the feature check can't open a file, a matter that had briefly annoyed the present author, leading to the filing of rust-lang#38417.
The current beta that rustc is bootstrapping from contains a bug in Cargo that erroneously links to OpenSSL in /usr/local, but this is fixed in the most recent 1.14 beta, so let's use that.
This not only avoids the small – and unnecessary – constant overhead for each compiler invocation, but also helps somewhat by only having “correct” rustc processes to look for in `/proc/`. This also makes the wrapper behave effectively as a regular exec wrapper its intended to be.
…laumeGomez Rewrite, improve documentation for `core::hash::BuildHasherDefault`. Fixesrust-lang#31242.
…exit, r=alexcrichton Document platform-specific differences for `std::process::exit`. Fixesrust-lang#35046.
rustc: Disable NEON on armv7 android. We thought Google's ABI for arvm7 required neon, but it is currently optional, perhaps because there is a significant population of Tegra 2 devices still in use. This turns off neon code generation outside #[target-feature] blocks just like we do on armv7-unknown-linux-gnu, but unlike most other armv7 targets. LLVM defaults to +neon for this target, so an explicit disable is necessary. See https://developer.android.com/ndk/guides/abis.html#v7a for instruction set extension requirements. Closesrust-lang#38402.
Replace invalid use of `&mut` with `UnsafeCell` in `std::sync::mpsc` Closesrust-lang#36934 r? @alexcrichton
…cro_nicety, r=bluss tidy features: use 2-parameter form of internal try macro for open err This tiny patch merely applies @bluss's suggestion for how to get a more informative error message when the feature check can't open a file, a matter that had briefly annoyed the present author, leading to the filing of rust-lang#38417. Resolvesrust-lang#38417.
Thread docs r? @frewscvx
Update beta bootstrap compiler The current beta that rustc is bootstrapping from contains a bug in Cargo that erroneously links to OpenSSL in /usr/local, but this is fixed in the most recent 1.14 beta, so let's use that.
stage0.txt: typo fix
Use exec for the wrapper on UNIXes This not only avoids the small – and unnecessary – constant overhead for each compiler invocation, but also helps somewhat by only having “correct” rustc processes to look for in `/proc/`. This also makes the wrapper behave effectively as a regular exec wrapper its intended to be. I also took liberty to change the fallback error code from `1` to `0xfe` (now only relevant on windows) so that when people complain about “compiler exited with code 254”, its obvious where the issue lies (wrapper losing the exit code somehow). r? @alexcrichton
rust-highfive
commented
Dec 19, 2016
Contributor
(rust_highfive has picked a reviewer for you, use r? to override) |
sanxiyn
commented
Dec 19, 2016
ContributorAuthor
@bors r+ p=1 |
bors
commented
Dec 19, 2016
Collaborator
📌 Commit 05be48b has been approved by |
bors
commented
Dec 19, 2016
Collaborator
bors added a commit
that referenced
this pull request
Dec 19, 2016
bors
commented
Dec 19, 2016
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
core::hash::BuildHasherDefault. #38334, Document platform-specific differences forstd::process::exit. #38397, rustc: Disable NEON on armv7 android. #38413, Replace invalid use of&mutwithUnsafeCellinstd::sync::mpsc#38421, tidy features: use 2-parameter form of internal try macro for open err #38422, Thread docs #38433, Update beta bootstrap compiler #38438, stage0.txt: typo fix #38445, Use exec for the wrapper on UNIXes #38459