Skip to content

Builder docs - #38491

Merged
bors merged 1 commit into
rust-lang:masterfrom
GuillaumeGomez:builder_docs
Dec 30, 2016
Merged

Builder docs#38491
bors merged 1 commit into
rust-lang:masterfrom
GuillaumeGomez:builder_docs

Conversation

@GuillaumeGomez

@GuillaumeGomezGuillaumeGomez commented Dec 20, 2016

Copy link
Copy Markdown
Member

@frewsxcv

frewsxcv commented Dec 20, 2016

Copy link
Copy Markdown
Contributor

tidy reports trailing whitespace (see Travis).

@GuillaumeGomez

GuillaumeGomez commented Dec 21, 2016

Copy link
Copy Markdown
MemberAuthor

It seems it wasn't me. Some commits have added. I rebased.

frewsxcv
frewsxcv reviewed Dec 21, 2016
View reviewed changes
Comment threadsrc/libstd/thread/mod.rs Outdated

@frewsxcvfrewsxcvDec 21, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's trailing whitespace on this line for example:

+ ///

@GuillaumeGomez

GuillaumeGomez commented Dec 22, 2016

Copy link
Copy Markdown
MemberAuthor

Updated.

@frewsxcv

frewsxcv commented Dec 22, 2016

Copy link
Copy Markdown
Contributor

There's still trailing whitespace. See Travis.

@GuillaumeGomez

GuillaumeGomez commented Dec 23, 2016

Copy link
Copy Markdown
MemberAuthor

Updated again.

frewsxcv
frewsxcv reviewed Dec 23, 2016
View reviewed changes
Comment threadsrc/libstd/thread/mod.rs Outdated

@frewsxcvfrewsxcvDec 23, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Semicolon should be removed here

@GuillaumeGomezGuillaumeGomezDec 24, 2016

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Arf, good catch!

@GuillaumeGomez

GuillaumeGomez commented Dec 24, 2016

Copy link
Copy Markdown
MemberAuthor

Updated!

@frewsxcv

frewsxcv commented Dec 24, 2016

Copy link
Copy Markdown
Contributor

@bors r+ rollup

@bors

bors commented Dec 24, 2016

Copy link
Copy Markdown
Collaborator

📌 Commit 292d36f has been approved by frewsxcv

alexcrichton added a commit to alexcrichton/rust that referenced this pull request Dec 30, 2016
@alexcrichton
Rollup merge ofrust-lang#38491- GuillaumeGomez:builder_docs, r=frew…
26f28ec
…sxcv
Builder docs
r? @frewsxcv
@alexcrichtonalexcrichton mentioned this pull request Dec 30, 2016
Merged
bors added a commit that referenced this pull request Dec 30, 2016
@bors
Auto merge of#38697- alexcrichton:rollup, r=alexcrichton
7f2d2af
Rollup of 25 pull requests
- Successful merges: #37149, #38491, #38517, #38559, #38587, #38609, #38611, #38622, #38628, #38630, #38631, #38632, #38635, #38647, #38649, #38655, #38659, #38660, #38662, #38665, #38671, #38674, #38676, #38693, #38695
- Failed merges: #38657, #38680
@bors
bors merged commit 292d36f into rust-lang:masterDec 30, 2016
@GuillaumeGomez
GuillaumeGomez deleted the builder_docs branch December 30, 2016 14:39
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@frewsxcvfrewsxcvfrewsxcv left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@frewsxcvfrewsxcv

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@GuillaumeGomez@frewsxcv@bors