Skip to content

Document foreign variadic functions in TRPL and the reference. - #38630

Merged
bors merged 1 commit into
rust-lang:masterfrom
frewsxcv:variadic
Dec 30, 2016
Merged

Document foreign variadic functions in TRPL and the reference.#38630
bors merged 1 commit into
rust-lang:masterfrom
frewsxcv:variadic

Conversation

@frewsxcv

@frewsxcvfrewsxcv commented Dec 27, 2016

Copy link
Copy Markdown
Contributor

Fixes#38485.

@rust-highfive

rust-highfive commented Dec 27, 2016

Copy link
Copy Markdown
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @steveklabnik (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@steveklabnik

steveklabnik commented Dec 27, 2016

Copy link
Copy Markdown
Contributor

Looks great, thank you!

@bors: r+ rollup

@bors

bors commented Dec 27, 2016

Copy link
Copy Markdown
Collaborator

📌 Commit 5cdf128 has been approved by steveklabnik

@brson

brson commented Dec 27, 2016

Copy link
Copy Markdown
Contributor

Thanks for maintaining the reference @frewsxcv !

alexcrichton added a commit to alexcrichton/rust that referenced this pull request Dec 30, 2016
@alexcrichton
Rollup merge ofrust-lang#38630- frewsxcv:variadic, r=steveklabnik
1c2a6f9
Document foreign variadic functions in TRPL and the reference.
Fixesrust-lang#38485.
@alexcrichtonalexcrichton mentioned this pull request Dec 30, 2016
Merged
bors added a commit that referenced this pull request Dec 30, 2016
@bors
Auto merge of#38697- alexcrichton:rollup, r=alexcrichton
7f2d2af
Rollup of 25 pull requests
- Successful merges: #37149, #38491, #38517, #38559, #38587, #38609, #38611, #38622, #38628, #38630, #38631, #38632, #38635, #38647, #38649, #38655, #38659, #38660, #38662, #38665, #38671, #38674, #38676, #38693, #38695
- Failed merges: #38657, #38680
@bors
bors merged commit 5cdf128 into rust-lang:masterDec 30, 2016
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@steveklabniksteveklabnik

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@frewsxcv@rust-highfive@steveklabnik@bors@brson