Sum for Duration by clarfonthey · Pull Request #38712 · rust-lang/rust

clarfonthey · 2016-12-30T19:24:40Z

Implemented the Sum trait for Duration. Seems reasonable.

rust-highfive · 2016-12-30T19:24:54Z

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @sfackler (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

brson · 2016-12-31T00:21:55Z

Thanks @clarcharr !

Seems like there's no precedent for implementing Sum on types other than primitives.

Might one also want to calculate the product of Durations?

If we open the floodgates what other types are going to end up with impl Sumimpl Product?

sfackler · 2016-12-31T00:23:53Z

We don't have a type to represent squared time, so I don't think a Product impl would make much sense :P

clarfonthey · 2016-12-31T03:35:48Z

@brson I actually thought this question myself and took a look at what types implemented Add in std, and currently only Duration made any sense for this. I also would consider Duration to be essentially two primitive types wrapped in a thin shell, so, it's not going too far out of precedent.

Something like String, for example, which implements Add, might not be a good candidate for Sum because I don't ever think of the "sum" of strings to be them all joined together. But I do feel that durations have a well-defined meaning for sum.

brson · 2017-01-03T19:24:20Z

Thanks for the analysis @clarcharr !

clarfonthey · 2017-01-04T20:22:13Z

@brson Does this need an RFC before it can be merged? If so, I can submit one.

sfackler · 2017-01-04T20:39:22Z

Nope, I don't think that'd be necessary.

@rfcbot fcp merge

rfcbot · 2017-01-04T20:51:14Z

Team member @sfackler has proposed to merge this. The next step is review by the rest of the tagged teams:

No concerns currently listed.

Once these reviewers reach consensus, this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

sfackler · 2017-01-17T21:09:16Z

@brson speak now or forever hold your peace.

@bors r+

bors · 2017-01-17T21:09:17Z

📌 Commit 03b66ea has been approved by sfackler

bors · 2017-01-18T08:59:33Z

⌛ Testing commit 03b66ea with merge 2907de1...

bors · 2017-01-18T11:27:11Z

💔 Test failed - status-travis

alexcrichton · 2017-01-18T16:54:13Z

@bors: retry * osx linker segfault #38878

…

On Wed, Jan 18, 2017 at 3:27 AM, bors ***@***.***> wrote: 💔 Test failed - status-travis <https://travis-ci.org/rust-lang/rust/builds/192968497> — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#38712 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAD95EQlX_Vowic8BDXC1XeEqiIE2jBTks5rTfcRgaJpZM4LYWYl> .

bors · 2017-01-18T23:17:25Z

⌛ Testing commit 03b66ea with merge 48e931f...

bors · 2017-01-18T23:36:52Z

💔 Test failed - status-travis

alexcrichton · 2017-01-18T23:39:05Z

@bors: retry * macs are having a bad day with the network

…

On Wed, Jan 18, 2017 at 3:36 PM, bors ***@***.***> wrote: 💔 Test failed - status-travis <https://travis-ci.org/rust-lang/rust/builds/193225373> — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#38712 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAD95FOI11fwkgI76OkEjjLeFQCxbKh_ks5rTqIWgaJpZM4LYWYl> .

bors · 2017-01-19T01:09:13Z

⌛ Testing commit 03b66ea with merge 2263d1b...

Sum for Duration Implemented the `Sum` trait for `Duration`. Seems reasonable.

bors · 2017-01-19T03:33:22Z

☀️ Test successful - status-appveyor, status-travis
Approved by: sfackler
Pushing 2263d1b to master...

Version 1.16.0 (2017-03-16) =========================== Language -------- * Lifetimes in statics and consts default to `'static`. [RFC 1623] * [The compiler's `dead_code` lint now accounts for type aliases][38051]. * [Uninhabitable enums (those without any variants) no longer permit wildcard match patterns][38069] * [Clean up semantics of `self` in an import list][38313] * [`Self` may appear in `impl` headers][38920] * [`Self` may appear in struct expressions][39282] Compiler -------- * [`rustc` now supports `--emit=metadata`, which causes rustc to emit a `.rmeta` file containing only crate metadata][38571]. This can be used by tools like the Rust Language Service to perform metadata-only builds. * [Levenshtein based typo suggestions now work in most places, while previously they worked only for fields and sometimes for local variables][38927]. Together with the overhaul of "no resolution"/"unexpected resolution" errors (#[38154]) they result in large and systematic improvement in resolution diagnostics. * [Fix `transmute::<T, U>` where `T` requires a bigger alignment than `U`][38670] * [rustc: use -Xlinker when specifying an rpath with ',' in it][38798] * [`rustc` no longer attempts to provide "consider using an explicit lifetime" suggestions][37057]. They were inaccurate. Stabilized APIs --------------- * [`VecDeque::truncate`] * [`VecDeque::resize`] * [`String::insert_str`] * [`Duration::checked_add`] * [`Duration::checked_sub`] * [`Duration::checked_div`] * [`Duration::checked_mul`] * [`str::replacen`] * [`str::repeat`] * [`SocketAddr::is_ipv4`] * [`SocketAddr::is_ipv6`] * [`IpAddr::is_ipv4`] * [`IpAddr::is_ipv6`] * [`Vec::dedup_by`] * [`Vec::dedup_by_key`] * [`Result::unwrap_or_default`] * [`<*const T>::wrapping_offset`] * [`<*mut T>::wrapping_offset`] * `CommandExt::creation_flags` * [`File::set_permissions`] * [`String::split_off`] Libraries --------- * [`[T]::binary_search` and `[T]::binary_search_by_key` now take their argument by `Borrow` parameter][37761] * [All public types in std implement `Debug`][38006] * [`IpAddr` implements `From<Ipv4Addr>` and `From<Ipv6Addr>`][38327] * [`Ipv6Addr` implements `From<[u16; 8]>`][38131] * [Ctrl-Z returns from `Stdin.read()` when reading from the console on Windows][38274] * [std: Fix partial writes in `LineWriter`][38062] * [std: Clamp max read/write sizes on Unix][38062] * [Use more specific panic message for `&str` slicing errors][38066] * [`TcpListener::set_only_v6` is deprecated][38304]. This functionality cannot be achieved in std currently. * [`writeln!`, like `println!`, now accepts a form with no string or formatting arguments, to just print a newline][38469] * [Implement `iter::Sum` and `iter::Product` for `Result`][38580] * [Reduce the size of static data in `std_unicode::tables`][38781] * [`char::EscapeDebug`, `EscapeDefault`, `EscapeUnicode`, `CaseMappingIter`, `ToLowercase`, `ToUppercase`, implement `Display`][38909] * [`Duration` implements `Sum`][38712] * [`String` implements `ToSocketAddrs`][39048] Cargo ----- * [The `cargo check` command does a type check of a project without building it][cargo/3296] * [crates.io will display CI badges from Travis and AppVeyor, if specified in Cargo.toml][cargo/3546] * [crates.io will display categories listed in Cargo.toml][cargo/3301] * [Compilation profiles accept integer values for `debug`, in addition to `true` and `false`. These are passed to `rustc` as the value to `-C debuginfo`][cargo/3534] * [Implement `cargo --version --verbose`][cargo/3604] * [All builds now output 'dep-info' build dependencies compatible with make and ninja][cargo/3557] * [Build all workspace members with `build --all`][cargo/3511] * [Document all workspace members with `doc --all`][cargo/3515] * [Path deps outside workspace are not members][cargo/3443] Misc ---- * [`rustdoc` has a `--sysroot` argument that, like `rustc`, specifies the path to the Rust implementation][38589] * [The `armv7-linux-androideabi` target no longer enables NEON extensions, per Google's ABI guide][38413] * [The stock standard library can be compiled for Redox OS][38401] * [Rust has initial SPARC support][38726]. Tier 3. No builds available. * [Rust has experimental support for Nvidia PTX][38559]. Tier 3. No builds available. * [Fix backtraces on i686-pc-windows-gnu by disabling FPO][39379] Compatibility Notes ------------------- * [Uninhabitable enums (those without any variants) no longer permit wildcard match patterns][38069] * In this release, references to uninhabited types can not be pattern-matched. This was accidentally allowed in 1.15. * [The compiler's `dead_code` lint now accounts for type aliases][38051]. * [Ctrl-Z returns from `Stdin.read()` when reading from the console on Windows][38274] * [Clean up semantics of `self` in an import list][38313] [37057]: rust-lang/rust#37057 [37761]: rust-lang/rust#37761 [38006]: rust-lang/rust#38006 [38051]: rust-lang/rust#38051 [38062]: rust-lang/rust#38062 [38062]: rust-lang/rust#38622 [38066]: rust-lang/rust#38066 [38069]: rust-lang/rust#38069 [38131]: rust-lang/rust#38131 [38154]: rust-lang/rust#38154 [38274]: rust-lang/rust#38274 [38304]: rust-lang/rust#38304 [38313]: rust-lang/rust#38313 [38314]: rust-lang/rust#38314 [38327]: rust-lang/rust#38327 [38401]: rust-lang/rust#38401 [38413]: rust-lang/rust#38413 [38469]: rust-lang/rust#38469 [38559]: rust-lang/rust#38559 [38571]: rust-lang/rust#38571 [38580]: rust-lang/rust#38580 [38589]: rust-lang/rust#38589 [38670]: rust-lang/rust#38670 [38712]: rust-lang/rust#38712 [38726]: rust-lang/rust#38726 [38781]: rust-lang/rust#38781 [38798]: rust-lang/rust#38798 [38909]: rust-lang/rust#38909 [38920]: rust-lang/rust#38920 [38927]: rust-lang/rust#38927 [39048]: rust-lang/rust#39048 [39282]: rust-lang/rust#39282 [39379]: rust-lang/rust#39379 [`<*const T>::wrapping_offset`]: https://doc.rust-lang.org/std/primitive.pointer.html#method.wrapping_offset [`<*mut T>::wrapping_offset`]: https://doc.rust-lang.org/std/primitive.pointer.html#method.wrapping_offset [`Duration::checked_add`]: https://doc.rust-lang.org/std/time/struct.Duration.html#method.checked_add [`Duration::checked_div`]: https://doc.rust-lang.org/std/time/struct.Duration.html#method.checked_div [`Duration::checked_mul`]: https://doc.rust-lang.org/std/time/struct.Duration.html#method.checked_mul [`Duration::checked_sub`]: https://doc.rust-lang.org/std/time/struct.Duration.html#method.checked_sub [`File::set_permissions`]: https://doc.rust-lang.org/std/fs/struct.File.html#method.set_permissions [`IpAddr::is_ipv4`]: https://doc.rust-lang.org/std/net/enum.IpAddr.html#method.is_ipv4 [`IpAddr::is_ipv6`]: https://doc.rust-lang.org/std/net/enum.IpAddr.html#method.is_ipv6 [`Result::unwrap_or_default`]: https://doc.rust-lang.org/std/result/enum.Result.html#method.unwrap_or_default [`SocketAddr::is_ipv4`]: https://doc.rust-lang.org/std/net/enum.SocketAddr.html#method.is_ipv4 [`SocketAddr::is_ipv6`]: https://doc.rust-lang.org/std/net/enum.SocketAddr.html#method.is_ipv6 [`String::insert_str`]: https://doc.rust-lang.org/std/string/struct.String.html#method.insert_str [`String::split_off`]: https://doc.rust-lang.org/std/string/struct.String.html#method.split_off [`Vec::dedup_by_key`]: https://doc.rust-lang.org/std/vec/struct.Vec.html#method.dedup_by_key [`Vec::dedup_by`]: https://doc.rust-lang.org/std/vec/struct.Vec.html#method.dedup_by [`VecDeque::resize`]: https://doc.rust-lang.org/std/collections/vec_deque/struct.VecDeque.html#method.resize [`VecDeque::truncate`]: https://doc.rust-lang.org/std/collections/vec_deque/struct.VecDeque.html#method.truncate [`str::repeat`]: https://doc.rust-lang.org/std/primitive.str.html#method.repeat [`str::replacen`]: https://doc.rust-lang.org/std/primitive.str.html#method.replacen [cargo/3296]: rust-lang/cargo#3296 [cargo/3301]: rust-lang/cargo#3301 [cargo/3443]: rust-lang/cargo#3443 [cargo/3511]: rust-lang/cargo#3511 [cargo/3515]: rust-lang/cargo#3515 [cargo/3534]: rust-lang/cargo#3534 [cargo/3546]: rust-lang/cargo#3546 [cargo/3557]: rust-lang/cargo#3557 [cargo/3604]: rust-lang/cargo#3604 [RFC 1623]: https://github.com/rust-lang/rfcs/blob/master/text/1623-static.md

Sum for Duration.
03b66ea

rust-highfive assigned sfackler Dec 30, 2016

brson added the T-libs-api [DEPRECATED; DO NOT USE] label Dec 31, 2016

clarfonthey closed this Dec 31, 2016

clarfonthey reopened this Dec 31, 2016

bors added a commit that referenced this pull request Jan 19, 2017
Auto merge of#38712- clarcharr:duration_sum, r=sfackler
2263d1b
Sum for Duration Implemented the `Sum` trait for `Duration`. Seems reasonable.

bors merged commit 03b66ea into rust-lang:masterJan 19, 2017

clarfonthey deleted the duration_sum branch January 19, 2017 04:57

Uh oh!

Uh oh!

Conversation

clarfonthey commented Dec 30, 2016

Uh oh!

rust-highfive commented Dec 30, 2016

Uh oh!

brson commented Dec 31, 2016

Uh oh!

sfackler commented Dec 31, 2016

Uh oh!

clarfonthey commented Dec 31, 2016• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

brson commented Jan 3, 2017

Uh oh!

clarfonthey commented Jan 4, 2017

Uh oh!

sfackler commented Jan 4, 2017

Uh oh!

rfcbot commented Jan 4, 2017• edited by Kimundi Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sfackler commented Jan 17, 2017

Uh oh!

bors commented Jan 17, 2017

Uh oh!

bors commented Jan 18, 2017

Uh oh!

bors commented Jan 18, 2017

Uh oh!

alexcrichton commented Jan 18, 2017 via email

Uh oh!

bors commented Jan 18, 2017

Uh oh!

bors commented Jan 18, 2017

Uh oh!

alexcrichton commented Jan 18, 2017 via email

Uh oh!

bors commented Jan 19, 2017

Uh oh!

bors commented Jan 19, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

clarfonthey commented Dec 31, 2016•
edited
Loading

rfcbot commented Jan 4, 2017•
edited by Kimundi
Loading