Implement Display for char Escape*, To*case. by clarfonthey · Pull Request #38909 · rust-lang/rust

clarfonthey · 2017-01-07T18:18:03Z

A good example of where this is useful would be in the example print!("{}", 'ß'.to_uppercase()).

Not sure if this requires a formal RFC, but I decided to write the code for it anyway regardless.

rust-highfive · 2017-01-07T18:18:16Z

(rust_highfive has picked a reviewer for you, use r? to override)

alexcrichton · 2017-01-09T04:32:57Z

Sounds like a great idea to me, thanks for the PR @clarcharr! It's ok to land this without an RFC. Could you be sure to add some tests, though? It also looks like the failure on Travis my need to be fixed.

In any case though, let's see what @rust-lang/libs thinks!

@rfcbot fcp merge

rfcbot · 2017-01-09T04:35:28Z

Team member @alexcrichton has proposed to merge this. The next step is review by the rest of the tagged teams:

No concerns currently listed.

Once these reviewers reach consensus, this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

clarfonthey · 2017-01-09T04:46:03Z

@alexcrichton I'll try and get some tests written some time tomorrow! I'll also update the docs for these functions so that they also show that you can print them in addition to iterating over them.

clarfonthey · 2017-01-09T05:24:42Z

Note to self for later: the escape_* docs should be updated for consistency.

clarfonthey · 2017-01-10T21:00:17Z

Docs are all updated, tests added. Also fixed the problem where escape_debug had the examples for escape_default.

clarfonthey · 2017-01-10T21:03:42Z

I also would like to point out that the documentation is rather verbose for all five of these methods now (and also consistent), but I figured that verbosity is better than a lack of information, and stuff can be removed if necessary. Would like a second opinion on that.

alexcrichton · 2017-01-10T21:21:13Z

@bors: r+

Awesome, thanks @clarcharr!

bors · 2017-01-10T21:21:14Z

📌 Commit 6146623 has been approved by alexcrichton

alexcrichton · 2017-01-11T00:00:53Z

@clarcharr looks like the Travis error may still need to be fixed. Also, can you squash the commits down?

clarfonthey · 2017-01-11T00:55:33Z

Rebased and squashed.

alexcrichton · 2017-01-11T03:17:28Z

@bors: r+

bors · 2017-01-11T03:17:28Z

📌 Commit be477de has been approved by alexcrichton

oli-obk · 2017-01-11T08:06:06Z

---- char::char::escape_debug_3 stdout ----
thread 'char::char::escape_debug_3' panicked at 'test executable failed:
thread 'main' panicked at 'assertion failed: (left == right) (left: "\\n", right: "\\\n")', :5

a doctest is failing

looks legit

clarfonthey · 2017-01-11T17:40:48Z

Clearly, I'm the best at typing. (I've fixed the test.)

alexcrichton · 2017-01-11T18:00:36Z

@bors: r+

bors · 2017-01-11T18:00:37Z

📌 Commit 3a79f2e has been approved by alexcrichton

bors · 2017-01-13T07:24:25Z

⌛ Testing commit 3a79f2e with merge b0c52c5...

Implement Display for char Escape*, To*case. See: rust-lang/rfcs#1848. A good example of where this is useful would be in the example `print!("{}", 'ß'.to_uppercase())`. Not sure if this requires a formal RFC, but I decided to write the code for it anyway regardless.

bors · 2017-01-13T09:38:57Z

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing b0c52c5 to master...

Version 1.16.0 (2017-03-16) =========================== Language -------- * Lifetimes in statics and consts default to `'static`. [RFC 1623] * [The compiler's `dead_code` lint now accounts for type aliases][38051]. * [Uninhabitable enums (those without any variants) no longer permit wildcard match patterns][38069] * [Clean up semantics of `self` in an import list][38313] * [`Self` may appear in `impl` headers][38920] * [`Self` may appear in struct expressions][39282] Compiler -------- * [`rustc` now supports `--emit=metadata`, which causes rustc to emit a `.rmeta` file containing only crate metadata][38571]. This can be used by tools like the Rust Language Service to perform metadata-only builds. * [Levenshtein based typo suggestions now work in most places, while previously they worked only for fields and sometimes for local variables][38927]. Together with the overhaul of "no resolution"/"unexpected resolution" errors (#[38154]) they result in large and systematic improvement in resolution diagnostics. * [Fix `transmute::<T, U>` where `T` requires a bigger alignment than `U`][38670] * [rustc: use -Xlinker when specifying an rpath with ',' in it][38798] * [`rustc` no longer attempts to provide "consider using an explicit lifetime" suggestions][37057]. They were inaccurate. Stabilized APIs --------------- * [`VecDeque::truncate`] * [`VecDeque::resize`] * [`String::insert_str`] * [`Duration::checked_add`] * [`Duration::checked_sub`] * [`Duration::checked_div`] * [`Duration::checked_mul`] * [`str::replacen`] * [`str::repeat`] * [`SocketAddr::is_ipv4`] * [`SocketAddr::is_ipv6`] * [`IpAddr::is_ipv4`] * [`IpAddr::is_ipv6`] * [`Vec::dedup_by`] * [`Vec::dedup_by_key`] * [`Result::unwrap_or_default`] * [`<*const T>::wrapping_offset`] * [`<*mut T>::wrapping_offset`] * `CommandExt::creation_flags` * [`File::set_permissions`] * [`String::split_off`] Libraries --------- * [`[T]::binary_search` and `[T]::binary_search_by_key` now take their argument by `Borrow` parameter][37761] * [All public types in std implement `Debug`][38006] * [`IpAddr` implements `From<Ipv4Addr>` and `From<Ipv6Addr>`][38327] * [`Ipv6Addr` implements `From<[u16; 8]>`][38131] * [Ctrl-Z returns from `Stdin.read()` when reading from the console on Windows][38274] * [std: Fix partial writes in `LineWriter`][38062] * [std: Clamp max read/write sizes on Unix][38062] * [Use more specific panic message for `&str` slicing errors][38066] * [`TcpListener::set_only_v6` is deprecated][38304]. This functionality cannot be achieved in std currently. * [`writeln!`, like `println!`, now accepts a form with no string or formatting arguments, to just print a newline][38469] * [Implement `iter::Sum` and `iter::Product` for `Result`][38580] * [Reduce the size of static data in `std_unicode::tables`][38781] * [`char::EscapeDebug`, `EscapeDefault`, `EscapeUnicode`, `CaseMappingIter`, `ToLowercase`, `ToUppercase`, implement `Display`][38909] * [`Duration` implements `Sum`][38712] * [`String` implements `ToSocketAddrs`][39048] Cargo ----- * [The `cargo check` command does a type check of a project without building it][cargo/3296] * [crates.io will display CI badges from Travis and AppVeyor, if specified in Cargo.toml][cargo/3546] * [crates.io will display categories listed in Cargo.toml][cargo/3301] * [Compilation profiles accept integer values for `debug`, in addition to `true` and `false`. These are passed to `rustc` as the value to `-C debuginfo`][cargo/3534] * [Implement `cargo --version --verbose`][cargo/3604] * [All builds now output 'dep-info' build dependencies compatible with make and ninja][cargo/3557] * [Build all workspace members with `build --all`][cargo/3511] * [Document all workspace members with `doc --all`][cargo/3515] * [Path deps outside workspace are not members][cargo/3443] Misc ---- * [`rustdoc` has a `--sysroot` argument that, like `rustc`, specifies the path to the Rust implementation][38589] * [The `armv7-linux-androideabi` target no longer enables NEON extensions, per Google's ABI guide][38413] * [The stock standard library can be compiled for Redox OS][38401] * [Rust has initial SPARC support][38726]. Tier 3. No builds available. * [Rust has experimental support for Nvidia PTX][38559]. Tier 3. No builds available. * [Fix backtraces on i686-pc-windows-gnu by disabling FPO][39379] Compatibility Notes ------------------- * [Uninhabitable enums (those without any variants) no longer permit wildcard match patterns][38069] * In this release, references to uninhabited types can not be pattern-matched. This was accidentally allowed in 1.15. * [The compiler's `dead_code` lint now accounts for type aliases][38051]. * [Ctrl-Z returns from `Stdin.read()` when reading from the console on Windows][38274] * [Clean up semantics of `self` in an import list][38313] [37057]: rust-lang/rust#37057 [37761]: rust-lang/rust#37761 [38006]: rust-lang/rust#38006 [38051]: rust-lang/rust#38051 [38062]: rust-lang/rust#38062 [38062]: rust-lang/rust#38622 [38066]: rust-lang/rust#38066 [38069]: rust-lang/rust#38069 [38131]: rust-lang/rust#38131 [38154]: rust-lang/rust#38154 [38274]: rust-lang/rust#38274 [38304]: rust-lang/rust#38304 [38313]: rust-lang/rust#38313 [38314]: rust-lang/rust#38314 [38327]: rust-lang/rust#38327 [38401]: rust-lang/rust#38401 [38413]: rust-lang/rust#38413 [38469]: rust-lang/rust#38469 [38559]: rust-lang/rust#38559 [38571]: rust-lang/rust#38571 [38580]: rust-lang/rust#38580 [38589]: rust-lang/rust#38589 [38670]: rust-lang/rust#38670 [38712]: rust-lang/rust#38712 [38726]: rust-lang/rust#38726 [38781]: rust-lang/rust#38781 [38798]: rust-lang/rust#38798 [38909]: rust-lang/rust#38909 [38920]: rust-lang/rust#38920 [38927]: rust-lang/rust#38927 [39048]: rust-lang/rust#39048 [39282]: rust-lang/rust#39282 [39379]: rust-lang/rust#39379 [`<*const T>::wrapping_offset`]: https://doc.rust-lang.org/std/primitive.pointer.html#method.wrapping_offset [`<*mut T>::wrapping_offset`]: https://doc.rust-lang.org/std/primitive.pointer.html#method.wrapping_offset [`Duration::checked_add`]: https://doc.rust-lang.org/std/time/struct.Duration.html#method.checked_add [`Duration::checked_div`]: https://doc.rust-lang.org/std/time/struct.Duration.html#method.checked_div [`Duration::checked_mul`]: https://doc.rust-lang.org/std/time/struct.Duration.html#method.checked_mul [`Duration::checked_sub`]: https://doc.rust-lang.org/std/time/struct.Duration.html#method.checked_sub [`File::set_permissions`]: https://doc.rust-lang.org/std/fs/struct.File.html#method.set_permissions [`IpAddr::is_ipv4`]: https://doc.rust-lang.org/std/net/enum.IpAddr.html#method.is_ipv4 [`IpAddr::is_ipv6`]: https://doc.rust-lang.org/std/net/enum.IpAddr.html#method.is_ipv6 [`Result::unwrap_or_default`]: https://doc.rust-lang.org/std/result/enum.Result.html#method.unwrap_or_default [`SocketAddr::is_ipv4`]: https://doc.rust-lang.org/std/net/enum.SocketAddr.html#method.is_ipv4 [`SocketAddr::is_ipv6`]: https://doc.rust-lang.org/std/net/enum.SocketAddr.html#method.is_ipv6 [`String::insert_str`]: https://doc.rust-lang.org/std/string/struct.String.html#method.insert_str [`String::split_off`]: https://doc.rust-lang.org/std/string/struct.String.html#method.split_off [`Vec::dedup_by_key`]: https://doc.rust-lang.org/std/vec/struct.Vec.html#method.dedup_by_key [`Vec::dedup_by`]: https://doc.rust-lang.org/std/vec/struct.Vec.html#method.dedup_by [`VecDeque::resize`]: https://doc.rust-lang.org/std/collections/vec_deque/struct.VecDeque.html#method.resize [`VecDeque::truncate`]: https://doc.rust-lang.org/std/collections/vec_deque/struct.VecDeque.html#method.truncate [`str::repeat`]: https://doc.rust-lang.org/std/primitive.str.html#method.repeat [`str::replacen`]: https://doc.rust-lang.org/std/primitive.str.html#method.replacen [cargo/3296]: rust-lang/cargo#3296 [cargo/3301]: rust-lang/cargo#3301 [cargo/3443]: rust-lang/cargo#3443 [cargo/3511]: rust-lang/cargo#3511 [cargo/3515]: rust-lang/cargo#3515 [cargo/3534]: rust-lang/cargo#3534 [cargo/3546]: rust-lang/cargo#3546 [cargo/3557]: rust-lang/cargo#3557 [cargo/3604]: rust-lang/cargo#3604 [RFC 1623]: https://github.com/rust-lang/rfcs/blob/master/text/1623-static.md

rust-highfive assigned nikomatsakis Jan 7, 2017

clarfonthey mentioned this pull request Jan 7, 2017
Implement Display for structs in std::char rust-lang/rfcs#1848
Closed

clarfonthey force-pushed the char_struct_display branch 2 times, most recently from 560931f to 4d1ffb1Compare January 7, 2017 18:29

alexcrichton assigned alexcrichton and unassigned nikomatsakis Jan 9, 2017

alexcrichton added the T-libs-api [DEPRECATED; DO NOT USE] label Jan 9, 2017

alexcrichton added the relnotes Marks issues that should be documented in the release notes of the next release. label Jan 10, 2017

clarfonthey mentioned this pull request Jan 10, 2017
DoubleEndedIterator and ExactSizeIterator for To*case. #38968
Closed

clarfonthey force-pushed the char_struct_display branch from 0af45aa to a95daf6Compare January 11, 2017 00:54

clarfonthey force-pushed the char_struct_display branch from a95daf6 to be477deCompare January 11, 2017 03:01

clarfonthey force-pushed the char_struct_display branch from be477de to 789724cCompare January 11, 2017 04:25

clarfonthey force-pushed the char_struct_display branch from 789724c to 3a79f2eCompare January 11, 2017 17:39

Implement Display for char Escape*, To*case.
3a79f2e

bors merged commit 3a79f2e into rust-lang:masterJan 13, 2017

This was referenced Jan 13, 2017
Rollup of 9 pull requests #39011
Closed
Fix doc for escape_debug#38629
Closed

clarfonthey deleted the char_struct_display branch January 13, 2017 19:19

clarfonthey mentioned this pull request Apr 2, 2017
Implement Display for Recompositions, Decompositions unicode-rs/unicode-normalization#12
Merged

Uh oh!

Uh oh!

Conversation

clarfonthey commented Jan 7, 2017• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rust-highfive commented Jan 7, 2017

Uh oh!

alexcrichton commented Jan 9, 2017

Uh oh!

rfcbot commented Jan 9, 2017• edited by Kimundi Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

clarfonthey commented Jan 9, 2017• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

clarfonthey commented Jan 9, 2017

Uh oh!

clarfonthey commented Jan 10, 2017

Uh oh!

clarfonthey commented Jan 10, 2017

Uh oh!

alexcrichton commented Jan 10, 2017

Uh oh!

bors commented Jan 10, 2017

Uh oh!

alexcrichton commented Jan 11, 2017

Uh oh!

clarfonthey commented Jan 11, 2017

Uh oh!

alexcrichton commented Jan 11, 2017

Uh oh!

bors commented Jan 11, 2017

Uh oh!

oli-obk commented Jan 11, 2017• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

clarfonthey commented Jan 11, 2017

Uh oh!

alexcrichton commented Jan 11, 2017

Uh oh!

bors commented Jan 11, 2017

Uh oh!

bors commented Jan 13, 2017

Uh oh!

bors commented Jan 13, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

clarfonthey commented Jan 7, 2017•
edited
Loading

rfcbot commented Jan 9, 2017•
edited by Kimundi
Loading

clarfonthey commented Jan 9, 2017•
edited
Loading

oli-obk commented Jan 11, 2017•
edited
Loading