Check for correct env keys in `Command` by tbu- · Pull Request #39338 · rust-lang/rust

tbu- · 2017-01-27T11:21:24Z

Return an error if the key contains an ASCII equals sign (=) at the
non-first position.

rust-highfive · 2017-01-27T11:21:37Z

r? @sfackler

(rust_highfive has picked a reviewer for you, use r? to override)

frewsxcv · 2017-01-27T14:57:13Z

Tests?

alexcrichton · 2017-02-04T22:33:00Z

Looks good to me, can you be sure to squash the commits as well?

tbu- · 2017-02-04T22:59:12Z

Squashed and rebased.

alexcrichton · 2017-02-04T23:02:32Z

@bors: r+

bors · 2017-02-04T23:02:33Z

📌 Commit ab677d8 has been approved by alexcrichton

frewsxcv · 2017-02-05T14:13:18Z

@bors r-

This fails on Windows

https://ci.appveyor.com/project/rust-lang/rust/build/1.0.1822/job/47x30lo5vajnd8pf

alexcrichton · 2017-02-14T00:42:19Z

ping @tbu-, want to help fix the tests?

tbu- · 2017-02-15T14:05:06Z

I have no idea why this is here. It ASCII-uppercases all env keys, for no particular reason as far as I can tell -- It was introduced with the stabilisation of the process module, it wasn't there before (if my git is good enough).

Can the existing behavior be preserved? We can discuss the specifics in a further issue if you'd like to make a case for removal.
AFAIK Windows has case insensitive keys, so we canonicalize to uppercase.

Return an error if the key contains an ASCII equals sign (`=`) at the non-first position.

tbu- · 2017-02-15T18:04:06Z

Rebased and addressed comment.

alexcrichton · 2017-02-15T18:24:20Z

@bors: r+

bors · 2017-02-15T18:24:21Z

📌 Commit 7621677 has been approved by alexcrichton

bors · 2017-02-15T19:06:13Z

⌛ Testing commit 7621677 with merge a56bac8...

bors · 2017-02-15T19:17:44Z

💔 Test failed - status-appveyor

tbu- · 2017-02-15T23:47:40Z

Removed that semicolon.

alexcrichton · 2017-02-16T02:41:04Z

@bors: r+

bors · 2017-02-16T02:41:05Z

📌 Commit 082a6d0 has been approved by alexcrichton

bors · 2017-02-16T03:02:18Z

⌛ Testing commit 082a6d0 with merge b0c79ab...

bors · 2017-02-16T20:21:32Z

💔 Test failed - status-appveyor

alexcrichton · 2017-02-16T20:22:08Z

@bors: retry

trying to get appveyor: Move MSVC dist builds to their own builder #39852 landed

bors · 2017-02-17T02:52:12Z

⌛ Testing commit a96956b with merge 8a84892...

bors · 2017-02-17T02:59:28Z

💔 Test failed - status-appveyor

tbu- · 2017-02-17T14:15:09Z

Fixed variable name.

alexcrichton · 2017-02-17T15:20:05Z

@bors: r+

bors · 2017-02-17T15:20:06Z

📌 Commit 4dfc6fd has been approved by alexcrichton

bors · 2017-02-17T18:17:50Z

⌛ Testing commit 4dfc6fd with merge 435492e...

bors · 2017-02-17T18:27:40Z

💔 Test failed - status-appveyor

codyps · 2017-02-17T18:36:26Z

Why is the = accepted in the first position? Digging around for documentation in posix and windows hasn't turned anything up.

Also may make sense to document this restriction on Command::env.

tbu- · 2017-02-17T19:58:28Z

Made the borrow checker happy.

@jmesmon I don't know, but it is accepted on both Windows and Linux (it's an oddity on both). This is a restriction of the underlying platform, it's the same for env::var, env::set_var etc. But yea, one could document it...

alexcrichton · 2017-02-17T22:19:40Z

@bors: r+

bors · 2017-02-17T22:19:41Z

📌 Commit 314649d has been approved by alexcrichton

bors · 2017-02-18T00:32:34Z

⌛ Testing commit 314649d with merge aa35101...

bors · 2017-02-18T01:48:06Z

💔 Test failed - status-travis

tbu- · 2017-02-22T10:37:26Z

I don't know how that particular test failed. :) It doesn't do anything with the environment.

alexcrichton · 2017-02-22T15:32:38Z

The error message was added in this PR though, so it looks like this PR did indeed cause that error?

tbu- · 2017-03-07T22:37:26Z

I added some println!-debugging so I can see why it fails on Android. Can we test this without a chance of accidently getting merged?

alexcrichton · 2017-03-08T15:31:57Z

If you've got docker locally you can test this out via ./src/ci/docker/run.sh android, but otherwise instead of sending to bors you can also just add ALLOW_PR=1 to the travis configuration for this builder. That'll build it on this PR but we should just be sure to remove that before the PR lands to not let it leak into master.

alexcrichton · 2017-03-14T21:30:27Z

@tbu- any update on this PR to debug android?

alexcrichton · 2017-04-01T22:56:16Z

Closing due to inactivity, but feel free to resubmit with android tests fixed!

rust-highfive assigned sfackler Jan 27, 2017

Kimundi added the T-libs-api [DEPRECATED; DO NOT USE] label Jan 27, 2017

tbu-force-pushed the pr_check_valid_env branch from bf6ac6b to ab677d8Compare February 4, 2017 22:46

frewsxcv mentioned this pull request Feb 5, 2017
Rollup of 20 pull requests #39562
Closed

tbu- commented Feb 15, 2017
View reviewed changes

tbu-force-pushed the pr_check_valid_env branch from a88104d to edf4e36Compare February 15, 2017 17:56

Check for correct env keys in Command
742089d
Return an error if the key contains an ASCII equals sign (`=`) at the non-first position.

tbu-force-pushed the pr_check_valid_env branch from edf4e36 to 7621677Compare February 15, 2017 18:03

tbu-force-pushed the pr_check_valid_env branch from 7621677 to 082a6d0Compare February 15, 2017 23:47

tbu-force-pushed the pr_check_valid_env branch from a96956b to 4dfc6fdCompare February 17, 2017 13:56

Check Windows env keys for interior =
314649d

tbu-force-pushed the pr_check_valid_env branch from 4dfc6fd to 314649dCompare February 17, 2017 19:57

Add println!-debugging
58f7804

alexcrichton closed this Apr 1, 2017

dylni mentioned this pull request Sep 18, 2022
Invalid environment variable names for Command are not rejected #101978
Open

Uh oh!

Uh oh!

Conversation

tbu- commented Jan 27, 2017

Uh oh!

rust-highfive commented Jan 27, 2017

Uh oh!

frewsxcv commented Jan 27, 2017

Uh oh!

alexcrichton commented Feb 4, 2017

Uh oh!

tbu- commented Feb 4, 2017

Uh oh!

alexcrichton commented Feb 4, 2017

Uh oh!

bors commented Feb 4, 2017

Uh oh!

frewsxcv commented Feb 5, 2017

Uh oh!

alexcrichton commented Feb 14, 2017

Uh oh!

tbu-Feb 15, 2017

Choose a reason for hiding this comment

Uh oh!

alexcrichtonFeb 15, 2017

Choose a reason for hiding this comment

Uh oh!

tbu- commented Feb 15, 2017

Uh oh!

alexcrichton commented Feb 15, 2017

Uh oh!

bors commented Feb 15, 2017

Uh oh!

bors commented Feb 15, 2017

Uh oh!

bors commented Feb 15, 2017

Uh oh!

tbu- commented Feb 15, 2017

Uh oh!

alexcrichton commented Feb 16, 2017

Uh oh!

bors commented Feb 16, 2017

Uh oh!

bors commented Feb 16, 2017

Uh oh!

bors commented Feb 16, 2017

Uh oh!

alexcrichton commented Feb 16, 2017

Uh oh!

bors commented Feb 17, 2017

Uh oh!

bors commented Feb 17, 2017

Uh oh!

tbu- commented Feb 17, 2017

Uh oh!

alexcrichton commented Feb 17, 2017

Uh oh!

bors commented Feb 17, 2017

Uh oh!

bors commented Feb 17, 2017

Uh oh!

bors commented Feb 17, 2017

Uh oh!

codyps commented Feb 17, 2017

Uh oh!

tbu- commented Feb 17, 2017

Uh oh!

alexcrichton commented Feb 17, 2017

Uh oh!

bors commented Feb 17, 2017

Uh oh!

bors commented Feb 18, 2017

Uh oh!

bors commented Feb 18, 2017

Uh oh!

tbu- commented Feb 22, 2017

Uh oh!

alexcrichton commented Feb 22, 2017

Uh oh!

tbu- commented Mar 7, 2017