Uh oh!
There was an error while loading. Please reload this page.
appveyor: Move MSVC dist builds to their own builder - #39852
Merged
Conversation
rust-highfive
commented
Feb 15, 2017
Contributor
r? @brson (rust_highfive has picked a reviewer for you, use r? to override) |
brson
commented
Feb 15, 2017
Contributor
@bors r+ |
bors
commented
Feb 15, 2017
Collaborator
📌 Commit fdf4a98 has been approved by |
GuillaumeGomez added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Feb 16, 2017
…, r=brson appveyor: Move MSVC dist builds to their own builder In the long run we want to separate out the dist builders from the test builders. This provides us leeway to expand the dist builders with more tools (e.g. Cargo and the RLS) without impacting cycle times. Currently the Travis dist builders double-up the platforms they provide builds for, so I figured we could try that out for MSVC as well. This commit adds a new AppVeyor builder which runs a dist for all the MSVC targets: * x86_64-pc-windows-msvc * i686-pc-windows-msvc * i586-pc-windows-msvc If this takes too long and/or times out we'll need to split this up. In any case we're going to need more capacity from AppVeyor no matter what becaue the two pc-windows-gnu targets can't cross compile so we need at least 2 more builders no matter what.
alexcrichtonforce-pushed
the
appveyor-separate-dist
branch
from
February 16, 2017 19:56
fdf4a98 to
456cd2fComparealexcrichton
commented
Feb 16, 2017
MemberAuthor
@bors: r=brson p=1 I've split up the gnu builders as well, hoping that we can use this to get appveyor prs landing again |
bors
commented
Feb 16, 2017
Collaborator
📌 Commit 456cd2f has been approved by |
bors
commented
Feb 16, 2017
Collaborator
⌛ Testing commit 456cd2f with merge 83f7bfe... |
bors
commented
Feb 16, 2017
Collaborator
💔 Test failed - status-appveyor |
In the long run we want to separate out the dist builders from the test builders. This provides us leeway to expand the dist builders with more tools (e.g. Cargo and the RLS) without impacting cycle times. Currently the Travis dist builders double-up the platforms they provide builds for, so I figured we could try that out for MSVC as well. This commit adds a new AppVeyor builder which runs a dist for all the MSVC targets: * x86_64-pc-windows-msvc * i686-pc-windows-msvc * i586-pc-windows-msvc If this takes too long and/or times out we'll need to split this up. In any case we're going to need more capacity from AppVeyor no matter what becaue the two pc-windows-gnu targets can't cross compile so we need at least 2 more builders no matter what.
alexcrichtonforce-pushed
the
appveyor-separate-dist
branch
from
February 16, 2017 20:18
456cd2f to
5286c68Comparealexcrichton
commented
Feb 16, 2017
MemberAuthor
@bors: r=brson |
bors
commented
Feb 16, 2017
Collaborator
📌 Commit 5286c68 has been approved by |
bors
commented
Feb 16, 2017
Collaborator
⌛ Testing commit 5286c68 with merge 97eca05... |
bors
commented
Feb 16, 2017
Collaborator
💔 Test failed - status-appveyor |
alexcrichton
commented
Feb 16, 2017
MemberAuthor
@bors: retry
|
bors
commented
Feb 16, 2017
Collaborator
⌛ Testing commit 5286c68 with merge 888857a... |
bors
commented
Feb 17, 2017
Collaborator
💔 Test failed - status-travis |
alexcrichton
commented
Feb 17, 2017
via email
MemberAuthor
@bors: retry
* osx network issues …On Thu, Feb 16, 2017 at 6:00 PM, bors ***@***.***> wrote:
💔 Test failed - status-travis
<https://travis-ci.org/rust-lang/rust/builds/202442099>
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#39852 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAD95DR0EyINnORc-DAq2lbVLdDg8ofLks5rdOMKgaJpZM4MCBf9>
.
|
bors
commented
Feb 17, 2017
Collaborator
bors added a commit
that referenced
this pull request
Feb 17, 2017
appveyor: Move MSVC dist builds to their own builder In the long run we want to separate out the dist builders from the test builders. This provides us leeway to expand the dist builders with more tools (e.g. Cargo and the RLS) without impacting cycle times. Currently the Travis dist builders double-up the platforms they provide builds for, so I figured we could try that out for MSVC as well. This commit adds a new AppVeyor builder which runs a dist for all the MSVC targets: * x86_64-pc-windows-msvc * i686-pc-windows-msvc * i586-pc-windows-msvc If this takes too long and/or times out we'll need to split this up. In any case we're going to need more capacity from AppVeyor no matter what becaue the two pc-windows-gnu targets can't cross compile so we need at least 2 more builders no matter what.
bors
commented
Feb 17, 2017
Collaborator
💔 Test failed - status-travis |
alexcrichton
commented
Feb 17, 2017
via email
MemberAuthor
@bors: retry
* network failure …On Thu, Feb 16, 2017 at 7:00 PM, bors ***@***.***> wrote:
💔 Test failed - status-travis
<https://travis-ci.org/rust-lang/rust/builds/202455078>
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#39852 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAD95H3kBfLr_5v9XwATJ_j80ILmX8BWks5rdPEbgaJpZM4MCBf9>
.
|
bors
commented
Feb 17, 2017
Collaborator
bors added a commit
that referenced
this pull request
Feb 17, 2017
appveyor: Move MSVC dist builds to their own builder In the long run we want to separate out the dist builders from the test builders. This provides us leeway to expand the dist builders with more tools (e.g. Cargo and the RLS) without impacting cycle times. Currently the Travis dist builders double-up the platforms they provide builds for, so I figured we could try that out for MSVC as well. This commit adds a new AppVeyor builder which runs a dist for all the MSVC targets: * x86_64-pc-windows-msvc * i686-pc-windows-msvc * i586-pc-windows-msvc If this takes too long and/or times out we'll need to split this up. In any case we're going to need more capacity from AppVeyor no matter what becaue the two pc-windows-gnu targets can't cross compile so we need at least 2 more builders no matter what.
bors
commented
Feb 17, 2017
Collaborator
☀️ Test successful - status-appveyor, status-travis |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the long run we want to separate out the dist builders from the test
builders. This provides us leeway to expand the dist builders with more tools
(e.g. Cargo and the RLS) without impacting cycle times.
Currently the Travis dist builders double-up the platforms they provide builds
for, so I figured we could try that out for MSVC as well. This commit adds a new
AppVeyor builder which runs a dist for all the MSVC targets:
If this takes too long and/or times out we'll need to split this up. In any case
we're going to need more capacity from AppVeyor no matter what becaue the two
pc-windows-gnu targets can't cross compile so we need at least 2 more builders
no matter what.