rename other than copy/remove

[king6cong]

No description provided.

[rust-highfive]

r? @eddyb

(rust_highfive has picked a reviewer for you, use r? to override)

[eddyb]

r? @alexcrichton

[alexcrichton]

Thanks for the PR! Sometimes the rename operation can fail when a copy would otherwise succeed (such as crossing filesystems), perhaps that could be used first with a copy fallback?

[eddyb]

@alexcrichton Is there no such "best effort" operation implemented anywhere, for moving files?

[alexcrichton]

Oh there probably issue e.g. in the incremental support, I'm not familiar with the precise location, though (@michaelwoerister may know)

[michaelwoerister]

Here is something:

rust/src/librustc/util/fs.rs

Line 67 in 24055d0

pubfnlink_or_copy<P:AsRef<Path>,Q:AsRef<Path>>(p:P,q:Q) -> io::Result<LinkOrCopy>{

It's not for renaming though but for copy vs hard-link.

[king6cong]

Thanks for your advice, everyone 😺
Here's another commit. @alexcrichton

[alexcrichton]

Looks good to me, thanks! I think the tidy check is failing on travis though?

[king6cong]

File formatted @alexcrichton

[alexcrichton]

@bors: r+

[bors]

📌 Commit 5a21f42 has been approved by alexcrichton