Uh oh!
There was an error while loading. Please reload this page.
Fix short hand struct doc - #39459
Conversation
rust-highfive
commented
Feb 2, 2017
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @steveklabnik (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
ghost
commented
Feb 3, 2017
Thanks @phungleson for help me fix issue #38830 |
steveklabnik
commented
Feb 6, 2017
I think this looks great, thank you! @z1mvader wanted to lend a hand, so let's see what they think. I'm feeling good about this PR, though! |
ghost
commented
Feb 7, 2017
I'm no authority here but I think it's all right :) |
steveklabnik
commented
Feb 7, 2017
@bors: r+ rollup Great! Thanks so much @HnGiang for getting this going, and to @phungleson for keeping it going! ❤️ |
bors
commented
Feb 7, 2017
📌 Commit 4ddb56b has been approved by |
…c, r=steveklabnik Fix short hand struct doc Don't want to discredit @HnGiang effort on this issue. I just want to lend a hand to fix this issue rust-lang#38830, it is a very nice feature and is seemingly completed. Fixesrust-lang#39096 r? @steveklabnik
…c, r=steveklabnik Fix short hand struct doc Don't want to discredit @HnGiang effort on this issue. I just want to lend a hand to fix this issue rust-lang#38830, it is a very nice feature and is seemingly completed. Fixesrust-lang#39096 r? @steveklabnik
Don't want to discredit @HnGiang effort on this issue.
I just want to lend a hand to fix this issue #38830, it is a very nice feature and is seemingly completed.
Fixes#39096
r? @steveklabnik