Skip to content

Add i686-unknown-netbsd target - #39426

Merged
bors merged 2 commits into
rust-lang:masterfrom
jakllsch:netbsd-c
Feb 8, 2017
Merged

Add i686-unknown-netbsd target#39426
bors merged 2 commits into
rust-lang:masterfrom
jakllsch:netbsd-c

Conversation

@jakllsch

@jakllschjakllsch commented Jan 31, 2017

Copy link
Copy Markdown
Contributor

No description provided.

@rust-highfive

rust-highfive commented Jan 31, 2017

Copy link
Copy Markdown
Contributor

r? @arielb1

(rust_highfive has picked a reviewer for you, use r? to override)

@jakllsch

jakllsch commented Feb 4, 2017

Copy link
Copy Markdown
ContributorAuthor

@bors: retry

@alexcrichton

alexcrichton commented Feb 4, 2017

Copy link
Copy Markdown
Member

Out of curiosity, why is this "netbsdelf" while the other targets are "netbsd" ?

@jakllsch

jakllsch commented Feb 4, 2017

Copy link
Copy Markdown
ContributorAuthor

The oldest NetBSD ports once used a.out as the executable/object format and were (and those old versions still are) known as "netbsd" in the GNU triple. These ports eventually switched to ELF, becoming "netbsdelf". NetBSD ports that never were a.out are known as "netbsd".

NetBSD's src/share/mk/bsd.own.mk has the list of these ports (line 844 in rev 1.1002). Of these, 32-bit SPARC, and 32-bit ARM are notable as already being supported by LLVM and Rust (but not yet on NetBSD).

Some NetBSD developers have expressed to me that they believe these triples are the dominion of the GNU toolchain. Thus, except for compatibility with the GNU and LLVM toolchains, there may be no need to maintain this historical reasoning in Rust.

@alexcrichton

alexcrichton commented Feb 4, 2017

Copy link
Copy Markdown
Member

Ok perhaps we can stick with "netbsd" in that case? It seems unlike that we'll add an "a.out" target, and if we do seems like we'd want it to be the non-default naming

@jakllsch

jakllsch commented Feb 6, 2017

Copy link
Copy Markdown
ContributorAuthor

GitHub will probably remind us anyway, but I'll need to drop mk/cfg/i686-unknown-netbsd.mk after #39431 is merged.

@alexcrichton

alexcrichton commented Feb 6, 2017

Copy link
Copy Markdown
Member

@bors: r+

@bors

bors commented Feb 6, 2017

Copy link
Copy Markdown
Collaborator

📌 Commit 78f542b has been approved by alexcrichton

@bors

bors commented Feb 6, 2017

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 78f542b with merge 1a27f06...

This was referenced Feb 6, 2017
Merged
Merged
@bors

bors commented Feb 6, 2017

Copy link
Copy Markdown
Collaborator

💔 Test failed - status-travis

@alexcrichton

alexcrichton commented Feb 6, 2017 via email •
edited
Loading

Copy link
Copy Markdown
Member

@jakllschjakllsch changed the title Add i686-unknown-netbsdelf targetAdd i686-unknown-netbsd targetFeb 6, 2017
@frewsxcvfrewsxcv mentioned this pull request Feb 7, 2017
Closed
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Feb 7, 2017
@frewsxcv
Rollup merge ofrust-lang#39426- jakllsch:netbsd-c, r=alexcrichton
8ced123
Add i686-unknown-netbsdelf target
@frewsxcvfrewsxcv mentioned this pull request Feb 7, 2017
Closed
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Feb 7, 2017
@frewsxcv
Rollup merge ofrust-lang#39426- jakllsch:netbsd-c, r=alexcrichton
fae92d8
Add i686-unknown-netbsdelf target
@frewsxcvfrewsxcv mentioned this pull request Feb 7, 2017
Closed
bors added a commit that referenced this pull request Feb 7, 2017
@bors
Auto merge of#39613- frewsxcv:rollup, r=frewsxcv
a4fb614
Rollup of 15 pull requests
- Successful merges: #38764, #39361, #39426, #39462, #39482, #39557, #39561, #39582, #39583, #39587, #39598, #39599, #39601, #39602, #39604
- Failed merges:
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Feb 8, 2017
@frewsxcv
Rollup merge ofrust-lang#39426- jakllsch:netbsd-c, r=alexcrichton
12a21c5
Add i686-unknown-netbsdelf target
@frewsxcvfrewsxcv mentioned this pull request Feb 8, 2017
Closed
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Feb 8, 2017
@frewsxcv
Rollup merge ofrust-lang#39426- jakllsch:netbsd-c, r=alexcrichton
3d8fa5a
Add i686-unknown-netbsdelf target
@frewsxcvfrewsxcv mentioned this pull request Feb 8, 2017
Merged
bors added a commit that referenced this pull request Feb 8, 2017
@bors
Auto merge of#39638- frewsxcv:rollup, r=frewsxcv
10f6a5c
Rollup of 13 pull requests
- Successful merges: #38764, #39361, #39372, #39374, #39400, #39426, #39431, #39459, #39482, #39545, #39593, #39620, #39621
- Failed merges:
@bors

bors commented Feb 8, 2017

Copy link
Copy Markdown
Collaborator

☔ The latest upstream changes (presumably #39638) made this pull request unmergeable. Please resolve the merge conflicts.

@bors
bors merged commit 78f542b into rust-lang:masterFeb 8, 2017
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@arielb1arielb1

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jakllsch@rust-highfive@alexcrichton@bors@arielb1