Uh oh!
There was an error while loading. Please reload this page.
rustbuild: support setting verbosity in config.toml - #39587
Merged
Conversation
Signed-off-by: Marc-Antoine Perennou <Marc-Antoine@Perennou.com>
rust-highfive
commented
Feb 6, 2017
Contributor
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @aturon (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
aturon
commented
Feb 6, 2017
Contributor
@bors: r+ Thanks! |
bors
commented
Feb 6, 2017
Collaborator
📌 Commit 7c2752a has been approved by |
alexcrichton
commented
Feb 6, 2017
Member
Could you also update |
Signed-off-by: Marc-Antoine Perennou <Marc-Antoine@Perennou.com>
Keruspe
commented
Feb 6, 2017
ContributorAuthor
@alexcrichton Done (I basically copy-pasted the comment from flags.rs for the description) |
alexcrichton
commented
Feb 6, 2017
Member
@bors: r+ |
bors
commented
Feb 6, 2017
Collaborator
📌 Commit 4268872 has been approved by |
frewsxcv added a commit
to frewsxcv/rust
that referenced
this pull request
Feb 7, 2017
rustbuild: support setting verbosity in config.toml Most if not all the configuration is settable trhough config.toml but the verbosity isn't yet. This avoids having to pass -v to x.py on each command if you want verbosity to be always on.
frewsxcv added a commit
to frewsxcv/rust
that referenced
this pull request
Feb 7, 2017
rustbuild: support setting verbosity in config.toml Most if not all the configuration is settable trhough config.toml but the verbosity isn't yet. This avoids having to pass -v to x.py on each command if you want verbosity to be always on.
bors added a commit
that referenced
this pull request
Feb 7, 2017
frewsxcv added a commit
to frewsxcv/rust
that referenced
this pull request
Feb 8, 2017
rustbuild: support setting verbosity in config.toml Most if not all the configuration is settable trhough config.toml but the verbosity isn't yet. This avoids having to pass -v to x.py on each command if you want verbosity to be always on.
frewsxcv added a commit
to frewsxcv/rust
that referenced
this pull request
Feb 8, 2017
rustbuild: support setting verbosity in config.toml Most if not all the configuration is settable trhough config.toml but the verbosity isn't yet. This avoids having to pass -v to x.py on each command if you want verbosity to be always on.
bors added a commit
that referenced
this pull request
Feb 8, 2017
frewsxcv added a commit
to frewsxcv/rust
that referenced
this pull request
Feb 9, 2017
rustbuild: support setting verbosity in config.toml Most if not all the configuration is settable trhough config.toml but the verbosity isn't yet. This avoids having to pass -v to x.py on each command if you want verbosity to be always on.
bors
commented
Feb 9, 2017
Collaborator
☔ The latest upstream changes (presumably #39677) made this pull request unmergeable. Please resolve the merge conflicts. |
* 'master' of git://github.com/rust-lang/rust: (70 commits) sanitizer-dylib: only run where std for x86_64-linux is available travis: Fix build order of dist-x86-linux fix the sanitizer-dylib test on non x86_64 linux hosts dist-x86-linux: install newer kernel headers enable sanitizers on build job that tests x86_64 linux enable sanitizers on x86_64-linux releases use helper function in the rebuild logic of the rustc_*san crates build/test the sanitizers only when --enable-sanitizers is used sanitizer support Add missing urls on join_paths Add test for rust-lang#27433 Add more examples, get everything passing at last. Remove some leftover makefiles. Add more test for rustdoc --test Rename manifest_version to manifest-version reference: clarify #[cfg] section Bump stable release date rustbuild: Clean build/dist on `make clean` Add missing urls for current_dir review nits ...
alexcrichton
commented
Feb 9, 2017
Member
@bors: r+ |
bors
commented
Feb 9, 2017
Collaborator
📌 Commit ec73ef9 has been approved by |
frewsxcv added a commit
to frewsxcv/rust
that referenced
this pull request
Feb 10, 2017
rustbuild: support setting verbosity in config.toml Most if not all the configuration is settable trhough config.toml but the verbosity isn't yet. This avoids having to pass -v to x.py on each command if you want verbosity to be always on.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Most if not all the configuration is settable trhough config.toml but the verbosity isn't yet.
This avoids having to pass -v to x.py on each command if you want verbosity to be always on.