Skip to content

enable tools to use test runners programmatically - #39815

Merged
bors merged 2 commits into
rust-lang:masterfrom
oli-obk:patch-3
Feb 25, 2017
Merged

enable tools to use test runners programmatically#39815
bors merged 2 commits into
rust-lang:masterfrom
oli-obk:patch-3

Conversation

@oli-obk

Copy link
Copy Markdown
Contributor

No description provided.

@rust-highfive

Copy link
Copy Markdown
Contributor

r? @aturon

(rust_highfive has picked a reviewer for you, use r? to override)

@est31

Copy link
Copy Markdown
Member

@oli-obk the travis CI error seems relevant.

@aturonaturon added the T-libs-api [DEPRECATED; DO NOT USE] label Feb 14, 2017
@aturon

Copy link
Copy Markdown
Contributor

cc @rust-lang/libs, potential new public API surface.

@alexcrichton

Copy link
Copy Markdown
Member

To be clear, this is an unstable library, so we're not committing to anything yet.

@oli-obk

Copy link
Copy Markdown
ContributorAuthor

To be clear, this is an unstable library, so we're not committing to anything yet.

I'm fully aware of this, but I believe that experimentation with the interface can help contribute to a potential future interface that will be stabilized.

@sfackler

Copy link
Copy Markdown
Member

What does this enable that use of the third party rustc-test crate doesn't?

@oli-obk

Copy link
Copy Markdown
ContributorAuthor

What does this enable that use of the third party rustc-test crate doesn't?

I thought rustc-test is just a copy of the internal crate, but with major version bumps instead of a stable API. I can submit this patch to the rustc-test crate, but it will make it much harder for @SimonSapin to update it, if the crate diverges too much from the internals crate.

@SimonSapin

Copy link
Copy Markdown
Contributor

For what it’s worth I haven’t updated rustc-test since I first made it. But yes, if you want to make major changes I’d suggest forking and making them in a separate crate. This specific PR seems small enough, though. I’d merge it in rustc-test, I don’t think it’s diverging enough to make merges difficult. I’ll also give you access to the repo and crates.io if you’re interested ;)

@oli-obk

Copy link
Copy Markdown
ContributorAuthor

I’ll also give you access to the repo and crates.io if you’re interested ;)

sgtm

This specific PR seems small enough, though. I’d merge it in rustc-test

I opened a PR there, feel free to close this PR if the extra API is deemed excessive for a rustc crate.

@aturon

Copy link
Copy Markdown
Contributor

Ping @brson, I suspect you have opinions and want to check in before merging.

@aturon

Copy link
Copy Markdown
Contributor

I'm going to go ahead and r+. @brson, if you want to revisit later, we can always revert; it's unstable.

@bors: r+ rollup

@bors

bors commented Feb 24, 2017

Copy link
Copy Markdown
Collaborator

📌 Commit 80ac323 has been approved by aturon

GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Feb 24, 2017
enable tools to use test runners programmatically
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Feb 24, 2017
enable tools to use test runners programmatically
@frewsxcvfrewsxcv mentioned this pull request Feb 24, 2017
bors added a commit that referenced this pull request Feb 24, 2017
bors added a commit that referenced this pull request Feb 25, 2017
@bors
bors merged commit 80ac323 into rust-lang:masterFeb 25, 2017
@oli-obk
oli-obk deleted the patch-3 branch March 14, 2017 11:48
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

T-libs-api[DEPRECATED; DO NOT USE]

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants

@oli-obk@rust-highfive@est31@aturon@alexcrichton@sfackler@SimonSapin@bors