Uh oh!
There was an error while loading. Please reload this page.
Fix indentation of error message - #39940
Conversation
So I just encountered this error for the first time. It's unclear what it means, why I encountered it, or how to fix it. But worst of all, it has a random newline and weird indentation! This commit fixes that last bit.
rust-highfive
commented
Feb 18, 2017
(rust_highfive has picked a reviewer for you, use r? to override) |
alexcrichton
commented
Feb 18, 2017
@bors: r+ |
bors
commented
Feb 18, 2017
📌 Commit ec648a1 has been approved by |
Fix indentation of error message So I just encountered this error for the first time. It's unclear what it means, why I encountered it, or how to fix it. But worst of all, it has a random newline and weird indentation! This commit fixes that last bit. <img width="680" alt="screen shot 2017-02-18 at 4 35 36 pm" src="https://cloud.githubusercontent.com/assets/1529387/23097087/0ef5ac4a-f5f9-11e6-9132-18ce759f7092.png">
bors
commented
Feb 19, 2017
⌛ Testing commit ec648a1 with merge 1780ccb... |
bors
commented
Feb 19, 2017
💔 Test failed - status-travis |
alexcrichton
commented
Feb 21, 2017
via email
@bors: retry
* network error …On Sun, Feb 19, 2017 at 3:10 PM, bors ***@***.***> wrote:
💔 Test failed - status-travis
<https://travis-ci.org/rust-lang/rust/builds/203243033>
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#39940 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAD95HcxnoI-s57TKlELqNobHRVWcD70ks5reK-vgaJpZM4MFRC_>
.
|
nikomatsakis
commented
Feb 21, 2017
@sgrif example code? it probably means you've got a recursive enum somewhere. |
@nikomatsakis The type is an hlist, which is recursive but not represented as an enum. The code this impl (but for a 16 element hlist/tuple instead of 2): impl<A,B,SqlA,SqlB,DB>Queryable<Cons<SqlA,Cons<SqlB,Nil>>,DB>for(A,B)whereDB:Backend + HasSqlType<SqlA> + HasSqlType<SqlB>,DB:HasSqlType<Cons<SqlA,Cons<SqlB,Nil>>>,A:Queryable<SqlA,DB>,B:Queryable<SqlB,DB>,Cons<A,Cons<B,Nil>>:FromSqlRow<Cons<SqlA,Cons<SqlB,Nil>>,DB>,{typeRow = Cons<A,Cons<B,Nil>>;fnbuild(Cons(a,Cons(b,Nil)):Self::Row) -> Self{(a, b)}}We ended up dropping the max size we generate that impl for to 12, which resolved the issue. (We picked 12 arbitrarily because it's the largest tuple that libstd provides impls of things like |
nikomatsakis
commented
Feb 22, 2017
@sgrif ah ok |
sgrif
commented
Feb 22, 2017
@nikomatsakis The error message should probably mention that |
Fix indentation of error message So I just encountered this error for the first time. It's unclear what it means, why I encountered it, or how to fix it. But worst of all, it has a random newline and weird indentation! This commit fixes that last bit. <img width="680" alt="screen shot 2017-02-18 at 4 35 36 pm" src="https://cloud.githubusercontent.com/assets/1529387/23097087/0ef5ac4a-f5f9-11e6-9132-18ce759f7092.png">
GuillaumeGomez
commented
Feb 23, 2017
@bors: rollup |
Fix indentation of error message So I just encountered this error for the first time. It's unclear what it means, why I encountered it, or how to fix it. But worst of all, it has a random newline and weird indentation! This commit fixes that last bit. <img width="680" alt="screen shot 2017-02-18 at 4 35 36 pm" src="https://cloud.githubusercontent.com/assets/1529387/23097087/0ef5ac4a-f5f9-11e6-9132-18ce759f7092.png">
Fix indentation of error message So I just encountered this error for the first time. It's unclear what it means, why I encountered it, or how to fix it. But worst of all, it has a random newline and weird indentation! This commit fixes that last bit. <img width="680" alt="screen shot 2017-02-18 at 4 35 36 pm" src="https://cloud.githubusercontent.com/assets/1529387/23097087/0ef5ac4a-f5f9-11e6-9132-18ce759f7092.png">
Fix indentation of error message So I just encountered this error for the first time. It's unclear what it means, why I encountered it, or how to fix it. But worst of all, it has a random newline and weird indentation! This commit fixes that last bit. <img width="680" alt="screen shot 2017-02-18 at 4 35 36 pm" src="https://cloud.githubusercontent.com/assets/1529387/23097087/0ef5ac4a-f5f9-11e6-9132-18ce759f7092.png">
Fix indentation of error message So I just encountered this error for the first time. It's unclear what it means, why I encountered it, or how to fix it. But worst of all, it has a random newline and weird indentation! This commit fixes that last bit. <img width="680" alt="screen shot 2017-02-18 at 4 35 36 pm" src="https://cloud.githubusercontent.com/assets/1529387/23097087/0ef5ac4a-f5f9-11e6-9132-18ce759f7092.png">
So I just encountered this error for the first time. It's unclear what
it means, why I encountered it, or how to fix it. But worst of all, it
has a random newline and weird indentation! This commit fixes that last
bit.