Skip to content

impl RangeArgument for RangeInclusive and add appropriate tests - #39936

Merged
bors merged 3 commits into
rust-lang:masterfrom
djzin:inclusive_rangeargument
Mar 1, 2017
Merged

impl RangeArgument for RangeInclusive and add appropriate tests#39936
bors merged 3 commits into
rust-lang:masterfrom
djzin:inclusive_rangeargument

Conversation

@djzin

@djzindjzin commented Feb 18, 2017

Copy link
Copy Markdown
Contributor

Now that RangeArgument returns a Bound, the impl for RangeInclusive is natural to implement and all that's required are tests around it.

@rust-highfive

rust-highfive commented Feb 18, 2017

Copy link
Copy Markdown
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@alexcrichton

alexcrichton commented Feb 28, 2017

Copy link
Copy Markdown
Member

Oops sorry I think I missed this, apologies!

Nevertheless looks great, thank you!

@bors: r+

@bors

bors commented Feb 28, 2017

Copy link
Copy Markdown
Collaborator

📌 Commit 4338290 has been approved by alexcrichton

@alexcrichtonalexcrichton added the T-libs-api [DEPRECATED; DO NOT USE] label Feb 28, 2017
@bors

bors commented Feb 28, 2017

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 4338290 with merge 44f0926...

@bors

bors commented Feb 28, 2017

Copy link
Copy Markdown
Collaborator

💔 Test failed - status-appveyor

@alexcrichton

alexcrichton commented Feb 28, 2017 via email

Copy link
Copy Markdown
Member

@bors

bors commented Feb 28, 2017

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 4338290 with merge 1808b08...

@bors

bors commented Feb 28, 2017

Copy link
Copy Markdown
Collaborator

💔 Test failed - status-appveyor

@alexcrichton

alexcrichton commented Feb 28, 2017 via email

Copy link
Copy Markdown
Member

@bors

bors commented Feb 28, 2017

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 4338290 with merge 91af879...

@bors

bors commented Feb 28, 2017

Copy link
Copy Markdown
Collaborator

💔 Test failed - status-appveyor

@alexcrichton

alexcrichton commented Feb 28, 2017 via email

Copy link
Copy Markdown
Member

frewsxcv added a commit to frewsxcv/rust that referenced this pull request Mar 1, 2017
@frewsxcv
Rollup merge ofrust-lang#39936- djzin:inclusive_rangeargument, r=al…
43df65f
…excrichton
impl RangeArgument for RangeInclusive and add appropriate tests
Now that `RangeArgument` returns a `Bound`, the impl for `RangeInclusive` is natural to implement and all that's required are tests around it.
@frewsxcvfrewsxcv mentioned this pull request Mar 1, 2017
Merged
bors added a commit that referenced this pull request Mar 1, 2017
@bors
Auto merge of#40167- frewsxcv:rollup, r=frewsxcv
88f7016
Rollup of 6 pull requests
- Successful merges: #39419, #39936, #39944, #39960, #40028, #40128
- Failed merges:
bors added a commit that referenced this pull request Mar 1, 2017
@bors
Auto merge of#40167- frewsxcv:rollup, r=frewsxcv
b671c32
Rollup of 6 pull requests
- Successful merges: #39419, #39936, #39944, #39960, #40028, #40128
- Failed merges:
@bors

bors commented Mar 1, 2017

Copy link
Copy Markdown
Collaborator

☔ The latest upstream changes (presumably #40167) made this pull request unmergeable. Please resolve the merge conflicts.

@bors
bors merged commit 4338290 into rust-lang:masterMar 1, 2017
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@alexcrichtonalexcrichton

Labels

T-libs-api[DEPRECATED; DO NOT USE]

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@djzin@rust-highfive@alexcrichton@bors