Uh oh!
There was an error while loading. Please reload this page.
Rollup of 6 pull requests - #40167
Merged
Merged
Conversation
Changed stability annotations for the new Error and Display impls for std::ffi::FromBytesWithNulError as they aren't subject to stability the same way.
…m::TokenTree::Sequence`.
Simplify `TokenTree` and fix `macro_rules!` bugs This PR - fixesrust-lang#39390, fixesrust-lang#39403, and fixesrust-lang#39404 (each is a [breaking-change], see issues for examples), - fixesrust-lang#39889, - simplifies and optimizes macro invocation parsing, - cleans up `ext::tt::transcribe`, - removes `tokenstream::TokenTree::Sequence` and `Token::MatchNt`, - instead, adds a new type `ext::tt::quoted::TokenTree` for use by `macro_rules!` (`ext::tt`) - removes `parser.quote_depth` and `parser.parsing_token_tree`, and - removes `quote_matcher!`. - Instead, use `quote_tokens!` and `ext::tt::quoted::parse` the result with `expect_matchers=true`. - I found no outside uses of `quote_matcher!` when searching Rust code on Github. r? @nrc
…excrichton impl RangeArgument for RangeInclusive and add appropriate tests Now that `RangeArgument` returns a `Bound`, the impl for `RangeInclusive` is natural to implement and all that's required are tests around it.
…=frewsxcv Improve associated constant rendering in rustdoc Before: <img width="1440" alt="screen shot 2017-02-19 at 00 30 51" src="https://cloud.githubusercontent.com/assets/3050060/23097697/caeed80e-f63a-11e6-98c2-5d27e4efd76d.png"> After: <img width="1440" alt="screen shot 2017-02-19 at 00 30 39" src="https://cloud.githubusercontent.com/assets/3050060/23097698/cfb4874e-f63a-11e6-80cf-ffbf5c5c6162.png"> cc @SergioBenitez r? @rust-lang/docs
added Error and Display impl for std::ffi::FromBytesWithNulError Fixesrust-lang#39925. This is my first PR, so I wasn't quite sure about the stability annotation.
…excrichton impl FromIterator<&char> for String
Move two large error_reporting fn's to a separate file Hello! I tried to make `librustc/infer/error_reporting,rs` more readable by modularizing it and moving its two largest functions to a separate file. If you have any suggestions, please send it right away! 🚀 Thanks goes to @nikomatsakis for supporting.
frewsxcv
commented
Mar 1, 2017
ContributorAuthor
@bors r+ p=10 |
bors
commented
Mar 1, 2017
Collaborator
📌 Commit 0b5bf67 has been approved by |
rust-highfive
commented
Mar 1, 2017
Contributor
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @pnkfelix (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
bors
commented
Mar 1, 2017
Collaborator
bors
commented
Mar 1, 2017
Collaborator
💔 Test failed - status-travis |
frewsxcv
commented
Mar 1, 2017
ContributorAuthor
@bors retry I don't know weird llvm thing |
bors
commented
Mar 1, 2017
Collaborator
bors
commented
Mar 1, 2017
Collaborator
☀️ Test successful - status-appveyor, status-travis |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TokenTreeand fixmacro_rules!bugs #39419, impl RangeArgument for RangeInclusive and add appropriate tests #39936, Improve associated constant rendering in rustdoc #39944, added Error and Display impl for std::ffi::FromBytesWithNulError #39960, impl FromIterator<&char> for String #40028, Move two large error_reporting fn's to a separate file #40128