librustc error_reporting.rs cleanup. by frewsxcv · Pull Request #39977 · rust-lang/rust

frewsxcv · 2017-02-20T14:42:31Z

Read some code in librustc, mainly in error_reporting.rs, and cleaned up some things along the way. I recommend looking at each commit individually or looking at the whitespace insensitive diff.

rust-highfive · 2017-02-20T14:42:38Z

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @arielb1 (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

eddyb · 2017-02-25T18:50:43Z

I'm not sure on the style changes. I know there's a style team but I can't figure out how to ping them.
cc @nrc @solson @nikomatsakis

solson · 2017-02-25T21:30:27Z

@eddyb My approach to style in the rust repo is generally "I'm not going to worry about minor inconsistencies now because we're going to automate it all with rustfmt later".

but I can't figure out how to ping them

You can't ping us here becase we're under the rust-lang-nursery org. We would need to be moved over here.

eddyb

Commit-by-commit makes a lot more sense!

eddyb · 2017-02-25T21:40:31Z

+impl_candidates: Vec<ty::TraitRef<'tcx>>,
 err: &mut DiagnosticBuilder)
 {
- let simp = fast_reject::simplify_type(self.tcx,


Was all of this duplicated from find_similar_impl_candidates? 😆

Yeeeppppppp

eddyb · 2017-02-25T21:42:40Z

@bors r+

bors · 2017-02-25T21:42:41Z

📌 Commit a754ea6 has been approved by eddyb

…=eddyb librustc error_reporting.rs cleanup. Read some code in librustc, mainly in error_reporting.rs, and cleaned up some things along the way. I recommend looking at each commit individually or looking at the [whitespace insensitive diff](https://github.com/rust-lang/rust/pull/39977/files?w=1).

bors · 2017-02-26T04:16:17Z

⌛ Testing commit a754ea6 with merge 8b55091...

bors · 2017-02-26T04:20:10Z

💔 Test failed - status-travis

alexcrichton · 2017-02-26T04:27:39Z

@bors: retry * network error

…

On Sat, Feb 25, 2017 at 10:20 PM, bors ***@***.***> wrote: 💔 Test failed - status-travis <https://travis-ci.org/rust-lang/rust/builds/205432692> — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#39977 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAD95Dhjbnzj26xReTLrbRpuOyPPT1Q-ks5rgP17gaJpZM4MGQiU> .

alexcrichton · 2017-02-26T05:33:07Z

@bors: retry * network failure

…

On Sat, Feb 25, 2017 at 10:50 PM, bors ***@***.***> wrote: 💔 Test failed - status-travis <https://travis-ci.org/rust-lang/rust/builds/205435348> — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#39977 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAD95AaWtyzoJFShI4TeMk2IRteiAnDKks5rgQSBgaJpZM4MGQiU> .

frewsxcv · 2017-02-27T16:23:21Z

@bors retry

bors · 2017-02-27T20:40:21Z

⌛ Testing commit a754ea6 with merge 57bd173...

bors · 2017-02-27T21:42:11Z

💔 Test failed - status-travis

alexcrichton · 2017-02-27T21:45:36Z

@bors: retry * osx linker segfault #38878

…

On Mon, Feb 27, 2017 at 3:42 PM, bors ***@***.***> wrote: 💔 Test failed - status-travis <https://travis-ci.org/rust-lang/rust/builds/205942464> — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#39977 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAD95NEgLXanb54LFW_vj8xLNklff0Tpks5rg0M2gaJpZM4MGQiU> .

bors · 2017-02-27T23:56:17Z

⌛ Testing commit a754ea6 with merge 80a738a...

bors · 2017-02-28T00:14:12Z

💔 Test failed - status-appveyor

alexcrichton · 2017-02-28T00:21:14Z

@bors: retry * sccache failure which means it needs updating #40095

…

On Mon, Feb 27, 2017 at 6:14 PM, bors ***@***.***> wrote: 💔 Test failed - status-appveyor <https://ci.appveyor.com/project/rust-lang/rust/build/1.0.2147> — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#39977 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAD95NOCSlfvI9gfXx9dwjWMCyPOBAoCks5rg2bWgaJpZM4MGQiU> .

…=eddyb librustc error_reporting.rs cleanup. Read some code in librustc, mainly in error_reporting.rs, and cleaned up some things along the way. I recommend looking at each commit individually or looking at the [whitespace insensitive diff](https://github.com/rust-lang/rust/pull/39977/files?w=1).

bors · 2017-02-28T14:00:47Z

⌛ Testing commit a754ea6 with merge 2eae5e6...

eddyb · 2017-02-28T14:06:36Z

@bors retry

Rollup of 9 pull requests - Successful merges: #39977, #40033, #40047, #40056, #40057, #40122, #40124, #40126, #40131 - Failed merges: #40101

rust-highfive assigned arielb1 Feb 20, 2017

frewsxcv added 8 commits February 20, 2017 11:40

Remove else, unindent.
7e0c3de

Rewrite match to use combinators.
de2f7e1

Remove else, unindent.
83fe48d

Remove unnecessary logic when finding simpilar impl candidates.
a97aed7

Extract out error message generation.
2436d73

Add early return, remove else, unindent.
10639d7

Flatten for loop using iterator combinators.
23d9211

Move TraitRefimpl next to struct definition.
a754ea6

frewsxcv force-pushed the error-reporting-cleanup branch from c63f833 to a754ea6Compare February 20, 2017 16:40

frewsxcv requested a review from eddyb February 25, 2017 18:45

eddyb approved these changes Feb 25, 2017
View reviewed changes

frewsxcv mentioned this pull request Feb 25, 2017
Rollup of 7 pull requests #40098
Closed

frewsxcv mentioned this pull request Feb 25, 2017
Rollup of 6 pull requests #40099
Closed

frewsxcv mentioned this pull request Feb 26, 2017
Rollup of 5 pull requests #40105
Closed

bors mentioned this pull request Feb 28, 2017
Add compile fail test for SIMD #40101
Merged

frewsxcv mentioned this pull request Feb 28, 2017
Rollup of 7 pull requests #40137
Closed

frewsxcv mentioned this pull request Feb 28, 2017
Rollup of 8 pull requests #40138
Closed

eddyb mentioned this pull request Feb 28, 2017
Rollup of 11 pull requests #40143
Closed

eddyb mentioned this pull request Feb 28, 2017
Rollup of 11 pull requests #40147
Closed

frewsxcv mentioned this pull request Feb 28, 2017
Rollup of 9 pull requests #40148
Merged

bors added a commit that referenced this pull request Feb 28, 2017
Auto merge of#40148- frewsxcv:rollup, r=frewsxcv
be76056
Rollup of 9 pull requests - Successful merges: #39977, #40033, #40047, #40056, #40057, #40122, #40124, #40126, #40131 - Failed merges: #40101

bors merged commit a754ea6 into rust-lang:masterFeb 28, 2017

Uh oh!

Uh oh!

Conversation

frewsxcv commented Feb 20, 2017• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rust-highfive commented Feb 20, 2017

Uh oh!

eddyb commented Feb 25, 2017

Uh oh!

solson commented Feb 25, 2017

Uh oh!

eddyb left a comment

Choose a reason for hiding this comment

Uh oh!

eddybFeb 25, 2017

Choose a reason for hiding this comment

Uh oh!

frewsxcvFeb 25, 2017

Choose a reason for hiding this comment

Uh oh!

eddyb commented Feb 25, 2017

Uh oh!

bors commented Feb 25, 2017

Uh oh!

bors commented Feb 26, 2017

Uh oh!

bors commented Feb 26, 2017

Uh oh!

alexcrichton commented Feb 26, 2017 via email

Uh oh!

alexcrichton commented Feb 26, 2017 via email

Uh oh!

frewsxcv commented Feb 27, 2017

Uh oh!

bors commented Feb 27, 2017

Uh oh!

bors commented Feb 27, 2017

Uh oh!

alexcrichton commented Feb 27, 2017 via email

Uh oh!

bors commented Feb 27, 2017

Uh oh!

bors commented Feb 28, 2017

Uh oh!

alexcrichton commented Feb 28, 2017 via email

Uh oh!

bors commented Feb 28, 2017

Uh oh!

eddyb commented Feb 28, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

frewsxcv commented Feb 20, 2017•
edited
Loading