Add compile fail test for unboxed_closures feature by topecongiro · Pull Request #40047 · rust-lang/rust

topecongiro · 2017-02-23T05:09:03Z

Hello, this is my first contribution to rust.
Issue #39059.

rust-highfive · 2017-02-23T05:09:18Z

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

est31 · 2017-02-23T05:25:51Z

Hi, and thanks for the PR!

One note, the test you added doesn't actually fail. You need to remove the #![feature(...)] attribute and continue the steps I outlined in #39059 to add the error message.

topecongiro · 2017-02-23T06:33:07Z

@est31 Hi, thank you for your comment.
Very sorry abou misunderstanding what should be done.
I removed #![feature(...)] attribute and added the error message.

alexcrichton · 2017-02-23T15:25:39Z

Thanks @topecongiro!

@bors: r+ delegate=est31

bors · 2017-02-23T15:25:40Z

✌️ @est31 can now approve this pull request

bors · 2017-02-23T15:25:41Z

📌 Commit cd7b0fc has been approved by alexcrichton

eddyb · 2017-02-25T09:35:40Z

@bors rollup

Rollup of 28 pull requests - Successful merges: #39859, #39864, #39888, #39903, #39905, #39914, #39945, #39950, #39953, #39961, #39980, #39988, #39993, #39995, #40019, #40020, #40022, #40024, #40025, #40026, #40027, #40031, #40035, #40037, #40038, #40064, #40069, #40086 - Failed merges: #39927, #40008, #40047

bors · 2017-02-25T15:07:45Z

☔ The latest upstream changes (presumably #40091) made this pull request unmergeable. Please resolve the merge conflicts.

bors · 2017-02-25T15:10:23Z

🔒 Merge conflict

est31 · 2017-02-25T17:27:15Z

@topecongiro you'll have to rebase this pull request and resolve the created merge conflicts. PR #40031 got merged before this, and both edited the whitelist.

est31 · 2017-02-25T21:40:30Z

@topecongiro note that generally, its customary to use rebase instead of merge requests. I'll r+ anyway, just remember this for your future contributions. You can just force-push if you want to change it before it gets merged this way.

@bors r+

bors · 2017-02-25T21:40:31Z

📌 Commit c4e858e has been approved by est31

Add compile fail test for unboxed_closures feature Hello, this is my first contribution to rust. Issue rust-lang#39059.

topecongiro · 2017-02-26T03:14:18Z

@est31 Sorry for bothering you. I will keep that in mind.

bors · 2017-02-26T05:14:14Z

⌛ Testing commit c4e858e with merge 29184a0...

bors · 2017-02-26T05:18:06Z

💔 Test failed - status-travis

alexcrichton · 2017-02-26T05:31:44Z

@bors: retry * network failure

…

On Sat, Feb 25, 2017 at 11:18 PM, bors ***@***.***> wrote: 💔 Test failed - status-travis <https://travis-ci.org/rust-lang/rust/builds/205437965> — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#40047 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAD95BChFOPN-4hfcxxnk8cwtIO7dcs9ks5rgQsQgaJpZM4MJjSE> .

est31 · 2017-02-27T15:00:51Z

@topecongiro can you remove that last commit? Its not required, and unneccessary clutter.

eddyb · 2017-02-27T15:03:03Z

FWIW the fix is to run git pull --rebase upstream/master.

topecongiro · 2017-02-28T02:28:54Z

@est31 @eddyb Thank you for your help and patience. I rebased.

est31 · 2017-02-28T02:57:51Z

@bors r+

bors · 2017-02-28T02:57:53Z

📌 Commit 988be44 has been approved by est31

Add compile fail test for unboxed_closures feature Hello, this is my first contribution to rust. Issue rust-lang#39059.

Rollup of 9 pull requests - Successful merges: #39977, #40033, #40047, #40056, #40057, #40122, #40124, #40126, #40131 - Failed merges: #40101

rust-highfive assigned alexcrichton Feb 23, 2017

est31 mentioned this pull request Feb 23, 2017
Removal of the lang feature gate tests whitelist #39059
Closed
20 tasks

eddyb mentioned this pull request Feb 25, 2017
Rollup of 29 pull requests #40089
Closed

eddyb mentioned this pull request Feb 25, 2017
Rollup of 28 pull requests #40091
Merged

frewsxcv mentioned this pull request Feb 25, 2017
Rollup of 7 pull requests #40098
Closed

frewsxcv added a commit to frewsxcv/rust that referenced this pull request Feb 25, 2017
Rollup merge ofrust-lang#40047- topecongiro:master, r=est31
6323627
Add compile fail test for unboxed_closures feature Hello, this is my first contribution to rust. Issue rust-lang#39059.

frewsxcv mentioned this pull request Feb 25, 2017
Rollup of 6 pull requests #40099
Closed

frewsxcv added a commit to frewsxcv/rust that referenced this pull request Feb 26, 2017
Rollup merge ofrust-lang#40047- topecongiro:master, r=est31
e47a0dc
Add compile fail test for unboxed_closures feature Hello, this is my first contribution to rust. Issue rust-lang#39059.

frewsxcv mentioned this pull request Feb 26, 2017
Rollup of 5 pull requests #40105
Closed

Add compile fail test for unboxed_closures feature
988be44

topecongiro force-pushed the master branch from 05554a9 to 988be44Compare February 28, 2017 02:25

frewsxcv added a commit to frewsxcv/rust that referenced this pull request Feb 28, 2017
Rollup merge ofrust-lang#40047- topecongiro:master, r=est31
c3ae2f8
Add compile fail test for unboxed_closures feature Hello, this is my first contribution to rust. Issue rust-lang#39059.

frewsxcv added a commit to frewsxcv/rust that referenced this pull request Feb 28, 2017
Rollup merge ofrust-lang#40047- topecongiro:master, r=est31
f190779
Add compile fail test for unboxed_closures feature Hello, this is my first contribution to rust. Issue rust-lang#39059.

frewsxcv mentioned this pull request Feb 28, 2017
Rollup of 8 pull requests #40138
Closed

eddyb mentioned this pull request Feb 28, 2017
Rollup of 11 pull requests #40143
Closed

eddyb added a commit to eddyb/rust that referenced this pull request Feb 28, 2017
Rollup merge ofrust-lang#40047- topecongiro:master, r=est31
718882e
Add compile fail test for unboxed_closures feature Hello, this is my first contribution to rust. Issue rust-lang#39059.

eddyb mentioned this pull request Feb 28, 2017
Rollup of 11 pull requests #40147
Closed

frewsxcv added a commit to frewsxcv/rust that referenced this pull request Feb 28, 2017
Rollup merge ofrust-lang#40047- topecongiro:master, r=est31
922a262
Add compile fail test for unboxed_closures feature Hello, this is my first contribution to rust. Issue rust-lang#39059.

frewsxcv mentioned this pull request Feb 28, 2017
Rollup of 9 pull requests #40148
Merged

bors added a commit that referenced this pull request Feb 28, 2017
Auto merge of#40148- frewsxcv:rollup, r=frewsxcv
be76056
Rollup of 9 pull requests - Successful merges: #39977, #40033, #40047, #40056, #40057, #40122, #40124, #40126, #40131 - Failed merges: #40101

bors merged commit 988be44 into rust-lang:masterFeb 28, 2017

Uh oh!

Uh oh!

Conversation

topecongiro commented Feb 23, 2017

Uh oh!

rust-highfive commented Feb 23, 2017

Uh oh!

est31 commented Feb 23, 2017

Uh oh!

topecongiro commented Feb 23, 2017

Uh oh!

alexcrichton commented Feb 23, 2017

Uh oh!

bors commented Feb 23, 2017

Uh oh!

bors commented Feb 23, 2017

Uh oh!

eddyb commented Feb 25, 2017

Uh oh!

bors commented Feb 25, 2017

Uh oh!

bors commented Feb 25, 2017

Uh oh!

est31 commented Feb 25, 2017

Uh oh!

est31 commented Feb 25, 2017

Uh oh!

bors commented Feb 25, 2017

Uh oh!

topecongiro commented Feb 26, 2017

Uh oh!

bors commented Feb 26, 2017

Uh oh!

bors commented Feb 26, 2017

Uh oh!

alexcrichton commented Feb 26, 2017 via email

Uh oh!

est31 commented Feb 27, 2017

Uh oh!

eddyb commented Feb 27, 2017

Uh oh!

topecongiro commented Feb 28, 2017

Uh oh!

est31 commented Feb 28, 2017

Uh oh!

bors commented Feb 28, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants