Skip to content

macros: fix const expression invocations - #40272

Merged
bors merged 1 commit into
rust-lang:masterfrom
jseyfried:fix_const_macro_invocations
Mar 6, 2017
Merged

macros: fix const expression invocations#40272
bors merged 1 commit into
rust-lang:masterfrom
jseyfried:fix_const_macro_invocations

Conversation

@jseyfried

@jseyfriedjseyfried commented Mar 5, 2017

Copy link
Copy Markdown
Contributor

Fixes#40136.
r? @nrc

@jseyfriedjseyfried mentioned this pull request Mar 5, 2017
Closed
@petrochenkov

petrochenkov commented Mar 5, 2017

Copy link
Copy Markdown
Contributor

Missing main in the run-pass test.

@jseyfried
jseyfriedforce-pushed the fix_const_macro_invocations branch from 095bcea to 9fe7d3fCompareMarch 5, 2017 23:58
@jseyfried

jseyfried commented Mar 5, 2017

Copy link
Copy Markdown
ContributorAuthor

@petrochenkov Thanks -- fixed.

@petrochenkov

petrochenkov commented Mar 6, 2017

Copy link
Copy Markdown
Contributor

@bors r+

@bors

bors commented Mar 6, 2017

Copy link
Copy Markdown
Collaborator

📌 Commit 9fe7d3f has been approved by petrochenkov

@bors

bors commented Mar 6, 2017

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 9fe7d3f with merge 1c34389...

@bors

bors commented Mar 6, 2017

Copy link
Copy Markdown
Collaborator

💔 Test failed - status-appveyor

@jseyfried

jseyfried commented Mar 6, 2017

Copy link
Copy Markdown
ContributorAuthor

@bors retry

@bors

bors commented Mar 6, 2017

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 9fe7d3f with merge 0cc7037...

@bors

bors commented Mar 6, 2017

Copy link
Copy Markdown
Collaborator

💔 Test failed - status-appveyor

@jseyfried

jseyfried commented Mar 6, 2017

Copy link
Copy Markdown
ContributorAuthor

@bors retry

@bors

bors commented Mar 6, 2017

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 9fe7d3f with merge 344dc3f...

@bors

bors commented Mar 6, 2017

Copy link
Copy Markdown
Collaborator

💔 Test failed - status-travis

@petrochenkov

petrochenkov commented Mar 6, 2017

Copy link
Copy Markdown
Contributor

@bors retry

@bors

bors commented Mar 6, 2017

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 9fe7d3f with merge 2777b47...

@bors

bors commented Mar 6, 2017

Copy link
Copy Markdown
Collaborator

💔 Test failed - status-travis

@alexcrichton

alexcrichton commented Mar 6, 2017 via email

Copy link
Copy Markdown
Member

@bors

bors commented Mar 6, 2017

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 9fe7d3f with merge b04ebef...

bors added a commit that referenced this pull request Mar 6, 2017
@bors
Auto merge of#40272- jseyfried:fix_const_macro_invocations, r=petro…
b04ebef
…chenkov
macros: fix const expression invocations
Fixes#40136.
r? @nrc
@bors

bors commented Mar 6, 2017

Copy link
Copy Markdown
Collaborator

☀️ Test successful - status-appveyor, status-travis
Approved by: petrochenkov
Pushing b04ebef to master...

@bors
bors merged commit 9fe7d3f into rust-lang:masterMar 6, 2017
@jseyfriedjseyfried added beta-nominated Nominated for backporting to the compiler in the beta channel. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 7, 2017
@jseyfried
jseyfried deleted the fix_const_macro_invocations branch March 7, 2017 06:24
@jseyfried

jseyfried commented Mar 7, 2017

Copy link
Copy Markdown
ContributorAuthor

Nominated for beta: fixes a minor stable-to-stable regression (error to ICE), very simple PR.

@TimNNTimNN mentioned this pull request Mar 9, 2017
Closed
@brsonbrson added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Mar 9, 2017
@brsonbrson mentioned this pull request Mar 9, 2017
Merged
@alexcrichtonalexcrichton removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Mar 9, 2017
bors added a commit that referenced this pull request Mar 9, 2017
@bors
Auto merge of#40401- brson:beta-next, r=alexcrichton
94dca9a
Beta next
- #40285
- #40272
- #40064
- #39835
- #40398
r? @alexcrichton
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@nrcnrc

Labels

beta-acceptedAccepted for backporting to the compiler in the beta channel.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@jseyfried@petrochenkov@bors@alexcrichton@brson@nrc