Add `as_bytes()` for `FromUtf8Error`. by 3Hren · Pull Request #40290 · rust-lang/rust

3Hren · 2017-03-06T06:07:51Z

This change allows to obtain an underlying invalid UTF-8 bytes without FromUtf8Error destruction. Such method may be useful for example in a library that attempts to save both valid and invalid UTF-8 strings in some struct and to be able to provide immutable access to it without destruction.

Personally without this change I ended with Result<String, (Vec<u8>, Utf8Error), which almost copies the functionality of FromUtf8Error, but allows immutable view access.

rust-highfive · 2017-03-06T06:07:58Z

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @aturon (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

3Hren · 2017-03-06T06:25:46Z

Should I have to add a stability attribute? If yes - which one?

bluss · 2017-03-06T10:15:15Z

cc @SimonSapin

alexcrichton · 2017-03-06T17:24:15Z

Seems reasonable to me, thanks @3Hren!

Also yeah in terms of library stability this'll start out with an #[unstable] tag and then it'll go through the normal stabilization process. You don't have to create a tracking issue just yet, though. We can postpone that to just before the PR is merged.

aturon · 2017-03-28T23:37:19Z

Ping @3Hren, this is just waiting on the unstable attribute.

3Hren · 2017-03-29T07:50:28Z

@aturon sorry, completely forgot about this PR :(.
Fixed!

aturon · 2017-03-29T19:53:16Z

@3Hren Thanks! Note the Travis failure, which is legit.

3Hren · 2017-04-08T18:33:59Z

Oh, looks like there is a new linter.

Unstable feature 'from_utf8_error_as_bytes' needs to have a section in The Unstable Book

How can I fix this?

aturon · 2017-04-10T05:39:32Z

cc @rust-lang/docs, can you spell out the procedure here?

frewsxcv · 2017-04-10T15:00:40Z

Add a new file in this directory corresponding to name of the unstable feature and then just link to it from the summary file.

I plan to add a little README in https://github.com/rust-lang/rust/blob/master/src/doc/usntable-book/ soon describing this.

frewsxcv · 2017-04-10T18:15:19Z

@3Hren You'll also need to link to that new page from the summary file.

3Hren · 2017-04-11T11:05:37Z

Finally, random travis errors non-associated with the PR :)

Mark-Simulacrum · 2017-04-14T04:26:13Z

Can you remove the merge commit and force push? That'll both clean up the history and restart Travis.

This change allows to obtain an underlying invalid UTF-8 bytes without `FromUtf8Error` destruction. Such method may be useful for example in a library that attempts to save both valid and invalid UTF-8 strings in some struct and to be able to provide immutable access to it without destruction.

3Hren · 2017-04-14T06:47:16Z

Done.

Mark-Simulacrum · 2017-04-14T11:09:57Z

Error looks spurious.

[00:38:46] Rustbook (x86_64-unknown-linux-gnu) - unstable-book
[00:38:46] An error occured:
[00:38:46] Read-only file system (os error 30)
[00:38:46] [00:38:46] [00:38:46] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools/x86_64-unknown-linux-gnu/release/rustbook" "build" "/checkout/src/doc/unstable-book" "-d" "/checkout/obj/build/x86_64-unknown-linux-gnu/doc/unstable-book"
[00:38:46] expected success, got: exit code: 101
[00:38:46] [00:38:46] [00:38:46] Build completed unsuccessfully in 0:02:22
[00:38:46] Makefile:24: recipe for target 'all' failed
[00:38:46] make: *** [all] Error 1

frewsxcv · 2017-04-17T03:54:32Z

 - [fmt_internals](fmt-internals.md)
 - [fn_traits](fn-traits.md)
 - [fnbox](fnbox.md)
+- [field_init_shorthand](field-init-shorthand.md)


Is this line supposed to be here? This is causing the 'read only' fail that Travis is encountering

Looks like it landed here due to bad rebase.

3Hren · 2017-04-17T08:25:53Z

Passed!

arielb1 · 2017-04-18T08:52:57Z

Friendly ping for @aturon.

aturon · 2017-04-18T18:04:18Z

Huzzah!

@bors: r+

bors · 2017-04-18T18:04:19Z

📌 Commit bbdf190 has been approved by aturon

Add `as_bytes()` for `FromUtf8Error`. This change allows to obtain an underlying invalid UTF-8 bytes without `FromUtf8Error` destruction. Such method may be useful for example in a library that attempts to save both valid and invalid UTF-8 strings in some struct and to be able to provide immutable access to it without destruction. Personally without this change I ended with `Result<String, (Vec<u8>, Utf8Error)`, which almost copies the functionality of `FromUtf8Error`, but allows immutable view access.

Rollup of 6 pull requests - Successful merges: #40290, #41353, #41356, #41360, #41361, #41364 - Failed merges:

This will avoid obscure Travis CI error messages: * rust-lang#40290 (comment) Original mdbook issue: * https://github.com/azerupi/mdBook/issues/253 mdbook PR: * https://github.com/azerupi/mdBook/pull/254

Bump mdbook dep to pick up new 'create missing' toggle feature. This will avoid obscure Travis CI error messages: * rust-lang#40290 (comment) Original mdbook issue: * https://github.com/azerupi/mdBook/issues/253 mdbook PR: * https://github.com/azerupi/mdBook/pull/254

rust-highfive assigned aturon Mar 6, 2017

alexcrichton added the T-libs-api [DEPRECATED; DO NOT USE] label Mar 6, 2017

3Hren mentioned this pull request Mar 29, 2017
Tracking issue for the FromUtf8Error::as_bytes #40895
Closed

3Hren force-pushed the master branch from e510e10 to cb9954cCompare March 29, 2017 07:48

Mark-Simulacrum added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Apr 14, 2017

3Hren added 5 commits April 14, 2017 09:46

fix: add feature to doc tests
4cb9de4

refactor: add reason string
0eecd51

docs: track newly introduced unstable feature
4cea3f7

fix: add missing link in SUMMARY.md
3ae20de

3Hren force-pushed the master branch from 671a3e1 to 3ae20deCompare April 14, 2017 06:46

Mark-Simulacrum added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 14, 2017

frewsxcv reviewed Apr 17, 2017
View reviewed changes

frewsxcv mentioned this pull request Apr 17, 2017
mdbook build flag that doesn't implicitly create files and errors if bad path in SUMMARY.md rust-lang/mdBook#253
Closed

fix: remove field_init_shorthand from SUMMARY.md
bbdf190

carols10cents added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 17, 2017

frewsxcv mentioned this pull request Apr 18, 2017
Rollup of 6 pull requests #41373
Merged

bors added a commit that referenced this pull request Apr 18, 2017
Auto merge of#41373- frewsxcv:rollup, r=frewsxcv
9f2abad
Rollup of 6 pull requests - Successful merges: #40290, #41353, #41356, #41360, #41361, #41364 - Failed merges:

bors merged commit bbdf190 into rust-lang:masterApr 18, 2017

frewsxcv mentioned this pull request Apr 27, 2017
Bump mdbook dep to pick up new 'create missing' toggle feature. #41572
Merged

Uh oh!

Uh oh!

Conversation

3Hren commented Mar 6, 2017

Uh oh!

rust-highfive commented Mar 6, 2017

Uh oh!

3Hren commented Mar 6, 2017• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bluss commented Mar 6, 2017

Uh oh!

alexcrichton commented Mar 6, 2017

Uh oh!

aturon commented Mar 28, 2017

Uh oh!

3Hren commented Mar 29, 2017

Uh oh!

aturon commented Mar 29, 2017

Uh oh!

3Hren commented Apr 8, 2017

Uh oh!

aturon commented Apr 10, 2017

Uh oh!

frewsxcv commented Apr 10, 2017

Uh oh!

frewsxcv commented Apr 10, 2017

Uh oh!

3Hren commented Apr 11, 2017• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Mark-Simulacrum commented Apr 14, 2017

Uh oh!

3Hren commented Apr 14, 2017

Uh oh!

Mark-Simulacrum commented Apr 14, 2017

Uh oh!

frewsxcvApr 17, 2017

Choose a reason for hiding this comment

Uh oh!

3HrenApr 17, 2017

Choose a reason for hiding this comment

Uh oh!

3Hren commented Apr 17, 2017

Uh oh!

arielb1 commented Apr 18, 2017

Uh oh!

aturon commented Apr 18, 2017

Uh oh!

bors commented Apr 18, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

3Hren commented Mar 6, 2017•
edited
Loading

3Hren commented Apr 11, 2017•
edited
Loading