Uh oh!
There was an error while loading. Please reload this page.
Bump mdbook dep to pick up new 'create missing' toggle feature. - #41572
Conversation
rust-highfive
commented
Apr 27, 2017
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
frewsxcv
commented
Apr 27, 2017
frewsxcv
commented
Apr 27, 2017
Hold off on r+'ing this, I want to confirm this is working as intended. |
frewsxcv
commented
Apr 27, 2017
Blocked on https://github.com/azerupi/mdBook/pull/259. |
steveklabnik
commented
Apr 27, 2017
@frewsxcv looks like that was merged and published |
This will avoid obscure Travis CI error messages: * rust-lang#40290 (comment) Original mdbook issue: * https://github.com/azerupi/mdBook/issues/253 mdbook PR: * https://github.com/azerupi/mdBook/pull/254
cool, everything is working. @steveklabnik this is ready for review now |
frewsxcv
commented
Apr 27, 2017
Looks like the build was cancelled on Travis, but this should be still good to go. |
steveklabnik
commented
Apr 27, 2017
This looks good; I've restarted the build. r=me once travis passes. |
frewsxcv
commented
Apr 27, 2017
@bors r=steveklabnik |
bors
commented
Apr 27, 2017
📌 Commit a517a96 has been approved by |
Bump mdbook dep to pick up new 'create missing' toggle feature. This will avoid obscure Travis CI error messages: * rust-lang#40290 (comment) Original mdbook issue: * https://github.com/azerupi/mdBook/issues/253 mdbook PR: * https://github.com/azerupi/mdBook/pull/254
This will avoid obscure Travis CI error messages:
as_bytes()forFromUtf8Error. #40290 (comment)Original mdbook issue:
mdbook PR: