Update libc to 0.2.21 by malbarbo · Pull Request #40317 · rust-lang/rust

malbarbo · 2017-03-07T13:22:58Z

Update to include android aarch64 and x86 improvements.

rust-highfive · 2017-03-07T13:23:12Z

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @brson (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

alexcrichton · 2017-03-07T15:00:57Z

@bors: r+ rollup

bors · 2017-03-07T15:00:58Z

📌 Commit 4fd93df has been approved by alexcrichton

Update libc to 0.2.21 Update to include android aarch64 and x86 improvements.

frewsxcv · 2017-03-08T16:09:02Z

This appears to fail on Android:

https://travis-ci.org/rust-lang/rust/jobs/209003929

@bors r-

malbarbo · 2017-03-16T19:12:36Z

@frewsxcv libc 0.2.21 fixed the type of c_char from u8 to i8. I update the c_char on src/libstd/os/raw.rs to i8. This should fix the PR.

alexcrichton · 2017-03-16T20:23:52Z

@bors: r+

Thanks!

bors · 2017-03-16T20:23:53Z

📌 Commit 184b9c2 has been approved by alexcrichton

Update libc to 0.2.21 Update to include android aarch64 and x86 improvements.

frewsxcv · 2017-03-17T04:18:24Z

@bors r-

Looks like there's still an issue here: #40592 (comment)

malbarbo · 2017-03-17T13:28:18Z

I fixed the error.

Run src/ci/docker/run.sh dist-android and it almost worked... the dist tar balls was generated, but I got I error about rustbook:

Rustbook (arm-linux-androideabi) - nomicon
An error occured:
Read-only file system (os error 30)
command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools/x86_64-unknown-linux-gnu/release/rustbook" "build" "/checkout/src/doc/nomicon" "-d" "/checkout/obj/build/arm-linux-androideabi/doc/nomicon"
expected success, got: exit code: 101

Maybe a local error?

I also rebased...

alexcrichton · 2017-03-17T14:17:01Z

@bors: r+

bors · 2017-03-17T14:17:01Z

📌 Commit 3435c60 has been approved by alexcrichton

Update libc to 0.2.21 Update to include android aarch64 and x86 improvements.

frewsxcv · 2017-03-18T13:42:57Z

Here's another one: #40629 (comment)

@bors r-

malbarbo · 2017-03-25T20:20:25Z

@alexcrichton Now both src/ci/docker/run.sh arm-android and src/ci/docker/run.sh dist-android run successful in my machine. Let's see how it goes on travis.

alexcrichton · 2017-03-27T14:02:49Z

@bors: r+

Ok!

bors · 2017-03-27T14:02:50Z

📌 Commit 24be899 has been approved by alexcrichton

Update libc to 0.2.21 Update to include android aarch64 and x86 improvements.

Rollup of 19 pull requests - Successful merges: #40317, #40516, #40524, #40606, #40683, #40751, #40778, #40813, #40818, #40819, #40824, #40828, #40832, #40833, #40837, #40849, #40852, #40853, #40865 - Failed merges:

rust-highfive assigned brson Mar 7, 2017

frewsxcv added a commit to frewsxcv/rust that referenced this pull request Mar 8, 2017
Rollup merge ofrust-lang#40317- malbarbo:update-libc, r=alexcrichton
e652321
Update libc to 0.2.21 Update to include android aarch64 and x86 improvements.

frewsxcv mentioned this pull request Mar 8, 2017
Rollup of 19 pull requests #40357
Closed

frewsxcv added a commit to frewsxcv/rust that referenced this pull request Mar 17, 2017
Rollup merge ofrust-lang#40317- malbarbo:update-libc, r=alexcrichton
374dd2a
Update libc to 0.2.21 Update to include android aarch64 and x86 improvements.

frewsxcv mentioned this pull request Mar 17, 2017
Rollup of 26 pull requests #40591
Closed

frewsxcv added a commit to frewsxcv/rust that referenced this pull request Mar 17, 2017
Rollup merge ofrust-lang#40317- malbarbo:update-libc, r=alexcrichton
14ef6a8
Update libc to 0.2.21 Update to include android aarch64 and x86 improvements.

frewsxcv mentioned this pull request Mar 17, 2017
Rollup of 26 pull requests #40592
Closed

malbarbo force-pushed the update-libc branch from 184b9c2 to 3435c60Compare March 17, 2017 13:22

frewsxcv added a commit to frewsxcv/rust that referenced this pull request Mar 17, 2017
Rollup merge ofrust-lang#40317- malbarbo:update-libc, r=alexcrichton
b449fda
Update libc to 0.2.21 Update to include android aarch64 and x86 improvements.

frewsxcv mentioned this pull request Mar 17, 2017
Rollup of 15 pull requests #40615
Closed

frewsxcv added a commit to frewsxcv/rust that referenced this pull request Mar 17, 2017
Rollup merge ofrust-lang#40317- malbarbo:update-libc, r=alexcrichton
ef47812
Update libc to 0.2.21 Update to include android aarch64 and x86 improvements.

frewsxcv mentioned this pull request Mar 17, 2017
Rollup of 16 pull requests #40616
Closed

frewsxcv added a commit to frewsxcv/rust that referenced this pull request Mar 17, 2017
Rollup merge ofrust-lang#40317- malbarbo:update-libc, r=alexcrichton
982f155
Update libc to 0.2.21 Update to include android aarch64 and x86 improvements.

frewsxcv mentioned this pull request Mar 17, 2017
Rollup of 12 pull requests #40618
Closed

frewsxcv mentioned this pull request Mar 18, 2017
Rollup of 8 pull requests #40626
Closed

frewsxcv added a commit to frewsxcv/rust that referenced this pull request Mar 18, 2017
Rollup merge ofrust-lang#40317- malbarbo:update-libc, r=alexcrichton
d85ed11
Update libc to 0.2.21 Update to include android aarch64 and x86 improvements.

frewsxcv mentioned this pull request Mar 18, 2017
Rollup of 10 pull requests #40629
Closed

malbarbo added 4 commits March 25, 2017 11:03

Update libc to 0.2.21
6344d08

Fix c_char (u8 -> i8) definition for i686-linux-android
a7add43

Fix libc::bind call on aarch64-linux-android
b45c631

Avoid using libc::sigemptyset on Android
24be899

malbarbo force-pushed the update-libc branch from 3435c60 to 24be899Compare March 25, 2017 20:16

alexcrichton added a commit to alexcrichton/rust that referenced this pull request Mar 27, 2017
Rollup merge ofrust-lang#40317- malbarbo:update-libc, r=alexcrichton
e857e29
Update libc to 0.2.21 Update to include android aarch64 and x86 improvements.

alexcrichton mentioned this pull request Mar 27, 2017
Rollup of 19 pull requests #40867
Merged

bors merged commit 24be899 into rust-lang:masterMar 29, 2017

jdm mentioned this pull request Mar 29, 2017
Compilation for Android x86 fails servo/rust-mozjs#345
Closed

SimonSapin mentioned this pull request Mar 29, 2017
Breaking change: c_char sign #40903
Closed

malbarbo mentioned this pull request Mar 30, 2017
i686-linux-android libc and libstd disagree on c_char rust-lang/libc#561
Closed

sfackler mentioned this pull request May 9, 2017
fix cross compile with target i686-linux-android rust-openssl/rust-openssl#626
Closed

hlzhang mentioned this pull request May 24, 2017
Doesn't compile with target i686-linux-android rust-openssl/rust-openssl#625
Closed

Uh oh!

Uh oh!

Conversation

malbarbo commented Mar 7, 2017

Uh oh!

rust-highfive commented Mar 7, 2017

Uh oh!

alexcrichton commented Mar 7, 2017

Uh oh!

bors commented Mar 7, 2017

Uh oh!

frewsxcv commented Mar 8, 2017

Uh oh!

malbarbo commented Mar 16, 2017

Uh oh!

alexcrichton commented Mar 16, 2017

Uh oh!

bors commented Mar 16, 2017

Uh oh!

frewsxcv commented Mar 17, 2017

Uh oh!

malbarbo commented Mar 17, 2017

Uh oh!

alexcrichton commented Mar 17, 2017

Uh oh!

bors commented Mar 17, 2017

Uh oh!

frewsxcv commented Mar 18, 2017

Uh oh!

malbarbo commented Mar 25, 2017

Uh oh!

alexcrichton commented Mar 27, 2017

Uh oh!

bors commented Mar 27, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants