std: Don't cache stdio handles on Windows by alexcrichton · Pull Request #40516 · rust-lang/rust

alexcrichton · 2017-03-14T14:56:24Z

This alters the stdio code on Windows to always call GetStdHandle whenever the
stdio read/write functions are called as this allows us to track changes to the
value over time (such as if a process calls SetStdHandle while it's running).

Closes#40490

rust-highfive · 2017-03-14T14:56:27Z

r? @aturon

(rust_highfive has picked a reviewer for you, use r? to override)

aturon · 2017-03-21T22:37:19Z

@bors: r+

bors · 2017-03-21T22:37:20Z

📌 Commit af72b06 has been approved by aturon

bors · 2017-03-23T09:11:38Z

🔒 Merge conflict

This alters the stdio code on Windows to always call `GetStdHandle` whenever the stdio read/write functions are called as this allows us to track changes to the value over time (such as if a process calls `SetStdHandle` while it's running). Closesrust-lang#40490

alexcrichton · 2017-03-23T14:23:26Z

@bors: r=aturon

bors · 2017-03-23T14:23:27Z

📌 Commit 5ca8a73 has been approved by aturon

bors · 2017-03-24T14:10:21Z

⌛ Testing commit 5ca8a73 with merge b1d0e15...

bors · 2017-03-24T15:42:11Z

💔 Test failed - status-travis

alexcrichton · 2017-03-24T15:56:04Z

@bors: retry

sccache Spurious failures in sccache #40240

…uron std: Don't cache stdio handles on Windows This alters the stdio code on Windows to always call `GetStdHandle` whenever the stdio read/write functions are called as this allows us to track changes to the value over time (such as if a process calls `SetStdHandle` while it's running). Closesrust-lang#40490

Rollup of 11 pull requests - Successful merges: #40347, #40501, #40516, #40524, #40540, #40642, #40683, #40764, #40778, #40807, #40809 - Failed merges: #40771

bors · 2017-03-25T11:36:16Z

⌛ Testing commit 5ca8a73 with merge d11f245...

bors · 2017-03-25T11:42:07Z

💔 Test failed - status-travis

arielb1 · 2017-03-25T12:30:05Z

try to fix the build on emscripten #40821
@bors retry

bors · 2017-03-25T13:48:14Z

⌛ Testing commit 5ca8a73 with merge 25c8108...

bors · 2017-03-25T13:54:07Z

💔 Test failed - status-travis

arielb1 · 2017-03-25T14:39:22Z

try to fix the build on emscripten #40821
@bors retry

bors · 2017-03-25T16:02:14Z

⌛ Testing commit 5ca8a73 with merge f4f9468...

bors · 2017-03-25T16:08:07Z

💔 Test failed - status-travis

arielb1 · 2017-03-25T19:36:34Z

try to fix the build on emscripten #40821
@bors retry

bors · 2017-03-26T16:36:31Z

⌛ Testing commit 5ca8a73 with merge c65e7de...

std: Don't cache stdio handles on Windows This alters the stdio code on Windows to always call `GetStdHandle` whenever the stdio read/write functions are called as this allows us to track changes to the value over time (such as if a process calls `SetStdHandle` while it's running). Closes#40490

bors · 2017-03-26T19:37:09Z

💔 Test failed - status-appveyor

alexcrichton · 2017-03-27T14:35:53Z

@bors: retry * debuginfo mingw timeout - #40835

…

On Sun, Mar 26, 2017 at 2:37 PM, bors ***@***.***> wrote: 💔 Test failed - status-appveyor <https://ci.appveyor.com/project/rust-lang/rust/build/1.0.2570> — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#40516 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAD95L7xpobTPOKTiRwcbsAEgD3AGmcRks5rpr5ngaJpZM4McsLJ> .

bors · 2017-03-27T17:17:13Z

⌛ Testing commit 5ca8a73 with merge 71123e4...

std: Don't cache stdio handles on Windows This alters the stdio code on Windows to always call `GetStdHandle` whenever the stdio read/write functions are called as this allows us to track changes to the value over time (such as if a process calls `SetStdHandle` while it's running). Closes#40490

arielb1 · 2017-03-27T19:43:06Z

test [debuginfo-gdb] debuginfo-gdb\basic-types-globals-metadata.rs has been running for over 60 seconds
https://ci.appveyor.com/project/rust-lang/rust/build/1.0.2588/job/cw6jsfpfa6ih0krm

Debuginfo tests spurious failures on MinGW #40835 (debuginfo timeout)

@bors retry

…uron std: Don't cache stdio handles on Windows This alters the stdio code on Windows to always call `GetStdHandle` whenever the stdio read/write functions are called as this allows us to track changes to the value over time (such as if a process calls `SetStdHandle` while it's running). Closesrust-lang#40490

Rollup of 19 pull requests - Successful merges: #40317, #40516, #40524, #40606, #40683, #40751, #40778, #40813, #40818, #40819, #40824, #40828, #40832, #40833, #40837, #40849, #40852, #40853, #40865 - Failed merges:

rust-highfive assigned aturon Mar 14, 2017

alexcrichton mentioned this pull request Mar 14, 2017
SCCACHE_ERROR_LOG + trace logs == doesn't work on windows mozilla/sccache#80
Closed

alexcrichton added the T-libs-api [DEPRECATED; DO NOT USE] label Mar 14, 2017

alexcrichton force-pushed the no-cache-handles branch from af72b06 to 5ca8a73Compare March 23, 2017 14:22

alexcrichton mentioned this pull request Mar 25, 2017
Rollup of 11 pull requests #40810
Closed

bors added a commit that referenced this pull request Mar 25, 2017
Auto merge of#40810- alexcrichton:rollup, r=alexcrichton
40ae49a
Rollup of 11 pull requests - Successful merges: #40347, #40501, #40516, #40524, #40540, #40642, #40683, #40764, #40778, #40807, #40809 - Failed merges: #40771

bors added a commit that referenced this pull request Mar 25, 2017
Auto merge of#40810- alexcrichton:rollup, r=alexcrichton
ed9108d
Rollup of 11 pull requests - Successful merges: #40347, #40501, #40516, #40524, #40540, #40642, #40683, #40764, #40778, #40807, #40809 - Failed merges: #40771

bors mentioned this pull request Mar 27, 2017
rustdoc to accept # at the start of a markdown file #40560 #40828
Merged

alexcrichton mentioned this pull request Mar 27, 2017
Rollup of 19 pull requests #40867
Merged

bors merged commit 5ca8a73 into rust-lang:masterMar 29, 2017

alexcrichton deleted the no-cache-handles branch April 4, 2017 23:08

henninglive mentioned this pull request Jun 11, 2017
Improved error handling and documentation Detegr/rust-ctrlc#23
Merged

coderabbitaiBot mentioned this pull request Aug 2, 2026
fix: address PR 68 review findings (doctor UX) numan-cli/numan#79
Merged
5 tasks

Uh oh!

Uh oh!

Conversation

alexcrichton commented Mar 14, 2017

Uh oh!

rust-highfive commented Mar 14, 2017

Uh oh!

aturon commented Mar 21, 2017

Uh oh!

bors commented Mar 21, 2017

Uh oh!

bors commented Mar 23, 2017

Uh oh!

alexcrichton commented Mar 23, 2017

Uh oh!

bors commented Mar 23, 2017

Uh oh!

bors commented Mar 24, 2017

Uh oh!

bors commented Mar 24, 2017

Uh oh!

alexcrichton commented Mar 24, 2017

Uh oh!

bors commented Mar 25, 2017

Uh oh!

bors commented Mar 25, 2017

Uh oh!

arielb1 commented Mar 25, 2017

Uh oh!

bors commented Mar 25, 2017

Uh oh!

bors commented Mar 25, 2017

Uh oh!

arielb1 commented Mar 25, 2017

Uh oh!

bors commented Mar 25, 2017

Uh oh!

bors commented Mar 25, 2017

Uh oh!

arielb1 commented Mar 25, 2017

Uh oh!

bors commented Mar 26, 2017

Uh oh!

bors commented Mar 26, 2017

Uh oh!

alexcrichton commented Mar 27, 2017 via email

Uh oh!

bors commented Mar 27, 2017

Uh oh!

arielb1 commented Mar 27, 2017• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

arielb1 commented Mar 27, 2017•
edited
Loading