Uh oh!
There was an error while loading. Please reload this page.
[beta] macro: fix issue with sequence repetitions on beta - #40411
Closed
jseyfried wants to merge 1 commit into
Closed
[beta] macro: fix issue with sequence repetitions on beta#40411jseyfried wants to merge 1 commit into
jseyfried wants to merge 1 commit into
Conversation
alexcrichton
commented
Mar 10, 2017
Member
Thanks so much for the quick fix @jseyfried! Also holy cow that's a christmas tree of linked issues. |
brson
commented
Mar 10, 2017
Contributor
Thank you @jseyfried |
brson
commented
Mar 10, 2017
Contributor
Cherry-picked onto #40401 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes#40381 by fixing #39390 on beta.
#39118 (currently in beta) worsened preexisting issue #39390, which I fixed entirely on nightly in #39419.
#39419 is large and the fix is a breaking change (in theory), so I tried to be clever and make beta bug-for-bug compatible with stable in #39730. However, #39390 didn't impact stable as much as I thought and I ended up introducing a new bug (#40381).
This PR fixes#39390 entirely on beta as minimally as possible. While it is technically a [breaking-change], we haven't seen any breakage from #39419 on the nightlies or with Crater.
r? @nrc