Uh oh!
There was an error while loading. Please reload this page.
Rollup of 16 pull requests - #40415
Closed
arielb1 wants to merge 35 commits into
Closed
Conversation
This causes problems when first cloning and bootstrapping the repository unfortunately, so let's ensure that Cargo sticks around in its own workspace. Because Cargo is a submodule it's not available by default on the inital clone of the rust-lang/rust repository. Normally it's the responsibility of the rustbuild to take care of this, but unfortunately to build rustbuild itself we need to resolve the workspace conflicts. To deal with this we'll just have to ensure that all submodules are in their own workspace, which sort of makes sense anyway as updates to dependencies as bugfixes to Cargo should go to rust-lang/cargo instead of rust-lang/rust. In any case this commit removes Cargo from the global workspace which should resolve the issues that we've been seeing. To actually perform this the `cargo` submodule has been moved to the top directory to ensure it's outside the scope of `src/Cargo.toml` as a workspace.
This commit alters the compiler to exit quickly if the only output being emitted is `dep-info`, which doesn't need a lot of other information to generate. Closesrust-lang#40328
Keeps MIR cleaner, `StorageLive(_: !)` makes no sense anyway.
arielb1
commented
Mar 10, 2017
ContributorAuthor
@bors r+ p=1000 |
bors
commented
Mar 10, 2017
Collaborator
📌 Commit 349258e has been approved by |
bors
commented
Mar 10, 2017
Collaborator
🔒 Merge conflict |
arielb1
commented
Mar 10, 2017
ContributorAuthor
@bors retry force |
arielb1
commented
Mar 10, 2017
ContributorAuthor
@bors retry |
arielb1
commented
Mar 10, 2017
ContributorAuthor
@bors r+ p=1000 retry force |
arielb1
commented
Mar 10, 2017
ContributorAuthor
@bors r+ |
bors
commented
Mar 10, 2017
Collaborator
📌 Commit bead894 has been approved by |
alexcrichton
commented
Mar 10, 2017
Member
I'm going to in parallel try to create a different rollup, but let's still try to land this one first. |
alexcrichton
commented
Mar 10, 2017
Member
@bors: retry |
bors
commented
Mar 10, 2017
Collaborator
🔒 Merge conflict |
added 15 commits
March 10, 2017 07:47
…elix Fix suggestion span error with a line containing multibyte characters This PR fixes broken suggestions caused by multibyte characters. e.g. for this code, rustc provides a broken suggestion ([playground](https://is.gd/DWGLu7)): ```rust fn main() { let tup = (1,); println!("☃{}", tup[0]); } ``` ``` error: cannot index a value of type `({integer},)` --> <anon>:3:21 | 3 | println!("☃{}", tup[0]); | ^^^^^^ | help: to access tuple elements, use tuple indexing syntax as shown | println!("☃{}"tup.00]); error: aborting due to previous error ``` `CodeSuggestion::splice_lines` is misusing `Loc.col` (`CharPos`) as a byte offset when slicing source.
Better docs of rusty parts of typeck
Clean up rustdoc css r? @rust-lang/docs
Don't put Cargo into the rustc workspace This causes problems when first cloning and bootstrapping the repository unfortunately, so let's ensure that Cargo sticks around in its own workspace. Because Cargo is a submodule it's not available by default on the inital clone of the rust-lang/rust repository. Normally it's the responsibility of the rustbuild to take care of this, but unfortunately to build rustbuild itself we need to resolve the workspace conflicts. To deal with this we'll just have to ensure that all submodules are in their own workspace, which sort of makes sense anyway as updates to dependencies as bugfixes to Cargo should go to rust-lang/cargo instead of rust-lang/rust. In any case this commit removes Cargo from the global workspace which should resolve the issues that we've been seeing. To actually perform this the `cargo` submodule has been moved to a new `vendor` directory to ensure it's outside the scope of `src/Cargo.toml` as a workspace. Closesrust-lang#40284
Allow lints to check Bodys directly r? @eddyb babysteps towards fixing https://github.com/Manishearth/rust-clippy/issues/1580 (disable certain lints in const environments, since they make no sense there (yet))
rustc: Exit quickly on only `--emit dep-info` This commit alters the compiler to exit quickly if the only output being emitted is `dep-info`, which doesn't need a lot of other information to generate. Closesrust-lang#40328
…akis Update syntax for `pub(restricted)` Update the syntax before stabilization. cc rust-lang#32409 r? @nikomatsakis
save-analysis: cope with lack of method data after a type error Fixesrust-lang#39957 r? @eddyb
Give spans to individual path segments in AST And use these spans in path resolution diagnostics. The spans are spans of identifiers in segments, not whole segments. I'm not sure what spans are more useful in general, but identifier spans are a better fit for resolve errors. HIR still doesn't have spans. Fixesrust-lang#38927 (comment)rust-lang#38890 (comment) r? @nrc@eddyb
Do not bother creating StorageLive for TyNever Keeps MIR cleaner, `StorageLive(_: !)` makes no sense anyway. r? @eddyb
Fix UB in repr(packed) tests r? @arielb1 cc rust-lang#37609 and rust-lang#27060
Box docs: no allocation is done for ZSTs. Updated to add a small bit saying that ZSTs don't actually allocate on `Box::new`.
emit !align attributes on stores of operand pairs This avoids another case of missing-align UB. cc rust-lang#40373 r? @eddyb
…or, r=alexcrichton Distinguish the ways `CStr::from_bytes_with_nul` can fail
Implement placement-in protocol for `VecDeque` CC rust-lang#30172 r? @nagisa
alexcrichton
commented
Mar 10, 2017
Member
bors
commented
Mar 10, 2017
Collaborator
📌 Commit b6c0676 has been approved by |
bors
commented
Mar 10, 2017
Collaborator
⌛ Testing commit b6c0676 with merge eb802bb... |
bors
commented
Mar 10, 2017
Collaborator
💔 Test failed - status-appveyor |
alexcrichton
commented
Mar 10, 2017
Member
@bors: retry
|
bors
commented
Mar 10, 2017
Collaborator
⌛ Testing commit b6c0676 with merge 6b39f97... |
bors
commented
Mar 10, 2017
Collaborator
💔 Test failed - status-appveyor |
alexcrichton
commented
Mar 10, 2017
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
--emit dep-info#40336, Update syntax forpub(restricted)#40340, save-analysis: cope with lack of method data after a type error #40344, Fix missing backtick typo #40345, Give spans to individual path segments in AST #40369, Do not bother creating StorageLive for TyNever #40372, Fix UB in repr(packed) tests #40373, Box docs: no allocation is done for ZSTs. #40379, emit !align attributes on stores of operand pairs #40385, Distinguish the waysCStr::from_bytes_with_nulcan fail #40386, Implement placement-in protocol forVecDeque#40389