Uh oh!
There was an error while loading. Please reload this page.
Fix UB in repr(packed) tests - #40373
Merged
Merged
Conversation
TimNN
commented
Mar 8, 2017
ContributorAuthor
Actually, this is still no UB free I think -- as far as I can tell the initialisation of the fixed size array containing a packed struct does generate aligned loads, which is probably a bug in |
arielb1
commented
Mar 8, 2017
Contributor
Yup there's a bug in loading/storing fields of pairs. I'll fix that tomorrow. |
nrc
commented
Mar 9, 2017
Member
r? @arielb1 |
arielb1
commented
Mar 9, 2017
Contributor
@bors r+ rollup |
bors
commented
Mar 9, 2017
Collaborator
📌 Commit 79a7ee8 has been approved by |
arielb1 pushed a commit
to arielb1/rust
that referenced
this pull request
Mar 9, 2017
Fix UB in repr(packed) tests r? @arielb1 cc rust-lang#37609 and rust-lang#27060
arielb1 pushed a commit
to arielb1/rust
that referenced
this pull request
Mar 9, 2017
emit !align attributes on stores of operand pairs This avoids another case of missing-align UB. cc rust-lang#40373 r? @eddyb
alexcrichton added a commit
to alexcrichton/rust
that referenced
this pull request
Mar 10, 2017
Fix UB in repr(packed) tests r? @arielb1 cc rust-lang#37609 and rust-lang#27060
alexcrichton added a commit
to alexcrichton/rust
that referenced
this pull request
Mar 10, 2017
emit !align attributes on stores of operand pairs This avoids another case of missing-align UB. cc rust-lang#40373 r? @eddyb
alexcrichton pushed a commit
to arielb1/rust
that referenced
this pull request
Mar 10, 2017
Fix UB in repr(packed) tests r? @arielb1 cc rust-lang#37609 and rust-lang#27060
alexcrichton pushed a commit
to arielb1/rust
that referenced
this pull request
Mar 10, 2017
emit !align attributes on stores of operand pairs This avoids another case of missing-align UB. cc rust-lang#40373 r? @eddyb
alexcrichton added a commit
to alexcrichton/rust
that referenced
this pull request
Mar 10, 2017
Fix UB in repr(packed) tests r? @arielb1 cc rust-lang#37609 and rust-lang#27060
alexcrichton added a commit
to alexcrichton/rust
that referenced
this pull request
Mar 11, 2017
Fix UB in repr(packed) tests r? @arielb1 cc rust-lang#37609 and rust-lang#27060
bors added a commit
that referenced
this pull request
Mar 11, 2017
Rollup of 38 pull requests - Successful merges: #39202, #39820, #39918, #39921, #40092, #40146, #40199, #40225, #40239, #40257, #40259, #40261, #40277, #40278, #40287, #40297, #40311, #40315, #40319, #40324, #40336, #40340, #40344, #40345, #40367, #40369, #40372, #40373, #40379, #40385, #40386, #40389, #40400, #40404, #40410, #40422, #40423, #40424 - Failed merges: #40220, #40329, #40426
bors added a commit
that referenced
this pull request
Mar 11, 2017
Rollup of 38 pull requests - Successful merges: #39202, #39820, #39918, #39921, #40092, #40146, #40199, #40225, #40239, #40257, #40259, #40261, #40277, #40278, #40287, #40297, #40311, #40315, #40319, #40324, #40336, #40340, #40344, #40345, #40367, #40369, #40372, #40373, #40379, #40385, #40386, #40389, #40400, #40404, #40410, #40422, #40423, #40424 - Failed merges: #40220, #40329, #40426
arielb1 pushed a commit
to arielb1/rust
that referenced
this pull request
Mar 11, 2017
Fix UB in repr(packed) tests r? @arielb1 cc rust-lang#37609 and rust-lang#27060
arielb1 pushed a commit
to arielb1/rust
that referenced
this pull request
Mar 11, 2017
emit !align attributes on stores of operand pairs This avoids another case of missing-align UB. cc rust-lang#40373 r? @eddyb
arielb1 pushed a commit
to arielb1/rust
that referenced
this pull request
Mar 11, 2017
Fix UB in repr(packed) tests r? @arielb1 cc rust-lang#37609 and rust-lang#27060
arielb1 added a commit
to arielb1/rust
that referenced
this pull request
Mar 13, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
r? @arielb1
cc #37609 and #27060