Uh oh!
There was an error while loading. Please reload this page.
Rollup of 9 pull requests - #40506
Closed
frewsxcv wants to merge 22 commits into
Closed
Conversation
It is more robust to not fail if any directory in a path was created concurrently. This change lifts rustc internal `create_dir_racy` that was created to handle such conditions to be new `create_dir_all` implementation.
It will now correctly fail on existing non-directories.
As of last year with version 'Sierra', the Mac operating system is now called 'macOS'.
Fix race condition in fs::create_dir_all The code would crash if the directory was created after create_dir_all checked whether the directory already existed. This was contrary to the documentation which claimed to create the directory if it doesn't exist, implying (but not stating) that there would not be a failure due to the directory existing.
Add test for issue rust-lang#29595Closesrust-lang#29595 Couldn't get this to run locally, all the compile-fail tests are ignored... let's see what Travis says.
…bnik Update usages of 'OSX' (and other old names) to 'macOS'. As of last year with version 'Sierra', the Mac operating system is now called 'macOS'.
…g, r=steveklabnik Remove doc about highlighting code in other languages rust-lang#40301 This doesn't appear to be true any longer, so removing it to avoid confusion. See rust-lang#40301 Thoughts: - may be a good idea to remove "Let's discuss the details of these code blocks.", as there's not much being discussed at this point; - does `text` still work? r? @steveklabnik
Updating README.md to point to the correct doc location
fix format grammar This is just a trivial change to get the escaped squigglies into the grammar. r? @steveklabnik
…rewsxcv Using X headings rust-lang#39850 Fix for issue rust-lang#39850, the headings should now be 1, 2, and 3.
…sfackler std: remove a workaround for privacy limitations `std::thread::Thread` implements a non-exported `NewThread` trait to allow for internal-only use of `Thread::new`. Nowadays we have `pub(crate)`, which accomplishes the same thing but much more idiomatically. Rustdoc handles this correctly (I checked and I didn't see `Thread::new` on the rustdoc entry for `Thread` with this change), and the stage1 `rustc` emits the correct error still (I'm assuming that the stage1 compiler uses my `libstd`?): ``` $ ./build/x86_64-apple-darwin/stage1/bin/rustc test.rs error: method `new` is private --> test.rs:4:18 | 4 | let thread = thread::Thread::new(None); | ^^^^^^^^^^^^^^^^^^^ error: aborting due to previous error ```
rust-highfive
commented
Mar 14, 2017
Contributor
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
frewsxcv
commented
Mar 14, 2017
ContributorAuthor
@bors r+ p=10 |
bors
commented
Mar 14, 2017
Collaborator
📌 Commit 110129b has been approved by |
bors
commented
Mar 14, 2017
Collaborator
⌛ Testing commit 110129b with merge 9847c66... |
bors
commented
Mar 14, 2017
Collaborator
💔 Test failed - status-appveyor |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
srcforptr::write{,_unaligned}#40387, Add test for issue #29595 #40433, Update usages of 'OSX' (and other old names) to 'macOS'. #40457, Remove doc about highlighting code in other languages #40301 #40466, Updating README.md to point to the correct doc location #40467, fix format grammar #40495, Using X headings #39850 #40496, std: remove a workaround for privacy limitations #40503