Uh oh!
There was an error while loading. Please reload this page.
Add test for issue #29595 - #40433
Merged
Merged
Conversation
rust-highfive
commented
Mar 10, 2017
Contributor
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @aturon (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
mattico
commented
Mar 10, 2017
ContributorAuthor
estebank
commented
Mar 13, 2017
Contributor
@mattico Instead of using a |
aturon
commented
Mar 13, 2017
Contributor
bors
commented
Mar 13, 2017
Collaborator
✌️ @estebank can now approve this pull request |
mattico
commented
Mar 13, 2017
ContributorAuthor
@estebank done. |
Contributor
There was a problem hiding this comment.
mattico
commented
Mar 13, 2017
ContributorAuthor
@estebank fixed now 👍 |
estebank
commented
Mar 14, 2017
Contributor
@bors r+ rollup |
bors
commented
Mar 14, 2017
Collaborator
📌 Commit 5e49f79 has been approved by |
frewsxcv added a commit
to frewsxcv/rust
that referenced
this pull request
Mar 14, 2017
Add test for issue rust-lang#29595Closesrust-lang#29595 Couldn't get this to run locally, all the compile-fail tests are ignored... let's see what Travis says.
frewsxcv added a commit
to frewsxcv/rust
that referenced
this pull request
Mar 14, 2017
Add test for issue rust-lang#29595Closesrust-lang#29595 Couldn't get this to run locally, all the compile-fail tests are ignored... let's see what Travis says.
frewsxcv added a commit
to frewsxcv/rust
that referenced
this pull request
Mar 15, 2017
Add test for issue rust-lang#29595Closesrust-lang#29595 Couldn't get this to run locally, all the compile-fail tests are ignored... let's see what Travis says.
bors added a commit
that referenced
this pull request
Mar 15, 2017
bors added a commit
that referenced
this pull request
Mar 16, 2017
frewsxcv added a commit
to frewsxcv/rust
that referenced
this pull request
Mar 17, 2017
Add test for issue rust-lang#29595Closesrust-lang#29595 Couldn't get this to run locally, all the compile-fail tests are ignored... let's see what Travis says.
frewsxcv added a commit
to frewsxcv/rust
that referenced
this pull request
Mar 17, 2017
Add test for issue rust-lang#29595Closesrust-lang#29595 Couldn't get this to run locally, all the compile-fail tests are ignored... let's see what Travis says.
frewsxcv added a commit
to frewsxcv/rust
that referenced
this pull request
Mar 17, 2017
Add test for issue rust-lang#29595Closesrust-lang#29595 Couldn't get this to run locally, all the compile-fail tests are ignored... let's see what Travis says.
frewsxcv added a commit
to frewsxcv/rust
that referenced
this pull request
Mar 17, 2017
Add test for issue rust-lang#29595Closesrust-lang#29595 Couldn't get this to run locally, all the compile-fail tests are ignored... let's see what Travis says.
frewsxcv added a commit
to frewsxcv/rust
that referenced
this pull request
Mar 17, 2017
Add test for issue rust-lang#29595Closesrust-lang#29595 Couldn't get this to run locally, all the compile-fail tests are ignored... let's see what Travis says.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes#29595
Couldn't get this to run locally, all the compile-fail tests are ignored... let's see what Travis says.