appveyor: Use Ninja to build LLVM on MinGW by alexcrichton · Pull Request #40548 · rust-lang/rust

alexcrichton · 2017-03-15T14:37:54Z

I have a suspicion that MinGW's make is the cause of #40546 rather than anything
else, but that's purely a suspicion without any facts to back it up. In any case
we'll eventually be moving the MSVC build over to Ninja in order to leverage
sccache regardless, so this commit simply jumpstarts that process by downloading
Ninja for use by MinGW anyway.

I'm not sure if this closes#40546 for real, but this is my current best shot at
closing it out, so...

Closes#40546

rust-highfive · 2017-03-15T14:38:04Z

r? @brson

(rust_highfive has picked a reviewer for you, use r? to override)

nagisa · 2017-03-15T15:37:53Z

(Unrelated, but ninja is a good thing to use for at least the three major platforms)

alexcrichton · 2017-03-15T15:41:10Z

Yeah I was thinking that if we start going in this direction we may as well use Ninja on all platforms as it provides a nice cross-platform experience for the builders at least (and hopefully reduces the surface area for bugs...)

brson · 2017-03-15T19:57:15Z

@bors r+

bors · 2017-03-15T19:57:16Z

📌 Commit 18423e5 has been approved by brson

bors · 2017-03-21T19:35:40Z

🔒 Merge conflict

bstrie · 2017-03-21T21:02:02Z

@bors r=brson

bors · 2017-03-21T21:02:03Z

📌 Commit 845d193 has been approved by brson

alexcrichton · 2017-03-21T22:06:43Z

@bors: p=1

#40546 has caused what I believe are 6 spurious failures and I think this is the solution, so let's try to stabilize our builds.

bors · 2017-03-21T22:21:23Z

⌛ Testing commit 845d193 with merge 054d0da...

bors · 2017-03-21T22:34:40Z

💔 Test failed - status-appveyor

alexcrichton · 2017-03-21T22:39:22Z

@bors: r=brson

bors · 2017-03-21T22:39:23Z

📌 Commit d0ac908 has been approved by brson

bors · 2017-03-21T23:11:53Z

🔒 Merge conflict

alexcrichton · 2017-03-21T23:12:27Z

@bors: r=brson

bors · 2017-03-21T23:12:27Z

📌 Commit 963b525 has been approved by brson

bors · 2017-03-22T01:41:51Z

⌛ Testing commit 963b525 with merge 8355ad9...

bors · 2017-03-22T01:49:06Z

💔 Test failed - status-appveyor

alexcrichton · 2017-03-22T02:18:29Z

@bors: r=brson

bors · 2017-03-22T02:18:29Z

💡 This pull request was already approved, no need to approve it again.

This pull request previously failed. You should add more commits to fix the bug, or use retry to trigger a build again.
There's another pull request that is currently being tested, blocking this pull request: Refactor parsing of trait object types #40043

bors · 2017-03-22T02:18:30Z

📌 Commit 963b525 has been approved by brson

I have a suspicion that MinGW's make is the cause of rust-lang#40546 rather than anything else, but that's purely a suspicion without any facts to back it up. In any case we'll eventually be moving the MSVC build over to Ninja in order to leverage sccache regardless, so this commit simply jumpstarts that process by downloading Ninja for use by MinGW anyway. I'm not sure if this closesrust-lang#40546 for real, but this is my current best shot at closing it out, so... Closesrust-lang#40546

alexcrichton · 2017-03-22T02:19:14Z

@bors: r=brson

bors · 2017-03-22T02:19:14Z

📌 Commit 6ae2234 has been approved by brson

bors · 2017-03-22T10:40:36Z

⌛ Testing commit 6ae2234 with merge ca2f437...

bors · 2017-03-22T11:53:38Z

💔 Test failed - status-appveyor

alexcrichton · 2017-03-22T14:06:09Z

@bors: retry * failed to upload to s3 #39074

…

On Wed, Mar 22, 2017 at 6:53 AM, bors ***@***.***> wrote: 💔 Test failed - status-appveyor <https://ci.appveyor.com/project/rust-lang/rust/build/1.0.2485> — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#40548 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAD95EqvqDh9f7jyhRPIYraQkxvBQ4hRks5roQvEgaJpZM4MeB5w> .

bors · 2017-03-22T14:32:18Z

⌛ Testing commit 6ae2234 with merge 5dc595b...

appveyor: Use Ninja to build LLVM on MinGW I have a suspicion that MinGW's make is the cause of #40546 rather than anything else, but that's purely a suspicion without any facts to back it up. In any case we'll eventually be moving the MSVC build over to Ninja in order to leverage sccache regardless, so this commit simply jumpstarts that process by downloading Ninja for use by MinGW anyway. I'm not sure if this closes#40546 for real, but this is my current best shot at closing it out, so... Closes#40546

bors · 2017-03-22T15:50:10Z

💔 Test failed - status-travis

alexcrichton · 2017-03-22T15:58:43Z

@bors: retry * osx openssl failure - #40417

…

On Wed, Mar 22, 2017 at 10:50 AM, bors ***@***.***> wrote: 💔 Test failed - status-travis <https://travis-ci.org/rust-lang/rust/builds/213853641> — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#40548 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAD95LMhDCUHj_kvTDoIb5o7gzh4wRLgks5roUM0gaJpZM4MeB5w> .

bors · 2017-03-22T18:52:42Z

⌛ Testing commit 6ae2234 with merge 8aad2a2...

appveyor: Use Ninja to build LLVM on MinGW I have a suspicion that MinGW's make is the cause of #40546 rather than anything else, but that's purely a suspicion without any facts to back it up. In any case we'll eventually be moving the MSVC build over to Ninja in order to leverage sccache regardless, so this commit simply jumpstarts that process by downloading Ninja for use by MinGW anyway. I'm not sure if this closes#40546 for real, but this is my current best shot at closing it out, so... Closes#40546

frewsxcv · 2017-03-22T23:28:05Z

This is not making progress. No point in making in waiting any longer.

@bors retry

For posterity: https://s3.amazonaws.com/archive.travis-ci.org/jobs/213962210/log.txt

bors · 2017-03-22T23:28:12Z

⌛ Testing commit 6ae2234 with merge b8e178c...

appveyor: Use Ninja to build LLVM on MinGW I have a suspicion that MinGW's make is the cause of rust-lang#40546 rather than anything else, but that's purely a suspicion without any facts to back it up. In any case we'll eventually be moving the MSVC build over to Ninja in order to leverage sccache regardless, so this commit simply jumpstarts that process by downloading Ninja for use by MinGW anyway. I'm not sure if this closesrust-lang#40546 for real, but this is my current best shot at closing it out, so... Closesrust-lang#40546

frewsxcv · 2017-03-22T23:31:01Z

@bors retry

rollup includes this pr

Rollup of 13 pull requests - Successful merges: #40509, #40523, #40548, #40578, #40619, #40689, #40690, #40692, #40704, #40722, #40723, #40725, #40732 - Failed merges:

alexcrichton · 2017-03-23T00:33:50Z

Thanks @frewsxcv! BTW that error looks like the linux machine literally shut down, and it seems that Travis may not handle that gracefully...

bors · 2017-03-23T02:30:10Z

⌛ Testing commit 6ae2234 with merge c62e532...

rust-highfive assigned brson Mar 15, 2017

retep998 force-pushed the appveyor-ninja branch from 18423e5 to 845d193Compare March 21, 2017 20:37

alexcrichton mentioned this pull request Mar 21, 2017
Spurious failures in sccache #40240
Closed

alexcrichton force-pushed the appveyor-ninja branch from 845d193 to d0ac908Compare March 21, 2017 22:39

alexcrichton force-pushed the appveyor-ninja branch from d0ac908 to 963b525Compare March 21, 2017 23:12

alexcrichton force-pushed the appveyor-ninja branch from 963b525 to 6ae2234Compare March 22, 2017 02:19

frewsxcv mentioned this pull request Mar 22, 2017
Rollup of 13 pull requests #40748
Merged

bors added a commit that referenced this pull request Mar 22, 2017
Auto merge of#40748- frewsxcv:rollup, r=frewsxcv
c62e532
Rollup of 13 pull requests - Successful merges: #40509, #40523, #40548, #40578, #40619, #40689, #40690, #40692, #40704, #40722, #40723, #40725, #40732 - Failed merges:

bors merged commit 6ae2234 into rust-lang:masterMar 23, 2017

alexcrichton deleted the appveyor-ninja branch April 4, 2017 23:07

Uh oh!

Uh oh!

Conversation

alexcrichton commented Mar 15, 2017

Uh oh!

rust-highfive commented Mar 15, 2017

Uh oh!

nagisa commented Mar 15, 2017

Uh oh!

alexcrichton commented Mar 15, 2017

Uh oh!

brson commented Mar 15, 2017

Uh oh!

bors commented Mar 15, 2017

Uh oh!

bors commented Mar 21, 2017

Uh oh!

bstrie commented Mar 21, 2017

Uh oh!

bors commented Mar 21, 2017

Uh oh!

alexcrichton commented Mar 21, 2017

Uh oh!

bors commented Mar 21, 2017

Uh oh!

bors commented Mar 21, 2017

Uh oh!

alexcrichton commented Mar 21, 2017

Uh oh!

bors commented Mar 21, 2017

Uh oh!

bors commented Mar 21, 2017

Uh oh!

alexcrichton commented Mar 21, 2017

Uh oh!

bors commented Mar 21, 2017

Uh oh!

bors commented Mar 22, 2017

Uh oh!

bors commented Mar 22, 2017

Uh oh!

alexcrichton commented Mar 22, 2017

Uh oh!

bors commented Mar 22, 2017

Uh oh!

bors commented Mar 22, 2017

Uh oh!

alexcrichton commented Mar 22, 2017

Uh oh!

bors commented Mar 22, 2017

Uh oh!

bors commented Mar 22, 2017

Uh oh!

bors commented Mar 22, 2017

Uh oh!

alexcrichton commented Mar 22, 2017 via email

Uh oh!

bors commented Mar 22, 2017

Uh oh!

bors commented Mar 22, 2017

Uh oh!

alexcrichton commented Mar 22, 2017 via email

Uh oh!

bors commented Mar 22, 2017

Uh oh!

frewsxcv commented Mar 22, 2017

Uh oh!

bors commented Mar 22, 2017

Uh oh!

frewsxcv commented Mar 22, 2017

Uh oh!

alexcrichton commented Mar 23, 2017

Uh oh!

bors commented Mar 23, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone