Skip to content

str: Make docs consistently punctuated - #40692

Merged
bors merged 1 commit into
rust-lang:masterfrom
SamWhited:consistent_str_docs_punctuation
Mar 23, 2017
Merged

str: Make docs consistently punctuated#40692
bors merged 1 commit into
rust-lang:masterfrom
SamWhited:consistent_str_docs_punctuation

Conversation

@SamWhited

@SamWhitedSamWhited commented Mar 21, 2017

Copy link
Copy Markdown
Contributor

Every so slightly pointless one character PR, but this was driving me nuts while reading the docs a moment ago (all the other public structs have descriptions that end in a full-stop).

@rust-highfive

Copy link
Copy Markdown
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @BurntSushi (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@frewsxcv

Copy link
Copy Markdown
Contributor

Thanks!

@bors r+ rollup

@bors

bors commented Mar 21, 2017

Copy link
Copy Markdown
Collaborator

📌 Commit e3da6e7 has been approved by frewsxcv

@SamWhited

Copy link
Copy Markdown
ContributorAuthor

Travis apparently hiccuped, but I don't have the authority to kick it.

@frewsxcv

Copy link
Copy Markdown
Contributor

I could kick it, but I'm pretty sure your changes won't fail any tests, so probably not worth a two hour build ;)

Your changes are queued up to be tested and merged: https://buildbot2.rust-lang.org/homu/queue/rust

@bors

bors commented Mar 21, 2017

Copy link
Copy Markdown
Collaborator

🔒 Merge conflict

@bstrie

Copy link
Copy Markdown
Contributor

I've rebased this branch due to a submodule conflict that invalidated many PRs.

@bstrie

Copy link
Copy Markdown
Contributor

@bors r+ rollup

@bors

bors commented Mar 21, 2017

Copy link
Copy Markdown
Collaborator

📌 Commit 49db656 has been approved by bstrie

frewsxcv added a commit to frewsxcv/rust that referenced this pull request Mar 22, 2017
…uation, r=bstrie
str: Make docs consistently punctuated
Every so slightly pointless one character PR, but this was driving me nuts while reading the docs a moment ago (all the [other public structs](https://doc.rust-lang.org/std/str/index.html#structs) have descriptions that end in a full-stop).
@frewsxcvfrewsxcv mentioned this pull request Mar 22, 2017
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Mar 22, 2017
…uation, r=bstrie
str: Make docs consistently punctuated
Every so slightly pointless one character PR, but this was driving me nuts while reading the docs a moment ago (all the [other public structs](https://doc.rust-lang.org/std/str/index.html#structs) have descriptions that end in a full-stop).
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Mar 22, 2017
…uation, r=bstrie
str: Make docs consistently punctuated
Every so slightly pointless one character PR, but this was driving me nuts while reading the docs a moment ago (all the [other public structs](https://doc.rust-lang.org/std/str/index.html#structs) have descriptions that end in a full-stop).
@frewsxcvfrewsxcv mentioned this pull request Mar 22, 2017
bors added a commit that referenced this pull request Mar 22, 2017
Rollup of 13 pull requests
- Successful merges: #40509, #40523, #40548, #40578, #40619, #40689, #40690, #40692, #40704, #40722, #40723, #40725, #40732
- Failed merges:
@bors
bors merged commit 49db656 into rust-lang:masterMar 23, 2017
@SamWhited
SamWhited deleted the consistent_str_docs_punctuation branch March 23, 2017 02:31
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@SamWhited@rust-highfive@frewsxcv@bors@bstrie@BurntSushi