Skip to content

Update gcc used for dist-x86-linux builds - #40617

Merged
bors merged 1 commit into
rust-lang:masterfrom
TimNN:dist-update-gcc
Mar 23, 2017
Merged

Update gcc used for dist-x86-linux builds#40617
bors merged 1 commit into
rust-lang:masterfrom
TimNN:dist-update-gcc

Conversation

@TimNN

@TimNNTimNN commented Mar 17, 2017

Copy link
Copy Markdown
Contributor

GCC 4.7 is too old to build LLVM 4.0, so this PR updates to 4.8.

r? @alexcrichton (I'll ping you again once travis is green and the test commit is removed).

@alexcrichton

alexcrichton commented Mar 17, 2017

Copy link
Copy Markdown
Member

r=me when it's green

@TimNN

TimNN commented Mar 18, 2017

Copy link
Copy Markdown
ContributorAuthor

The build was killed during openssl install, that didn't reproduce locally so I have restarted the travis build.

@TimNN

TimNN commented Mar 18, 2017

Copy link
Copy Markdown
ContributorAuthor

The build timed out again.

@alexcrichton

alexcrichton commented Mar 19, 2017

Copy link
Copy Markdown
Member

That looks like it got plenty far enough though to verify this works, want to send it to bors?

@TimNN

TimNN commented Mar 19, 2017

Copy link
Copy Markdown
ContributorAuthor

@alexcrichton: Sure, I removed the test commit.

@alexcrichton

alexcrichton commented Mar 19, 2017

Copy link
Copy Markdown
Member

@bors: r+

@bors

bors commented Mar 19, 2017

Copy link
Copy Markdown
Collaborator

📌 Commit 09d12d0 has been approved by alexcrichton

@frewsxcvfrewsxcv mentioned this pull request Mar 19, 2017
Closed
@ishitatsuyuki

ishitatsuyuki commented Mar 20, 2017

Copy link
Copy Markdown
Contributor

The base, CentOS 5 is about to expire; why not just upgrade to a decent distro?

frewsxcv added a commit to frewsxcv/rust that referenced this pull request Mar 20, 2017
@frewsxcv
Rollup merge ofrust-lang#40617- TimNN:dist-update-gcc, r=alexcrichton
da08827
Update gcc used for dist-x86-linux builds
GCC 4.7 is too old to build LLVM 4.0, so this PR updates to 4.8.
r? @alexcrichton (I'll ping you again once travis is green and the test commit is removed).
@frewsxcvfrewsxcv mentioned this pull request Mar 20, 2017
Closed
@bors

bors commented Mar 21, 2017

Copy link
Copy Markdown
Collaborator

🔒 Merge conflict

@TimNN

TimNN commented Mar 21, 2017

Copy link
Copy Markdown
ContributorAuthor

rebased

@alexcrichton

alexcrichton commented Mar 21, 2017

Copy link
Copy Markdown
Member

@bors: r+

(feel free to @bors: r=alexcrichton whenever you rebase)

@bors

bors commented Mar 21, 2017

Copy link
Copy Markdown
Collaborator

📌 Commit 88d5645 has been approved by `alexcrichton``

@bors

bors commented Mar 21, 2017

Copy link
Copy Markdown
Collaborator

📌 Commit 88d5645 has been approved by alexcrichton

@TimNN

TimNN commented Mar 21, 2017

Copy link
Copy Markdown
ContributorAuthor

@alexcrichton: I don't think I have bors rights, so bors: r=alexcrichton wouldn't work, right?

@alexcrichton

alexcrichton commented Mar 21, 2017

Copy link
Copy Markdown
Member

Whoa sorry I had no idea!

Now you've got r+ :)

@alexcrichton

alexcrichton commented Mar 21, 2017

Copy link
Copy Markdown
Member

or rather, after I deploy that

@TimNN

TimNN commented Mar 21, 2017

Copy link
Copy Markdown
ContributorAuthor

@alexcrichton: Thanks!

@cuviper

cuviper commented Mar 21, 2017

Copy link
Copy Markdown
Member

The base, CentOS 5 is about to expire; why not just upgrade to a decent distro?

Let's leave out subjective assessments of what's "decent" please. It matters to keep the base OS old for maximum ABI compatibility, so when we do move, the next logical choice would be CentOS 6.

frewsxcv added a commit to frewsxcv/rust that referenced this pull request Mar 22, 2017
@frewsxcv
Rollup merge ofrust-lang#40617- TimNN:dist-update-gcc, r=alexcrichton
c5f3bf1
Update gcc used for dist-x86-linux builds
GCC 4.7 is too old to build LLVM 4.0, so this PR updates to 4.8.
r? @alexcrichton (I'll ping you again once travis is green and the test commit is removed).
@frewsxcvfrewsxcv mentioned this pull request Mar 22, 2017
Closed
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Mar 23, 2017
@frewsxcv
Rollup merge ofrust-lang#40617- TimNN:dist-update-gcc, r=alexcrichton
a419ce9
Update gcc used for dist-x86-linux builds
GCC 4.7 is too old to build LLVM 4.0, so this PR updates to 4.8.
r? @alexcrichton (I'll ping you again once travis is green and the test commit is removed).
@frewsxcvfrewsxcv mentioned this pull request Mar 23, 2017
Merged
bors added a commit that referenced this pull request Mar 23, 2017
@bors
Auto merge of#40752- frewsxcv:rollup, r=frewsxcv
7c7753d
Rollup of 6 pull requests
- Successful merges: #39891, #40518, #40542, #40617, #40678, #40696
- Failed merges:
@bors
bors merged commit 88d5645 into rust-lang:masterMar 23, 2017
@TimNN
TimNN deleted the dist-update-gcc branch March 23, 2017 06:39
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@alexcrichtonalexcrichton

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@TimNN@alexcrichton@bors@ishitatsuyuki@cuviper