Uh oh!
There was an error while loading. Please reload this page.
Some preparations for directly computing the ICH of crate-metadata. - #40678
Conversation
There was a problem hiding this comment.
Nit: can you add a blank line in the {} block? This formatting makes it hard to see that the arms are a distinct group from the line below.
There was a problem hiding this comment.
I feel like this is a classic case where it'd be good to enumerate the Rvalue variants (so that if a new variant is added, or a variant changes, we are likely to notice this case)
nikomatsakis
commented
Mar 20, 2017
r=me if the match is made exhaustive |
michaelwoerister
commented
Mar 21, 2017
@bors r=nikomatsakis |
bors
commented
Mar 21, 2017
📌 Commit 00fed35 has been approved by |
bors
commented
Mar 21, 2017
🔒 Merge conflict |
bstrie
commented
Mar 21, 2017
There's a submodule conflict causing some mass PR invalidations, but rebasing reveals many other conflicts which I don't feel comfortable fixing myself (I already feel dirty enough rebasing commits in other people's repos...). |
bstrie
commented
Mar 21, 2017
@bors r=nikomatsakis |
bors
commented
Mar 21, 2017
📌 Commit c9a61b1 has been approved by |
michaelwoerister
commented
Mar 22, 2017
@bors r=nikomatsakis Rebased |
bors
commented
Mar 22, 2017
📌 Commit 45deab4 has been approved by |
…tsakis Some preparations for directly computing the ICH of crate-metadata. This PR contains some small fixes in preparation for direct metadata hashing. It mostly just moves stuff into places where it will be needed (making the module structure slightly cleaner along the way) and it fixes some omissions in the MIR region eraser. r? @nikomatsakis
This PR contains some small fixes in preparation for direct metadata hashing. It mostly just moves stuff into places where it will be needed (making the module structure slightly cleaner along the way) and it fixes some omissions in the MIR region eraser.
r? @nikomatsakis