Uh oh!
There was an error while loading. Please reload this page.
A couple minor improvements for tidy error handling. - #40653
Merged
Conversation
Contributor
There was a problem hiding this comment.
*bad = true should probably a part of tidy_error
alexcrichton
commented
Mar 20, 2017
Member
r=me with @petrochenkov's comment |
frewsxcv
commented
Mar 23, 2017
ContributorAuthor
Going to wait for #40694 to merge. |
bors
commented
Mar 31, 2017
Collaborator
☔ The latest upstream changes (presumably #40950) made this pull request unmergeable. Please resolve the merge conflicts. |
Otherwise we get the standard Rust panic message alongside "some tidy checks failed" which seems unnecessary.
frewsxcv
commented
Apr 2, 2017
ContributorAuthor
Comments have been addressed. |
frewsxcv
commented
Apr 9, 2017
ContributorAuthor
@bors r=alexcrichton |
bors
commented
Apr 9, 2017
Collaborator
📌 Commit f789d89 has been approved by |
bors
commented
Apr 9, 2017
Collaborator
⌛ Testing commit f789d89 with merge 6719895... |
bors
commented
Apr 9, 2017
Collaborator
💔 Test failed - status-appveyor |
frewsxcv
commented
Apr 9, 2017
ContributorAuthor
bors
commented
Apr 9, 2017
Collaborator
bors added a commit
that referenced
this pull request
Apr 9, 2017
A couple minor improvements for tidy error handling. None
bors
commented
Apr 10, 2017
Collaborator
☀️ Test successful - status-appveyor, status-travis |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.