Sync all unstable features with Unstable Book; add tidy lint. by frewsxcv · Pull Request #40694 · rust-lang/rust

frewsxcv · 2017-03-21T04:37:22Z

Add a tidy lint that checks for...

Unstable Book sections with no corresponding SUMMARY.md links
unstable features that don't have Unstable Book sections
Unstable Book sections that don't have corresponding unstable features

rust-highfive · 2017-03-21T04:37:29Z

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @steveklabnik (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

frewsxcv · 2017-03-21T04:42:31Z

r? @rust-lang/docs

GuillaumeGomez · 2017-03-21T10:17:12Z

Urg, that's a LOT of code! Fine by me otherwise.

frewsxcv · 2017-03-21T12:30:48Z

@GuillaumeGomez Which code are you talking about?

steveklabnik

looks good to me, but one stylistic issue

steveklabnik · 2017-03-21T13:52:45Z

so, I purposefully put these at the end of sections that do not have docs, just to keep it consistent; would you mind updating the ones you've added to have this?

Addressed in the latest force push.

bors · 2017-03-21T19:38:45Z

☔ The latest upstream changes (presumably #40693) made this pull request unmergeable. Please resolve the merge conflicts.

ghost · 2017-03-21T22:11:24Z

I'm confused by the deletion of sort-unstable.md.
This is a new feature, not a stabilized one - am I missing something?

frewsxcv · 2017-03-21T22:13:49Z

@stjepangsort_unstable hasn't landed in master yet, though I do see the open PR. If that one merges before this one, I'll remove the deletion.

frewsxcv · 2017-03-21T23:10:24Z

Oh, the implementation of the feature landed five days ago. Huh, I'll have to check why my tidy lint wanted it deleted. Good catch

ghost · 2017-03-21T23:15:07Z

Actually, the PR for the feature was submitted 5 days ago, and it landed an hour ago.
Nothing wrong with tidy lint. You need a rebase at this point. :)

frewsxcv · 2017-03-23T00:58:58Z

Anyone else see anything? If everything looks good, just give me a "r=me" thing. I don't want to approve this until after #40619 merges.

Addressed.

bors · 2017-03-23T02:35:20Z

☔ The latest upstream changes (presumably #40748) made this pull request unmergeable. Please resolve the merge conflicts.

frewsxcv · 2017-03-23T03:47:56Z

#40619 merged. This is ready to go now. r? @steveklabnik

frewsxcv · 2017-03-23T20:19:27Z

I have no idea what Travis is getting hung up on here. If anyone has thoughts, let me know.

frewsxcv · 2017-03-24T03:28:23Z

I don't want this to bit-rot while I try to debug this, so I extracted all the non-tidy-lint changes into a new PR: #40786

Add all unstable features to the Unstable Book, also remove a few that either no longer exist or were promoted to stable. These changes were extracted out of rust-lang#40694

…atures, r=steveklabnik Add all unstable features to Unstable Book. Add all unstable features to the Unstable Book, also remove a few that either no longer exist or were promoted to stable. These changes were extracted out of rust-lang#40694

frewsxcv · 2017-03-29T18:19:58Z

This should be ready to go now.

r? @steveklabnik

bors · 2017-03-31T05:50:30Z

⌛ Testing commit 53b35bd with merge 6acc9bf...

bors · 2017-03-31T08:52:01Z

💔 Test failed - status-travis

frewsxcv · 2017-03-31T14:14:54Z

@bors retry

bors · 2017-03-31T15:34:20Z

⌛ Testing commit 53b35bd with merge 09f9d21...

Add a tidy lint that checks for... * Unstable Book sections with no corresponding SUMMARY.md links * unstable features that don't have Unstable Book sections * Unstable Book sections that don't have corresponding unstable features

frewsxcv · 2017-03-31T15:41:36Z

@bors r=steveklabnik p=1

new feature got added a few hours ago

going to give this a p=1 to make sure this stops getting out of sync

bors · 2017-03-31T15:41:36Z

📌 Commit eef2a95 has been approved by steveklabnik

…teveklabnik Sync all unstable features with Unstable Book; add tidy lint. Add a tidy lint that checks for... * Unstable Book sections with no corresponding SUMMARY.md links * unstable features that don't have Unstable Book sections * Unstable Book sections that don't have corresponding unstable features

Rollup of 10 pull requests - Successful merges: #40694, #40842, #40869, #40888, #40898, #40904, #40925, #40928, #40929, #40934 - Failed merges:

rust-highfive assigned steveklabnik Mar 21, 2017

frewsxcv force-pushed the unstable-book-checker branch from 685425a to fc22d6eCompare March 21, 2017 04:42

rust-highfive unassigned steveklabnik Mar 21, 2017

steveklabnik previously requested changes Mar 21, 2017
View reviewed changes

frewsxcv force-pushed the unstable-book-checker branch from fc22d6e to a294a32Compare March 23, 2017 00:57

frewsxcv mentioned this pull request Mar 23, 2017
A couple minor improvements for tidy error handling. #40653
Merged

frewsxcv force-pushed the unstable-book-checker branch from a294a32 to 5baaa80Compare March 23, 2017 03:47

rust-highfive assigned steveklabnik Mar 23, 2017

frewsxcv force-pushed the unstable-book-checker branch from 5baaa80 to 04d6641Compare March 24, 2017 00:59

frewsxcv mentioned this pull request Mar 24, 2017
Add all unstable features to Unstable Book. #40786
Merged

frewsxcv force-pushed the unstable-book-checker branch from 04d6641 to 09ff832Compare March 29, 2017 18:19

frewsxcv mentioned this pull request Mar 30, 2017
Rollup of 7 pull requests #40930
Closed

This was referenced Mar 30, 2017
Rollup of 7 pull requests #40932
Closed
rustc: Stabilize the #![windows_subsystem] attribute #40870
Merged

frewsxcv mentioned this pull request Mar 31, 2017
Rollup of 10 pull requests #40948
Closed

frewsxcv force-pushed the unstable-book-checker branch from 53b35bd to eef2a95Compare March 31, 2017 15:40

frewsxcv mentioned this pull request Mar 31, 2017
Rollup of 10 pull requests #40950
Merged

bors added a commit that referenced this pull request Mar 31, 2017
Auto merge of#40950- frewsxcv:rollup, r=frewsxcv
40feadb
Rollup of 10 pull requests - Successful merges: #40694, #40842, #40869, #40888, #40898, #40904, #40925, #40928, #40929, #40934 - Failed merges:

bors merged commit eef2a95 into rust-lang:masterMar 31, 2017

frewsxcv deleted the unstable-book-checker branch March 31, 2017 19:46

frewsxcv mentioned this pull request Apr 2, 2017
Add a resource-reusing method to ToOwned#41009
Merged

jyn514 mentioned this pull request May 25, 2025
consider nudging people to document new features in the unstable book #141527
Open

Uh oh!

Uh oh!

Conversation

frewsxcv commented Mar 21, 2017• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rust-highfive commented Mar 21, 2017

Uh oh!

frewsxcv commented Mar 21, 2017

Uh oh!

GuillaumeGomez commented Mar 21, 2017

Uh oh!

frewsxcv commented Mar 21, 2017

Uh oh!

steveklabnik left a comment

Choose a reason for hiding this comment

Uh oh!

steveklabnikMar 21, 2017

Choose a reason for hiding this comment

Uh oh!

frewsxcvMar 23, 2017

Choose a reason for hiding this comment

Uh oh!

bors commented Mar 21, 2017

Uh oh!

ghost commented Mar 21, 2017

Uh oh!

frewsxcv commented Mar 21, 2017

Uh oh!

frewsxcv commented Mar 21, 2017

Uh oh!

ghost commented Mar 21, 2017• edited by ghost Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

frewsxcv commented Mar 23, 2017

Uh oh!

bors commented Mar 23, 2017

Uh oh!

frewsxcv commented Mar 23, 2017

Uh oh!

frewsxcv commented Mar 23, 2017

Uh oh!

frewsxcv commented Mar 24, 2017

Uh oh!

frewsxcv commented Mar 29, 2017

Uh oh!

bors commented Mar 31, 2017

Uh oh!

bors commented Mar 31, 2017

Uh oh!

frewsxcv commented Mar 31, 2017

Uh oh!

bors commented Mar 31, 2017

Uh oh!

frewsxcv commented Mar 31, 2017

Uh oh!

bors commented Mar 31, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

frewsxcv commented Mar 21, 2017•
edited
Loading

ghost commented Mar 21, 2017•
edited by ghost
Loading