[Windows] Enable building rustc with "pthreads" flavor of mingw. by vadimcn · Pull Request #40805 · rust-lang/rust

vadimcn · 2017-03-24T22:56:21Z

Tested on mingw-w64 packaged with msys2.

r? @alexcrichton

cc #40123

alexcrichton · 2017-03-27T15:22:10Z

r+ from me!

Let's see if we can land #40524 though to rebase out the original commit (that PR has had some fixes/revisions as well)

alexcrichton · 2017-03-27T15:22:15Z

er, land that first though*

TimNN · 2017-03-27T16:59:52Z

I think the appveyor config still needs to be adjusted -- either to remove the custom mingw downloads or to replace the mingw downloads with the pthread versions (to make us independent from changes to the appveyor build environment).

alexcrichton · 2017-03-27T18:52:18Z

Ideally I'd actually prefer if we didn't have to change the toolchain because that would signify a large breaking change that'd be much more difficult to deal with. I think @vadimcn said though that the dll/staticlib were present in both toolchains, they'd just be ignored on the win32 threading one I think.

TimNN · 2017-03-27T18:56:59Z

Mh, wasn't the whole point of this that we could switch to the pthread toolchains, because they implement std::thread (which is currently needed for LLVM 4.0)?

alexcrichton · 2017-03-27T18:58:45Z

Ah true yes, we'll want to switch compiling the compiler to the pthreads toolchain. I'd like to see if this lands alone though because we should continue to be able to work with a win32 toolchain. Maybe one day we can add a bot for that but in the meantime we just need to make sure there's a transition path for win32 toolchain users to the pthread toolchain.

At the very least we can land the pthread compiler change for rustc in the llvm 4.0 PR, but I'd also be fine with a separate pr (after this one) to do that change independently.

bors · 2017-03-30T19:54:36Z

☔ The latest upstream changes (presumably #40524) made this pull request unmergeable. Please resolve the merge conflicts.

Make sure we link to the static libpthread, so that compiled Rust binaries do not depend on winpthread1.dll.

…d line.

vadimcn · 2017-03-31T01:39:18Z

@bors r=alexcrichton

bors · 2017-03-31T01:39:19Z

📌 Commit ad3f6e0 has been approved by alexcrichton

bors · 2017-03-31T13:50:13Z

⌛ Testing commit ad3f6e0 with merge 273fcd1...

bors · 2017-03-31T14:09:50Z

💔 Test failed - status-appveyor

alexcrichton · 2017-03-31T15:47:16Z

@bors: retry * ar.exe error #40546

…

On Fri, Mar 31, 2017 at 8:09 AM, bors ***@***.***> wrote: 💔 Test failed - status-appveyor <https://ci.appveyor.com/project/rust-lang/rust/build/1.0.2653> — You are receiving this because you were assigned. Reply to this email directly, view it on GitHub <#40805 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAD95Mlgt9vibjc4ZysJM0iJIlVXlDKuks5rrQkwgaJpZM4Mo2jd> .

bors · 2017-04-01T11:42:21Z

⌛ Testing commit ad3f6e0 with merge c374e2f...

bors · 2017-04-01T12:46:09Z

💔 Test failed - status-travis

alexcrichton · 2017-04-01T13:17:10Z

@bors: retry * openssl failed to build #40417

…

On Sat, Apr 1, 2017 at 6:46 AM, bors ***@***.***> wrote: 💔 Test failed - status-travis <https://travis-ci.org/rust-lang/rust/builds/217503973> — You are receiving this because you were assigned. Reply to this email directly, view it on GitHub <#40805 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAD95EpRLXJ_c9mNfzpqd3tzc1zuzj_lks5rrkcSgaJpZM4Mo2jd> .

bors · 2017-04-01T20:40:14Z

⌛ Testing commit ad3f6e0 with merge a3d82bd...

tamird · 2017-03-31T20:36:51Z

 }
 }
+
+ // LLVM requires symbols from this library, but apparently they're not printeds


s/printeds/printed/

bors · 2017-04-01T21:08:06Z

💔 Test failed - status-travis

alexcrichton · 2017-04-01T21:52:03Z

@bors: retry

sccache failue Spurious failures in sccache #40240

bors · 2017-04-02T04:39:06Z

⌛ Testing commit ad3f6e0 with merge 597944d...

bors · 2017-04-02T05:06:06Z

💔 Test failed - status-travis

vadimcn · 2017-04-02T09:05:41Z

Another sccache failure?

TimNN · 2017-04-02T09:08:13Z

Looks like it :(

ERROR:sccache::server: [Error(Msg("failed to spawn child"), State { next_error: Some(Error { repr: Os { code: 32, message: "Broken pipe" } }) })] lli.cpp.o
ERROR:sccache::server: [Error { repr: Os { code: 32, message: "Broken pipe" } }] lli.cpp.o

vadimcn · 2017-04-02T09:12:33Z

@bors: retry

bors · 2017-04-02T09:24:14Z

⌛ Testing commit ad3f6e0 with merge cd6f950...

bors · 2017-04-02T10:30:06Z

💔 Test failed - status-travis

alexcrichton · 2017-04-03T22:24:40Z

@bors: retry * spurious musl segfault #38618

…

On Sun, Apr 2, 2017 at 4:30 AM, bors ***@***.***> wrote: 💔 Test failed - status-travis <https://travis-ci.org/rust-lang/rust/builds/217730842> — You are receiving this because you were assigned. Reply to this email directly, view it on GitHub <#40805 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAD95Eifog6KoDeWaTdW26PK1b920BFnks5rr3ivgaJpZM4Mo2jd> .

bors · 2017-04-05T09:04:16Z

⌛ Testing commit ad3f6e0 with merge 49133bb...

bors · 2017-04-05T09:23:25Z

💔 Test failed - status-appveyor

TimNN · 2017-04-05T09:35:06Z

@bors retry

Spurious failures on AppVeyor due to ar.exe errors #40546

bors · 2017-04-06T03:42:37Z

⌛ Testing commit ad3f6e0 with merge 1a9b382...

@alexcrichton

[Windows] Enable building rustc with "pthreads" flavor of mingw. Tested on mingw-w64 packaged with msys2. r? @alexcrichton cc #40123

bors · 2017-04-06T06:07:38Z

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing 1a9b382 to master...

alexcrichton · 2017-05-05T15:51:32Z

This PR caused a few regression such as #41416 and #41607 so tagging relnotes at least. We haven't reverted yet and if we end up not doing so we'll want to mention this in compatibility nodes, namely:

Tweaking the link order of local static/dynamic libraries (respecting the order on given rather than having the compiler reorder)
Tweaking how MinGW is linked, so native code linked to dynamic libraries may require manually linking the gcc support library (for the native code itself)

rust-highfive assigned alexcrichton Mar 24, 2017

vadimcn force-pushed the msys-mingw branch from 6a8860e to 8efcf72Compare March 26, 2017 07:54

retep998 mentioned this pull request Mar 27, 2017
Adjust how native static libraries are linked #40504
Closed

vadimcn added 5 commits March 30, 2017 16:31

Emit linker hints for all library kinds.
78c3a49

libgcc_eh may depend on libpthread.
7c2fc62
Make sure we link to the static libpthread, so that compiled Rust binaries do not depend on winpthread1.dll.

Fix stage0->stage1 build when using "pthreads" mingw compiler.
3b1ba01

Make sure that -lole32 ends up *after* LLVM libs on the linker comman…
0f87203
…d line.

Include libpthread into mingw package.
ad3f6e0

vadimcn force-pushed the msys-mingw branch from 8efcf72 to ad3f6e0Compare March 30, 2017 23:47

tamird reviewed Apr 1, 2017
View reviewed changes

bors added a commit that referenced this pull request Apr 6, 2017
Auto merge of#40805- vadimcn:msys-mingw, r=alexcrichton
1a9b382
[Windows] Enable building rustc with "pthreads" flavor of mingw. Tested on mingw-w64 packaged with msys2. r? @alexcrichton cc #40123

bors merged commit ad3f6e0 into rust-lang:masterApr 6, 2017

bors mentioned this pull request Apr 6, 2017
-Z linker-flavor #40018
Merged

TimNN mentioned this pull request Apr 8, 2017
LLVM 4.0 Upgrade #40123
Merged
5 tasks

vadimcn mentioned this pull request Apr 8, 2017
RFC: Provide only std for windows-gnu and not rustc#41165
Closed

mbrubeck mentioned this pull request May 2, 2017
build script fails to link #41416
Closed

alexcrichton mentioned this pull request May 3, 2017
rustdoc beta linking trouble in MinGW #41607
Closed

alexcrichton added the relnotes Marks issues that should be documented in the release notes of the next release. label May 5, 2017

ctaggart mentioned this pull request May 24, 2017
[Windows] libpthread missing exports, so I can not link #42194
Closed

brson mentioned this pull request May 25, 2017
Updated releases notes for 1.18 #41953
Merged

alexcrichton mentioned this pull request Jun 19, 2017
rustc 1.18 regression: order of linker arguments changed #42606
Closed

Uh oh!

Uh oh!

Conversation

vadimcn commented Mar 24, 2017

Uh oh!

alexcrichton commented Mar 27, 2017

Uh oh!

alexcrichton commented Mar 27, 2017

Uh oh!

TimNN commented Mar 27, 2017

Uh oh!

alexcrichton commented Mar 27, 2017

Uh oh!

TimNN commented Mar 27, 2017

Uh oh!

alexcrichton commented Mar 27, 2017

Uh oh!

bors commented Mar 30, 2017

Uh oh!

vadimcn commented Mar 31, 2017

Uh oh!

bors commented Mar 31, 2017

Uh oh!

bors commented Mar 31, 2017

Uh oh!

bors commented Mar 31, 2017

Uh oh!

alexcrichton commented Mar 31, 2017 via email

Uh oh!

bors commented Apr 1, 2017

Uh oh!

bors commented Apr 1, 2017

Uh oh!

alexcrichton commented Apr 1, 2017 via email

Uh oh!

bors commented Apr 1, 2017

Uh oh!

tamirdMar 31, 2017

Choose a reason for hiding this comment

Uh oh!

bors commented Apr 1, 2017

Uh oh!

alexcrichton commented Apr 1, 2017

Uh oh!

bors commented Apr 2, 2017

Uh oh!

bors commented Apr 2, 2017

Uh oh!

vadimcn commented Apr 2, 2017

Uh oh!

TimNN commented Apr 2, 2017

Uh oh!

vadimcn commented Apr 2, 2017

Uh oh!

bors commented Apr 2, 2017

Uh oh!

bors commented Apr 2, 2017

Uh oh!

alexcrichton commented Apr 3, 2017 via email

Uh oh!

bors commented Apr 5, 2017

Uh oh!

bors commented Apr 5, 2017

Uh oh!

TimNN commented Apr 5, 2017

Uh oh!

bors commented Apr 6, 2017

Uh oh!

bors commented Apr 6, 2017

Uh oh!

alexcrichton commented May 5, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants