Skip to content

store a copy of the Issue32230 info within TypeError - #40836

Merged
bors merged 1 commit into
rust-lang:masterfrom
arielb1:issue-32330-copy
Mar 29, 2017
Merged

store a copy of the Issue32230 info within TypeError#40836
bors merged 1 commit into
rust-lang:masterfrom
arielb1:issue-32330-copy

Conversation

@arielb1

Copy link
Copy Markdown
Contributor

The data can't be looked up from the region variable directly, because
the region variable might have been destroyed at the end of a snapshot.

Fixes#40000.
Fixes#40743.

beta-nominating because regression.
r? @nikomatsakis

@arielb1arielb1 added beta-nominated Nominated for backporting to the compiler in the beta channel. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 26, 2017
The data can't be looked up from the region variable directly, because
the region variable might have been destroyed at the end of a snapshot.
Fixesrust-lang#40000.
Fixesrust-lang#40743.
@nikomatsakis

Copy link
Copy Markdown
Contributor

@bors r+ p=1

  • Giving high priority because of beta nomination.

@bors

bors commented Mar 27, 2017

Copy link
Copy Markdown
Collaborator

📌 Commit 7e0f7a5 has been approved by nikomatsakis

@nikomatsakisnikomatsakis added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Mar 27, 2017
@nikomatsakis

Copy link
Copy Markdown
Contributor

cc @rust-lang/compiler

Accepting for beta. Small patch, fixes regression (ICE).

@bors

bors commented Mar 29, 2017

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 7e0f7a5 with merge 1b0ecec...

@frewsxcvfrewsxcv mentioned this pull request Mar 29, 2017
@frewsxcv

Copy link
Copy Markdown
Contributor

retrying to prioritize rollup which includes this pr

@bors r-

@frewsxcv

Copy link
Copy Markdown
Contributor

welp, meant to retry

@bors r=nikomatsakis p=1

@bors

bors commented Mar 29, 2017

Copy link
Copy Markdown
Collaborator

📌 Commit 7e0f7a5 has been approved by nikomatsakis

@frewsxcv

Copy link
Copy Markdown
Contributor

@bors retry

@bors

bors commented Mar 29, 2017

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 7e0f7a5 with merge 10b1739...

bors added a commit that referenced this pull request Mar 29, 2017
store a copy of the Issue32230 info within TypeError
The data can't be looked up from the region variable directly, because
the region variable might have been destroyed at the end of a snapshot.
Fixes#40000.
Fixes#40743.
beta-nominating because regression.
r? @nikomatsakis
@bors

bors commented Mar 29, 2017

Copy link
Copy Markdown
Collaborator

☀️ Test successful - status-appveyor, status-travis
Approved by: nikomatsakis
Pushing 10b1739 to master...

@bors
bors merged commit 7e0f7a5 into rust-lang:masterMar 29, 2017
@alexcrichtonalexcrichton mentioned this pull request Apr 1, 2017
@alexcrichtonalexcrichton removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Apr 1, 2017
bors added a commit that referenced this pull request Apr 1, 2017
Backport PRs to beta
Backport of
* #40967
* #40836
* #40779
* #40888
Also includes a cargo submodule update
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

beta-acceptedAccepted for backporting to the compiler in the beta channel.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@arielb1@nikomatsakis@bors@frewsxcv@alexcrichton