Uh oh!
There was an error while loading. Please reload this page.
travis: Compile OSX releases with Xcode 7 - #40967
Merged
Merged
Conversation
rust-highfive
commented
Mar 31, 2017
Contributor
r? @aturon (rust_highfive has picked a reviewer for you, use r? to override) |
brson
commented
Mar 31, 2017
Contributor
Please add a comment to one of these explaining why we are pinned to xcode 7 for some builders. Other than that r=me. |
Unfortunately what we're using right now, Xcode 8.2, cannot compile LLVM for OSX 10.7. We've done this historically and Gecko would like to maintain this compabitiliby. This commit moves our release builders for OSX to using Xcode 7 which can compile LLVM for 10.7. The builders running tests continue to use Xcode 8.2, however, because the LLDB version with Xcode 7, 350, is blacklisted in running our LLDB tests. To continue running LLDB tests we'll stick with Xcode 8.2.
alexcrichton
commented
Mar 31, 2017
MemberAuthor
@bors: r=brson p=10 (beta nominated) |
bors
commented
Mar 31, 2017
Collaborator
📌 Commit 3076155 has been approved by |
bors
commented
Mar 31, 2017
Collaborator
bors
commented
Mar 31, 2017
Collaborator
💔 Test failed - status-travis |
TimNN
commented
Mar 31, 2017
Contributor
The failure is kinda strange, during deploy:
|
alexcrichton
commented
Apr 1, 2017
MemberAuthor
Ok in that case sounds spurious @bors: retry |
bors
commented
Apr 1, 2017
Collaborator
⌛ Testing commit 3076155 with merge 99c5e8b... |
bors
commented
Apr 1, 2017
Collaborator
💔 Test failed - status-appveyor |
alexcrichton
commented
Apr 1, 2017
via email
MemberAuthor
| … On Fri, Mar 31, 2017 at 9:50 PM, bors ***@***.***> wrote:
💔 Test failed - status-appveyor
<https://ci.appveyor.com/project/rust-lang/rust/build/1.0.2664>
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#40967 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAD95L-chg0q6W3JYYl1SUBoF6PKb3Tqks5rrcmegaJpZM4Mv-1h>
.
|
bors
commented
Apr 1, 2017
Collaborator
bors added a commit
that referenced
this pull request
Apr 1, 2017
travis: Compile OSX releases with Xcode 7 Unfortunately what we're using right now, Xcode 8.2, cannot compile LLVM for OSX 10.7. We've done this historically and Gecko would like to maintain this compabitiliby. This commit moves our release builders for OSX to using Xcode 7 which can compile LLVM for 10.7. The builders running tests continue to use Xcode 8.2, however, because the LLDB version with Xcode 7, 350, is blacklisted in running our LLDB tests. To continue running LLDB tests we'll stick with Xcode 8.2.
bors
commented
Apr 1, 2017
Collaborator
☀️ Test successful - status-appveyor, status-travis |
Merged
rillian
commented
Apr 3, 2017
Contributor
Thanks @alexcrichton! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unfortunately what we're using right now, Xcode 8.2, cannot compile LLVM for OSX
10.7. We've done this historically and Gecko would like to maintain this
compabitiliby. This commit moves our release builders for OSX to using Xcode 7
which can compile LLVM for 10.7.
The builders running tests continue to use Xcode 8.2, however, because the LLDB
version with Xcode 7, 350, is blacklisted in running our LLDB tests. To continue
running LLDB tests we'll stick with Xcode 8.2.