Uh oh!
There was an error while loading. Please reload this page.
Remove some CStr transmutes. - #41120
Merged
Merged
Conversation
rust-highfive
commented
Apr 6, 2017
Contributor
r? @BurntSushi (rust_highfive has picked a reviewer for you, use r? to override) |
BurntSushi
commented
Apr 6, 2017
Member
Nice! Thank you! The build failure looks related to this change, but it's weird that the rest of the builds passed. |
clarfontheyforce-pushed
the
c_str_transmute
branch
from
April 6, 2017 21:42
0db1225 to
9ffb545Compareclarfonthey
commented
Apr 7, 2017
ContributorAuthor
Fixed it! Should work now. |
alexcrichton
commented
Apr 7, 2017
Member
@bors: r+ |
bors
commented
Apr 7, 2017
Collaborator
📌 Commit 9ffb545 has been approved by |
frewsxcv added a commit
to frewsxcv/rust
that referenced
this pull request
Apr 7, 2017
…ichton Remove some CStr transmutes. Because dedicated methods exist for these, we don't have to add other transmutes.
bors added a commit
that referenced
this pull request
Apr 7, 2017
bors
commented
Apr 7, 2017
Collaborator
⌛ Testing commit 9ffb545 with merge 53f4bc3... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because dedicated methods exist for these, we don't have to add other transmutes.