Skip to content

travis: Use upstream LLVM repositories for Fuchsia - #41130

Merged
bors merged 1 commit into
rust-lang:masterfrom
petrhosek:fuchsia-ci-upstream
Apr 7, 2017
Merged

travis: Use upstream LLVM repositories for Fuchsia#41130
bors merged 1 commit into
rust-lang:masterfrom
petrhosek:fuchsia-ci-upstream

Conversation

@petrhosek

Copy link
Copy Markdown
Contributor

The Fuchsia copies of LLVM repositories contain additional patches
for work-in-progress features and there is some amount of churn that
may break Rust. Use upstream LLVM repositories instead for building
the toolchain used by the Fuchsia builder.

@rust-highfive

Copy link
Copy Markdown
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @aturon (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@petrhosek

Copy link
Copy Markdown
ContributorAuthor

@alexcrichton could you please take a look? I hope the patch step is just the temporary solution until D28791 is resolved.

@alexcrichton

Copy link
Copy Markdown
Member

@bors: r+

@bors

bors commented Apr 7, 2017

Copy link
Copy Markdown
Collaborator

📌 Commit b16101d has been approved by alexcrichton

@TimNN

TimNN commented Apr 7, 2017

Copy link
Copy Markdown
Contributor

@bors r-

  • Fails tidy (lines too long)

The best fix is probably to just mark the build-toolchain.sh file with # ignore-tidy-linelength.

The Fuchsia copies of LLVM repositories contain additional patches
for work-in-progress features and there is some amount of churn that
may break Rust. Use upstream LLVM repositories instead for building
the toolchain used by the Fuchsia builder.
@petrhosek
petrhosekforce-pushed the fuchsia-ci-upstream branch from b16101d to b135c12CompareApril 7, 2017 06:29
@petrhosek

Copy link
Copy Markdown
ContributorAuthor

Done.

@TimNN

TimNN commented Apr 7, 2017

Copy link
Copy Markdown
Contributor

@bors r=alexcrichton

@bors

bors commented Apr 7, 2017

Copy link
Copy Markdown
Collaborator

📌 Commit b135c12 has been approved by alexcrichton

frewsxcv added a commit to frewsxcv/rust that referenced this pull request Apr 7, 2017
…excrichton
travis: Use upstream LLVM repositories for Fuchsia
The Fuchsia copies of LLVM repositories contain additional patches
for work-in-progress features and there is some amount of churn that
may break Rust. Use upstream LLVM repositories instead for building
the toolchain used by the Fuchsia builder.
@frewsxcvfrewsxcv mentioned this pull request Apr 7, 2017
bors added a commit that referenced this pull request Apr 7, 2017
Rollup of 9 pull requests
- Successful merges: #40797, #41047, #41056, #41061, #41075, #41080, #41120, #41130, #41131
- Failed merges:
@bors
bors merged commit b135c12 into rust-lang:masterApr 7, 2017
@bors

bors commented Apr 7, 2017

Copy link
Copy Markdown
Collaborator

⌛ Testing commit b135c12 with merge 53f4bc3...

@alexcrichtonalexcrichton added beta-accepted Accepted for backporting to the compiler in the beta channel. beta-nominated Nominated for backporting to the compiler in the beta channel. labels Apr 19, 2017
@alexcrichtonalexcrichton removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Apr 19, 2017
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Apr 19, 2017
[beta] travis: Use upstream LLVM repositories for Fuchsia
This is a backport of rust-lang#41130 which...
Closesrust-lang#41396
@workingjubileeworkingjubilee added the O-fuchsia Operating system: Fuchsia label May 4, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

beta-acceptedAccepted for backporting to the compiler in the beta channel.O-fuchsiaOperating system: Fuchsia

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

@petrhosek@rust-highfive@alexcrichton@bors@TimNN@aturon@workingjubilee