Skip to content

document some existing unstable features - #41135

Merged
bors merged 2 commits into
rust-lang:masterfrom
japaric:unstable-docs
Apr 8, 2017
Merged

document some existing unstable features#41135
bors merged 2 commits into
rust-lang:masterfrom
japaric:unstable-docs

Conversation

@japaric

@japaricjaparic commented Apr 7, 2017

Copy link
Copy Markdown
Contributor

"msp430-interrupt", "ptx-kernel" and #![compiler_builtins_lib]

r? @steveklabnik

Jorge Aparicio
document some existing unstable features
f45c6d8
"msp430-interrupt", "ptx-kernel" and #![compiler_builtins_lib]
@rust-highfive

rust-highfive commented Apr 7, 2017

Copy link
Copy Markdown
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @steveklabnik (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

steveklabnik
steveklabnik suggested changes Apr 7, 2017
View reviewed changes

@steveklabniksteveklabnik left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one teeny tiny formatting nit, and then r=me. Thanks so much!

Comment threadsrc/doc/unstable-book/src/abi-ptx.md Outdated

The tracking issue for this feature is: None.
The tracking issue for this feature
is: [38788](https://github.com/rust-lang/rust/issues/38788)

@steveklabniksteveklabnikApr 7, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we have a standard form for this stuff, like this: https://github.com/rust-lang/rust/pull/41135/files#diff-d6ab7d3e772d67c4944af27d29e229cdR3

mind changing this to be identical? Thanks 😄

@japaricjaparicApr 7, 2017

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure thing. 😄

@japaric

japaric commented Apr 7, 2017

Copy link
Copy Markdown
ContributorAuthor

@bors r=steveklabnik

@bors

bors commented Apr 7, 2017

Copy link
Copy Markdown
Collaborator

📌 Commit 15fa301 has been approved by steveklabnik

@frewsxcvfrewsxcv added the A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools label Apr 7, 2017
@bors

bors commented Apr 7, 2017

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 15fa301 with merge bbe9ce9...

@TimNN

TimNN commented Apr 7, 2017

Copy link
Copy Markdown
Contributor

@bors retry

@bors

bors commented Apr 7, 2017

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 15fa301 with merge 5c1335e...

@bors

bors commented Apr 7, 2017

Copy link
Copy Markdown
Collaborator

💔 Test failed - status-appveyor

@TimNN

TimNN commented Apr 7, 2017

Copy link
Copy Markdown
Contributor

@bors retry

@bors

bors commented Apr 7, 2017

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 15fa301 with merge 4a15793...

@bors

bors commented Apr 7, 2017

Copy link
Copy Markdown
Collaborator

💔 Test failed - status-appveyor

@TimNN

TimNN commented Apr 7, 2017

Copy link
Copy Markdown
Contributor

@bors retry

frewsxcv added a commit to frewsxcv/rust that referenced this pull request Apr 7, 2017
@frewsxcv
Rollup merge ofrust-lang#41135- japaric:unstable-docs, r=steveklabnik
d8506a5
document some existing unstable features
"msp430-interrupt", "ptx-kernel" and #![compiler_builtins_lib]
r? @steveklabnik
@frewsxcvfrewsxcv mentioned this pull request Apr 7, 2017
Closed
bors added a commit that referenced this pull request Apr 8, 2017
@bors
Auto merge of#41150- frewsxcv:rollup, r=frewsxcv
9598a86
Rollup of 3 pull requests
- Successful merges: #41135, #41143, #41146
- Failed merges:
@bors

bors commented Apr 8, 2017

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 15fa301 with merge 99e663e...

@bors

bors commented Apr 8, 2017

Copy link
Copy Markdown
Collaborator

💔 Test failed - status-appveyor

@TimNN

TimNN commented Apr 8, 2017

Copy link
Copy Markdown
Contributor

@bors retry

TimNN added a commit to TimNN/rust that referenced this pull request Apr 8, 2017
@TimNN
Rollup merge ofrust-lang#41135- japaric:unstable-docs, r=steveklabnik
29880e6
document some existing unstable features
"msp430-interrupt", "ptx-kernel" and #![compiler_builtins_lib]
r? @steveklabnik
@TimNNTimNN mentioned this pull request Apr 8, 2017
Merged
bors added a commit that referenced this pull request Apr 8, 2017
@bors
Auto merge of#41156- TimNN:rollup, r=TimNN
3178d43
Rollup of 4 pull requests
- Successful merges: #41135, #41143, #41146, #41152
- Failed merges:
@bors
bors merged commit 15fa301 into rust-lang:masterApr 8, 2017
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@steveklabniksteveklabniksteveklabnik requested changes
Reviewers whose approvals may not affect merge requirements

Assignees

@steveklabniksteveklabnik

Labels

A-docsArea: Documentation for any part of the project, including the compiler, standard library, and tools

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@japaric@rust-highfive@bors@TimNN@steveklabnik@frewsxcv