Skip to content

Rollup of 3 pull requests - #41150

Closed
frewsxcv wants to merge 8 commits into
rust-lang:masterfrom
frewsxcv:rollup
Closed

Rollup of 3 pull requests#41150
frewsxcv wants to merge 8 commits into
rust-lang:masterfrom
frewsxcv:rollup

Conversation

@frewsxcv

Copy link
Copy Markdown
Contributor

Jorge Aparicioand others added 8 commits April 7, 2017 01:05
"msp430-interrupt", "ptx-kernel" and #![compiler_builtins_lib]
Gets shipped in 1.18 instead.
document some existing unstable features
"msp430-interrupt", "ptx-kernel" and #![compiler_builtins_lib]
r? @steveklabnik
…r=nagisa
Optimize AtomicBool::fetch_nand
This is an attempt to push the PR rust-lang#40563 to completion.
Benchmark: [source](https://gist.github.com/stjepang/023f5025623f5474184f9f4dfd6379ae)
Improvement:
```
name old_ ns/iter new_ce_ ns/iter diff ns/iter diff %
1t 146,440 89,904 -56,536 -38.61%
2t 561,456 316,835 -244,621 -43.57%
4t 2,822,821 1,005,424 -1,817,397 -64.38%
```
r? @eddyb
cc @alexcrichton@nagisa
pub(restricted) didn't make it into 1.17
Gets shipped in 1.18 instead.
@rust-highfive

Copy link
Copy Markdown
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @steveklabnik (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@frewsxcv

Copy link
Copy Markdown
ContributorAuthor

@bors r+ p=10

@bors

bors commented Apr 7, 2017

Copy link
Copy Markdown
Collaborator

📌 Commit 2ff857c has been approved by frewsxcv

@bors

bors commented Apr 8, 2017

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 2ff857c with merge 9598a86...

bors added a commit that referenced this pull request Apr 8, 2017
Rollup of 3 pull requests
- Successful merges: #41135, #41143, #41146
- Failed merges:
@bors

bors commented Apr 8, 2017

Copy link
Copy Markdown
Collaborator

💔 Test failed - status-appveyor

@TimNN

TimNN commented Apr 8, 2017

Copy link
Copy Markdown
Contributor

Supersede by #41156

@TimNNTimNN closed this Apr 8, 2017
@CentrilCentril added the rollup A PR which is a rollup label Oct 24, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

rollupA PR which is a rollup

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

@frewsxcv@rust-highfive@bors@TimNN@steveklabnik@Centril@est31