Add a comment for disabling errexit, try to debug appveyor cache by aidanhs · Pull Request #41157 · rust-lang/rust

aidanhs · 2017-04-08T07:49:05Z

Comments added as requested.

Also, lets add some cache debugging to appveyor. I think this is how to ignore errors in cmd.exe (and I did try it on my own machine), but I'm not 100% sure how appveyor runs them. In the worst case it'll fail but I guess that isn't the end of the world since the build has already failed by this point.

r? @TimNN

TimNN · 2017-04-08T18:46:59Z

s/well/tell/

TimNN · 2017-04-08T18:48:12Z

Is this cat even useful here? Since the build itself may succeed, it's probably rarely execute.

To be honest I'm relying on the ar.exe errors to let me read this log (if it rarely executes because the ar.exe errors vanish, I wouldn't see that as the end of the world!). I'll probably remove it again once it's all fixed.

In fact, I'll move it elsewhere and then we can just try it rather than merging.

aidanhs · 2017-04-08T21:39:32Z

@TimNN ok, think this is ready for a try (not an r+!) and should be pretty quick to run.

TimNN · 2017-04-09T08:23:10Z

Unfortunately try doesn't work for rust-lang/rust :(

Could you just add an exit 1 or something to the appveyor script?

aidanhs · 2017-04-09T23:08:53Z

@TimNN pushed a deliberate error to both travis and appveyor so this doesn't consume too much CPU time. I assume it's possible to r+ even if the travis PR test has failed?

TimNN · 2017-04-10T05:29:25Z

@bors r+

Lets see how this goes.

bors · 2017-04-10T05:29:26Z

📌 Commit c26c259 has been approved by TimNN

bors · 2017-04-10T06:59:39Z

⌛ Testing commit c26c259 with merge 37aa503...

bors · 2017-04-10T07:03:15Z

💔 Test failed - status-appveyor

TimNN · 2017-04-10T07:05:02Z

@bors r-

cat C:\Users\appveyor\AppData\Local\Temp\1\build-cache-logs\*.log
*.log: 'C:\Users\appveyor\AppData\Local\Temp\1\build-cache-logs\*.log': No such file or directory

aidanhs · 2017-04-10T11:05:29Z

Oh the joys of globs in cmd.exe. I've now wrapped it in bash instead.

TimNN · 2017-04-10T11:33:15Z

@bors r+

bors · 2017-04-10T11:33:16Z

📌 Commit 2b0652c has been approved by TimNN

bors · 2017-04-10T12:29:32Z

⌛ Testing commit 2b0652c with merge 1e1071e...

bors · 2017-04-10T12:33:37Z

💔 Test failed - status-appveyor

aidanhs · 2017-04-10T12:35:31Z

sh -c "cat /c/Users/appveyor/AppData/Local/Temp/1/build-cache-logs/*.log"
7-Zip [64] 16.04 : Copyright (c) 1999-2016 Igor Pavlov : 2016-10-04
Scanning the drive for archives:
1 file, 382926848 bytes (366 MiB)
Extracting archive: C:\Users\appveyor\AppData\Local\Temp\1\zqpkxdjw.sh4\611919de52bbda249e7468a0750b9e479f441c99.zip.001
--
Path = C:\Users\appveyor\AppData\Local\Temp\1\zqpkxdjw.sh4\611919de52bbda249e7468a0750b9e479f441c99.zip.001
Type = Split
Physical Size = 382926848
Volumes = 1
Total Physical Size = 382926848
----
Path = 611919de52bbda249e7468a0750b9e479f441c99.zip
Size = 382926848
--
Path = 611919de52bbda249e7468a0750b9e479f441c99.zip
Type = zip
ERRORS:
Unexpected end of archive
Physical Size = 647658498
Sub items Errors: 1
Archives with Errors: 1
Open Errors: 1
Sub items Errors: 1
611919de52bbda249e7468a0750b9e479f441c99.zip
ERRORS:
Unexpected end of archive
ERROR: Data Error : rustsrc\src\.git\modules\src\llvm\objects\pack\pack-318fb7026aaf070bb3b02502225d3fb47679a2e7.pack

Well that's disturbing. Maybe I'd better ask the appveyor people about this.

aidanhs · 2017-04-14T14:32:51Z

@TimNN I've done my debugging, so for now I've updated this PR with the comment and a removal of a useless cat (since the glob doesn't apply). The || exit 0 has been added as a hint for future contributors so that they will actually be able to see their own on-failure command, rather than it bailing out if there are no sccache logs.

TimNN · 2017-04-16T13:29:36Z

@bors r+ rollup

bors · 2017-04-16T13:29:37Z

📌 Commit bb84358 has been approved by TimNN

@TimNN

…r=TimNN Add a comment for disabling errexit, try to debug appveyor cache Comments added as requested. Also, lets add some cache debugging to appveyor. I *think* this is how to ignore errors in cmd.exe (and I did try it on my own machine), but I'm not 100% sure how appveyor runs them. In the worst case it'll fail but I guess that isn't the end of the world since the build has already failed by this point. r? @TimNN

bors · 2017-04-16T22:24:41Z

⌛ Testing commit bb84358 with merge 5997806...

@TimNN

Add a comment for disabling errexit, try to debug appveyor cache Comments added as requested. Also, lets add some cache debugging to appveyor. I *think* this is how to ignore errors in cmd.exe (and I did try it on my own machine), but I'm not 100% sure how appveyor runs them. In the worst case it'll fail but I guess that isn't the end of the world since the build has already failed by this point. r? @TimNN

bors · 2017-04-17T01:00:47Z

☀️ Test successful - status-appveyor, status-travis
Approved by: TimNN
Pushing 5997806 to master...

rust-highfive assigned TimNN Apr 8, 2017

aidanhs changed the title ~~Add an comment for disabling errexit, try to debug appveyor cache~~Add a comment for disabling errexit, try to debug appveyor cacheApr 8, 2017

TimNN reviewed Apr 8, 2017
View reviewed changes

Comment threadsrc/ci/init_repo.sh Outdated
TimNNApr 8, 2017
Copy link
Copy Markdown
Contributor
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/well/tell/

TimNN reviewed Apr 8, 2017
View reviewed changes

aidanhs force-pushed the aphs-debug-appveyor-cache branch 2 times, most recently from 40c2bb2 to 66ccc6fCompare April 8, 2017 21:38

aidanhs force-pushed the aphs-debug-appveyor-cache branch 2 times, most recently from 1dce93d to c26c259Compare April 9, 2017 23:04

aidanhs force-pushed the aphs-debug-appveyor-cache branch from c26c259 to 2b0652cCompare April 10, 2017 10:49

aidanhs mentioned this pull request Apr 10, 2017
Investigate caching .git data on Travis/AppVeyor #40772
Closed

Add a comment for disabling errexit
bb84358

aidanhs force-pushed the aphs-debug-appveyor-cache branch from 2b0652c to bb84358Compare April 14, 2017 14:30

shepmaster added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 14, 2017

TimNN added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 16, 2017

frewsxcv mentioned this pull request Apr 16, 2017
Rollup of 2 pull requests #41330
Closed

bors merged commit bb84358 into rust-lang:masterApr 17, 2017

Uh oh!

Uh oh!

Conversation

aidanhs commented Apr 8, 2017

Uh oh!

TimNNApr 8, 2017

Choose a reason for hiding this comment

Uh oh!

TimNNApr 8, 2017• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

aidanhsApr 8, 2017

Choose a reason for hiding this comment

Uh oh!

aidanhsApr 8, 2017

Choose a reason for hiding this comment

Uh oh!

aidanhs commented Apr 8, 2017

Uh oh!

TimNN commented Apr 9, 2017

Uh oh!

aidanhs commented Apr 9, 2017

Uh oh!

TimNN commented Apr 10, 2017

Uh oh!

bors commented Apr 10, 2017

Uh oh!

bors commented Apr 10, 2017

Uh oh!

bors commented Apr 10, 2017

Uh oh!

TimNN commented Apr 10, 2017

Uh oh!

aidanhs commented Apr 10, 2017

Uh oh!

TimNN commented Apr 10, 2017

Uh oh!

bors commented Apr 10, 2017

Uh oh!

bors commented Apr 10, 2017

Uh oh!

bors commented Apr 10, 2017

Uh oh!

aidanhs commented Apr 10, 2017

Uh oh!

aidanhs commented Apr 14, 2017

Uh oh!

TimNN commented Apr 16, 2017

Uh oh!

bors commented Apr 16, 2017

Uh oh!

bors commented Apr 16, 2017

Uh oh!

bors commented Apr 17, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

TimNNApr 8, 2017•
edited
Loading