Uh oh!
There was an error while loading. Please reload this page.
Rollup of 2 pull requests - #41330
Conversation
frewsxcv
commented
Apr 16, 2017
- Successful merges: Specialize Vec::from_elem to use calloc #40409, Add a comment for disabling errexit, try to debug appveyor cache #41157
- Failed merges:
Specialize Vec::from_elem to use calloc Fixesrust-lang#38723. This specializes the implementation for `u8` only, but it could be extended to other zeroable types if desired. I haven't tested this extensively, but I did verify that it gives the expected performance boost for large `vec![0; n]` allocations with both alloc_system and jemalloc, on Linux. (I have not tested or even built the Windows code.)
…r=TimNN Add a comment for disabling errexit, try to debug appveyor cache Comments added as requested. Also, lets add some cache debugging to appveyor. I *think* this is how to ignore errors in cmd.exe (and I did try it on my own machine), but I'm not 100% sure how appveyor runs them. In the worst case it'll fail but I guess that isn't the end of the world since the build has already failed by this point. r? @TimNN
frewsxcv
commented
Apr 16, 2017
@bors r+ p=10 |
bors
commented
Apr 16, 2017
📌 Commit c929359 has been approved by |
rust-highfive
commented
Apr 16, 2017
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
bors
commented
Apr 16, 2017
⌛ Testing commit c929359 with merge 9f7d2d9... |
bors
commented
Apr 16, 2017
💔 Test failed - status-appveyor |