Uh oh!
There was an error while loading. Please reload this page.
COPYRIGHT: remove hoedown license - #41183
Merged
Merged
Conversation
rust-highfive
commented
Apr 10, 2017
Contributor
r? @aturon (rust_highfive has picked a reviewer for you, use r? to override) |
steveklabnik
commented
Apr 10, 2017
Contributor
Removing the hoedown stuff makes sense to me. @alexcrichton I am 99% sure these tidy changes do to, but wdyt? |
alexcrichton
commented
Apr 10, 2017
Member
@bors: r+ |
bors
commented
Apr 10, 2017
Collaborator
📌 Commit bfb9e01 has been approved by |
bors
commented
Apr 11, 2017
Collaborator
⌛ Testing commit bfb9e01 with merge dfb5d77... |
bors
commented
Apr 11, 2017
Collaborator
💔 Test failed - status-travis |
TimNN
reviewed
Apr 11, 2017
Contributor
There was a problem hiding this comment.
The removal of this line causes tidy errors during dist-check.
ContributorAuthor
There was a problem hiding this comment.
In fact several issues are preventing me from completing x.py test distcheck locally... Just blindly reverted the last line
Hoedown was removed in b96fef8 Also cleanup src/tools/tidy/src/main.rs Signed-off-by: NODA, Kai <nodakai@gmail.com>
nodakaiforce-pushed
the
remove-hoedown-license
branch
from
April 12, 2017 04:55
bfb9e01 to
f391451CompareTimNN
commented
Apr 12, 2017
Contributor
@bors r+ |
bors
commented
Apr 12, 2017
Collaborator
📌 Commit f391451 has been approved by |
TimNN added a commit
to TimNN/rust
that referenced
this pull request
Apr 12, 2017
…imNN COPYRIGHT: remove hoedown license Hoedown was removed in b96fef8 Also cleanup src/tools/tidy/src/main.rs
bors added a commit
that referenced
this pull request
Apr 12, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hoedown was removed in b96fef8
Also cleanup src/tools/tidy/src/main.rs