Uh oh!
There was an error while loading. Please reload this page.
move rvalue checking to MIR - #41232
Merged
Merged
Conversation
arielb1
commented
Apr 11, 2017
ContributorAuthor
r? @eddyb |
rust-highfive
commented
Apr 11, 2017
Contributor
(rust_highfive has picked a reviewer for you, use r? to override) |
eddyb
approved these changes
Apr 11, 2017
eddyb
left a comment
Contributor
There was a problem hiding this comment.
r=me, with some clarifications.
| let span = local_decl.source_info.span; | ||
| let ty = local_decl.ty; | ||
| if !ty.is_sized(self.tcx().global_tcx(), self.infcx.param_env(), span) { | ||
| if let None = self.reported_errors.replace((ty, span)) { |
Contributor
There was a problem hiding this comment.
replace confuses me - insert wouldn't work?
| for (local, local_decl) in mir.local_decls.iter_enumerated() { | ||
| self.check_local(mir, local, local_decl); | ||
| } |
Contributor
There was a problem hiding this comment.
Wait, can't there be assignments between, say, two dereferences? Is there any guarantee there would be a Local? If so, a comment would be helpful.
arielb1
commented
Apr 11, 2017
ContributorAuthor
@bors r=eddyb |
bors
commented
Apr 11, 2017
Collaborator
📌 Commit 540a069 has been approved by |
TimNN added a commit
to TimNN/rust
that referenced
this pull request
Apr 12, 2017
move rvalue checking to MIR
bors added a commit
that referenced
this pull request
Apr 12, 2017
nikomatsakis
commented
Apr 13, 2017
Contributor
@arielb1 nice to see things moving to MIR :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.