Spin loop pause function redux by mstewartgallus · Pull Request #41207 · rust-lang/rust

mstewartgallus · 2017-04-10T22:29:04Z

GitHub's interface is screwy.

This is the same PR as #40537

rust-highfive · 2017-04-10T22:29:16Z

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @BurntSushi (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

BurntSushi · 2017-04-11T11:43:03Z

@alexcrichton What do you think? I saw you raised some concerns here, but I think they've been addressed in this PR.

alexcrichton · 2017-04-11T14:04:24Z

Yes the docs seems reasonable, although I'm not a huge fan of the name hint_core_should_pause. I don't have many suggestions, though. Is there precedent in, say, C++ for this?

mstewartgallus · 2017-04-12T00:45:32Z

@alexcrichton There is no precedent in C or C++ but there is in Java see http://openjdk.java.net/jeps/285 .

alexcrichton · 2017-04-12T19:38:48Z

Thanks for the pointer! Looks like Java called this java.lang.Thread.onSpinWait (FWIW)

Not sure if that means much for us...

clarfonthey · 2017-04-14T19:12:25Z

The spin crate calls this function cpu_relax; maybe we should do something similar?

arielb1 · 2017-04-18T08:23:34Z

r? @alexcrichton

@alexcrichton is on vacation, so he might not look on your PR until next week.

bors · 2017-04-20T04:43:06Z

☔ The latest upstream changes (presumably #41411) made this pull request unmergeable. Please resolve the merge conflicts.

alexcrichton · 2017-04-20T14:18:15Z

Ok this seems like a reasonable API to me to have in libstd, and we've probably had enough bikeshedding at this point! The name seems totally reasonable to me in terms of it's still unstable and we'll have a final pass before stabilizing regardless.

@sstewartgallus if you'd like to rebase I'll r+!

bors · 2017-04-23T04:37:35Z

☔ The latest upstream changes (presumably #41437) made this pull request unmergeable. Please resolve the merge conflicts.

alexcrichton · 2017-04-24T16:41:50Z

Ah sorry looks like I miseed that rebase before bors caught it, wanna try again?

alexcrichton · 2017-05-01T18:00:23Z

@sstewartgallus looks like tidy is failing, and mind squashing this into one commit?

mzji · 2017-05-01T20:09:28Z

This file should be moved to library-features directory.

mzji · 2017-05-01T20:10:15Z

There isn't zero_one feature anymore, is this a typo?

mzji · 2017-05-01T20:11:21Z

Please change the link to point to library-features/hint-core-should-pause.md .

alexcrichton · 2017-05-02T14:53:04Z

@bors: r+

bors · 2017-05-02T14:53:05Z

📌 Commit f4fe3cd has been approved by alexcrichton

bors · 2017-05-02T17:48:34Z

⌛ Testing commit f4fe3cd with merge 6a5fc9e...

Spin loop pause function redux GitHub's interface is screwy. This is the same PR as #40537

bors · 2017-05-02T20:43:58Z

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing 6a5fc9e to master...

rust-highfive assigned BurntSushi Apr 10, 2017

BurntSushi added the T-libs-api [DEPRECATED; DO NOT USE] label Apr 11, 2017

Mark-Simulacrum added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Apr 14, 2017

arielb1 added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 18, 2017

arielb1 assigned alexcrichton and unassigned BurntSushi Apr 18, 2017

alexcrichton added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 20, 2017

mzji reviewed May 1, 2017
View reviewed changes

Comment threadsrc/doc/unstable-book/src/SUMMARY.md Outdated
mzjiMay 1, 2017
Copy link
Copy Markdown
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There isn't zero_one feature anymore, is this a typo?

mzji reviewed May 1, 2017
View reviewed changes

Added spin loop pause function
f4fe3cd

mstewartgallus force-pushed the spinpause branch from fec99b9 to f4fe3cdCompare May 2, 2017 00:12

bors added a commit that referenced this pull request May 2, 2017
Auto merge of#41207- sstewartgallus:spinpause, r=alexcrichton
6a5fc9e
Spin loop pause function redux GitHub's interface is screwy. This is the same PR as #40537

bors merged commit f4fe3cd into rust-lang:masterMay 2, 2017

clarfonthey mentioned this pull request May 2, 2017
Tracking issue for PR 40537 (hint_core_should_pause) #41196
Closed

mstewartgallus deleted the spinpause branch May 2, 2017 21:45

dtolnay mentioned this pull request Nov 8, 2017
RFC: Add Option::filter to the standard library rust-lang/rfcs#2124
Merged

Uh oh!

Uh oh!

Conversation

mstewartgallus commented Apr 10, 2017

Uh oh!

rust-highfive commented Apr 10, 2017

Uh oh!

BurntSushi commented Apr 11, 2017

Uh oh!

alexcrichton commented Apr 11, 2017

Uh oh!

mstewartgallus commented Apr 12, 2017

Uh oh!

alexcrichton commented Apr 12, 2017

Uh oh!

clarfonthey commented Apr 14, 2017

Uh oh!

arielb1 commented Apr 18, 2017• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bors commented Apr 20, 2017

Uh oh!

alexcrichton commented Apr 20, 2017

Uh oh!

bors commented Apr 23, 2017

Uh oh!

alexcrichton commented Apr 24, 2017

Uh oh!

alexcrichton commented May 1, 2017

Uh oh!

mzjiMay 1, 2017• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mzjiMay 1, 2017

Choose a reason for hiding this comment

Uh oh!

mzjiMay 1, 2017• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

alexcrichton commented May 2, 2017

Uh oh!

bors commented May 2, 2017

Uh oh!

bors commented May 2, 2017

Uh oh!

bors commented May 2, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

arielb1 commented Apr 18, 2017•
edited
Loading

mzjiMay 1, 2017•
edited
Loading

mzjiMay 1, 2017•
edited
Loading