Remove items that are unstable and deprecated by cuviper · Pull Request #41437 · rust-lang/rust

cuviper · 2017-04-21T01:27:59Z

This removes unstable items that have been deprecated for more than one cycle.

Since 1.16.0, #![feature(enumset)]
- All of mod collections::enum_set
Since 1.15.0, #![feature(borrow_state)]
- cell::BorrowState
- RefCell::borrow_state()
Since 1.15.0, #![feature(is_unique)]
- Rc::is_unique() (made private like Arc::is_unique())
Since 1.15.0, #![feature(rc_would_unwrap)]
- Rc::would_wrap()
Since 1.13.0, #![feature(binary_heap_extras)]
- BinaryHeap::push_pop()
- BinaryHeap::replace()
Since 1.12.0, #![feature(as_unsafe_cell)]
- Cell::as_unsafe_cell()
- RefCell::as_unsafe_cell()
Since 1.12.0, #![feature(map_entry_recover_keys)]
- btree_map::OccupiedEntry::remove_pair()
- hash_map::OccupiedEntry::remove_pair()
Since 1.11.0, #![feature(float_extras)]
- Float::nan()
- Float::infinity()
- Float::neg_infinity()
- Float::neg_zero()
- Float::zero()
- Float::one()
- Float::integer_decode()
- f32::integer_decode()
- f32::ldexp()
- f32::frexp()
- f32::next_after()
- f64::integer_decode()
- f64::ldexp()
- f64::frexp()
- f64::next_after()
Since 1.11.0, #![feature(zero_one)]
- num::Zero
- num::One

rust-highfive · 2017-04-21T01:28:14Z

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

cuviper · 2017-04-21T01:34:37Z

Things I didn't include (yet):

core::hash::SipHasher13
- used in std::collections::hash_map::DefaultHasher
- should move it across crates, properly hidden in DefaultHasher?
core::hash::SipHasher24
- used in the stable+deprecated core::hash::SipHasher
- could just make it private, only used in SipHasher
rustc_plugin::Registry::register_custom_derive()
- the function alone is easy enough to remove, but there's probably a lot of supporting code that could go away with it, which I haven't explored yet.

bors · 2017-04-21T03:53:50Z

☔ The latest upstream changes (presumably #41342) made this pull request unmergeable. Please resolve the merge conflicts.

[unstable, deprecated since 1.16.0]

[unstable, deprecated since 1.13.0]

[unstable, deprecated since 1.12.0]

[unstable, deprecated since 1.15.0]

[unstable, deprecated since 1.12.0]

[unstable, deprecated since 1.15.0]

[unstable, deprecated since 1.11.0]

cuviper · 2017-04-21T04:18:18Z

Rebased.

hanna-kruppe · 2017-04-21T06:49:00Z

+ i8::min_value() / -i8::one(),
+ i16::min_value() / -i16::one(),
+ i32::min_value() / -i32::one(),
+ i64::min_value() / -i64::one(),


Why start using one here?

Ah. Because I needed a local zero implemention anyway, so adding one is easy and gets rid of the compile-time warning that this is going to overflow. We could also go the other direction and use plain literals for all, which will then warn on every line. Or we could leave it as-is with zero() and -1, but the inconsistency bothered me. 😀
I don't think it matters to the actual test.

alexcrichton · 2017-04-21T13:53:17Z

@bors: r+

Looks great to me, thanks @cuviper!

bors · 2017-04-21T13:53:18Z

📌 Commit c1aaa60 has been approved by alexcrichton

… r=alexcrichton Remove items that are unstable and deprecated This removes unstable items that have been deprecated for more than one cycle. - Since 1.16.0, `#![feature(enumset)]` - All of `mod collections::enum_set` - Since 1.15.0, `#![feature(borrow_state)]` - `cell::BorrowState` - `RefCell::borrow_state()` - Since 1.15.0, `#![feature(is_unique)]` - `Rc::is_unique()` (made private like `Arc::is_unique()`) - Since 1.15.0, `#![feature(rc_would_unwrap)]` - `Rc::would_wrap()` - Since 1.13.0, `#![feature(binary_heap_extras)]` - `BinaryHeap::push_pop()` - `BinaryHeap::replace()` - Since 1.12.0, `#![feature(as_unsafe_cell)]` - `Cell::as_unsafe_cell()` - `RefCell::as_unsafe_cell()` - Since 1.12.0, `#![feature(map_entry_recover_keys)]` - `btree_map::OccupiedEntry::remove_pair()` - `hash_map::OccupiedEntry::remove_pair()` - Since 1.11.0, `#![feature(float_extras)]` - `Float::nan()` - `Float::infinity()` - `Float::neg_infinity()` - `Float::neg_zero()` - `Float::zero()` - `Float::one()` - `Float::integer_decode()` - `f32::integer_decode()` - `f32::ldexp()` - `f32::frexp()` - `f32::next_after()` - `f64::integer_decode()` - `f64::ldexp()` - `f64::frexp()` - `f64::next_after()` - Since 1.11.0, `#![feature(zero_one)]` - `num::Zero` - `num::One`

frewsxcv · 2017-04-22T03:28:45Z

Appveyor caught an unused import

https://ci.appveyor.com/project/rust-lang/rust/build/1.0.3016/job/m7i7x867j8xr04i1

@bors r-

cuviper · 2017-04-22T04:04:35Z

Argh, OK. It's going to be a couple days before I can get back to this, unless a maintainer wants to push to my branch. There's no urgency here though.

frewsxcv · 2017-04-23T02:13:50Z

@bors r=alexcrichton

bors · 2017-04-23T02:13:51Z

📌 Commit 13d2534 has been approved by alexcrichton

bors · 2017-04-23T02:14:01Z

⌛ Testing commit 13d2534 with merge a941244...

…hton Remove items that are unstable and deprecated This removes unstable items that have been deprecated for more than one cycle. - Since 1.16.0, `#![feature(enumset)]` - All of `mod collections::enum_set` - Since 1.15.0, `#![feature(borrow_state)]` - `cell::BorrowState` - `RefCell::borrow_state()` - Since 1.15.0, `#![feature(is_unique)]` - `Rc::is_unique()` (made private like `Arc::is_unique()`) - Since 1.15.0, `#![feature(rc_would_unwrap)]` - `Rc::would_wrap()` - Since 1.13.0, `#![feature(binary_heap_extras)]` - `BinaryHeap::push_pop()` - `BinaryHeap::replace()` - Since 1.12.0, `#![feature(as_unsafe_cell)]` - `Cell::as_unsafe_cell()` - `RefCell::as_unsafe_cell()` - Since 1.12.0, `#![feature(map_entry_recover_keys)]` - `btree_map::OccupiedEntry::remove_pair()` - `hash_map::OccupiedEntry::remove_pair()` - Since 1.11.0, `#![feature(float_extras)]` - `Float::nan()` - `Float::infinity()` - `Float::neg_infinity()` - `Float::neg_zero()` - `Float::zero()` - `Float::one()` - `Float::integer_decode()` - `f32::integer_decode()` - `f32::ldexp()` - `f32::frexp()` - `f32::next_after()` - `f64::integer_decode()` - `f64::ldexp()` - `f64::frexp()` - `f64::next_after()` - Since 1.11.0, `#![feature(zero_one)]` - `num::Zero` - `num::One`

bors · 2017-04-23T04:33:45Z

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing a941244 to master...

cuviper · 2017-04-23T04:52:15Z

Thanks for the fixup @frewsxcv!

rust-lang/rust#41437

rust-lang/rust#41437 Backport of serde-rs#898 to 0.9.x

rust-lang/rust#41437

rust-highfive assigned alexcrichton Apr 21, 2017

cuviper added 9 commits April 20, 2017 21:16

Remove EnumSet
a76274e
[unstable, deprecated since 1.16.0]

Remove BinaryHeap::{push_pop,replace}
a724ff9
[unstable, deprecated since 1.13.0]

Remove OccupiedEntry::remove_pair
df86cec
[unstable, deprecated since 1.12.0]

Remove Rc::would_wrap
f4aaae9
[unstable, deprecated since 1.15.0]

Privatize Rc::is_unique
f0c5e8b
[unstable, deprecated since 1.15.0]

Remove {Cell,RefCell}::as_unsafe_cell
cc605c8
[unstable, deprecated since 1.12.0]

Remove RefCell::borrow_state
313aab8
[unstable, deprecated since 1.15.0]

Remove num::{Zero,One}
c903ac6
[unstable, deprecated since 1.11.0]

Remove float_extras
c1aaa60
[unstable, deprecated since 1.11.0]

cuviper force-pushed the remove-unstable-deprecated branch from 37a785a to c1aaa60Compare April 21, 2017 04:18

hanna-kruppe reviewed Apr 21, 2017
View reviewed changes

alexcrichton added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Apr 21, 2017

frewsxcv mentioned this pull request Apr 21, 2017
Rollup of 4 pull requests #41451
Closed

frewsxcv mentioned this pull request Apr 22, 2017
Rollup of 5 pull requests #41455
Closed

frewsxcv mentioned this pull request Apr 22, 2017
Rollup of 5 pull requests #41458
Closed

Mark-Simulacrum added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Apr 23, 2017

Mark-Simulacrum removed the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Apr 23, 2017

Remove unused import.
13d2534

bors merged commit 13d2534 into rust-lang:masterApr 23, 2017

SimonSapin added a commit to SimonSapin/serde that referenced this pull request Apr 23, 2017
Remove usage of unstable core::num::Zero, which was removed upstream.
bc95236
rust-lang/rust#41437

SimonSapin mentioned this pull request Apr 23, 2017
Remove usage of unstable core::num::Zero, which was removed upstream. serde-rs/serde#898
Merged

SimonSapin added a commit to SimonSapin/serde that referenced this pull request Apr 23, 2017
Remove usage of unstable core::num::Zero, which was removed upstream.
1d6ecf3
rust-lang/rust#41437 Backport of serde-rs#898 to 0.9.x

SimonSapin mentioned this pull request Apr 23, 2017
Remove usage of unstable core::num::Zero, which was removed upstream. serde-rs/serde#899
Merged

SimonSapin added a commit to SimonSapin/serde that referenced this pull request Apr 23, 2017
Remove usage of unstable core::num::Zero, which was removed upstream.
6fbf40b
rust-lang/rust#41437

tbu- mentioned this pull request May 4, 2017
Fall back to fcntl if ioctl(FIOCLEX, ..) is unsupported #41462
Closed

cuviper deleted the remove-unstable-deprecated branch September 26, 2017 06:39

Uh oh!

Uh oh!

Conversation

cuviper commented Apr 21, 2017

Uh oh!

rust-highfive commented Apr 21, 2017

Uh oh!

cuviper commented Apr 21, 2017

Uh oh!

bors commented Apr 21, 2017

Uh oh!

cuviper commented Apr 21, 2017

Uh oh!

hanna-kruppeApr 21, 2017

Choose a reason for hiding this comment

Uh oh!

cuviperApr 21, 2017

Choose a reason for hiding this comment

Uh oh!

alexcrichton commented Apr 21, 2017

Uh oh!

bors commented Apr 21, 2017

Uh oh!

frewsxcv commented Apr 22, 2017

Uh oh!

cuviper commented Apr 22, 2017

Uh oh!

frewsxcv commented Apr 23, 2017

Uh oh!

bors commented Apr 23, 2017

Uh oh!

bors commented Apr 23, 2017

Uh oh!

bors commented Apr 23, 2017

Uh oh!

cuviper commented Apr 23, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants