Uh oh!
There was an error while loading. Please reload this page.
rustbuild: Fix recompilation of stage0 tools dir - #41227
Merged
Merged
Conversation
rust-highfive
commented
Apr 11, 2017
Contributor
r? @aturon (rust_highfive has picked a reviewer for you, use r? to override) |
aturon
commented
Apr 12, 2017
Contributor
@bors: r+ |
bors
commented
Apr 12, 2017
Collaborator
📌 Commit d1298c8 has been approved by |
bors
commented
Apr 13, 2017
Collaborator
⌛ Testing commit d1298c8 with merge 1c4a98c... |
bors
commented
Apr 13, 2017
Collaborator
💔 Test failed - status-travis |
TimNN
commented
Apr 13, 2017
Contributor
|
This commit knocks out a longstanding FIXME in rustbuild which should correctly recompile stage0 compiletest and such whenever libstd itself changes. The solution implemented here was to implement a notion of "order only" dependencies and then add a new dependency stage for clearing out the tools dir, using order-only deps to ensure that it happens correctly. The dependency drawing for tools is a bit wonky now but I think this'll get the job done. Closesrust-lang#39396
alexcrichton
commented
Apr 13, 2017
MemberAuthor
@bors: r=aturon |
bors
commented
Apr 13, 2017
Collaborator
📌 Commit 2a33559 has been approved by |
frewsxcv added a commit
to frewsxcv/rust
that referenced
this pull request
Apr 13, 2017
rustbuild: Fix recompilation of stage0 tools dir This commit knocks out a longstanding FIXME in rustbuild which should correctly recompile stage0 compiletest and such whenever libstd itself changes. The solution implemented here was to implement a notion of "order only" dependencies and then add a new dependency stage for clearing out the tools dir, using order-only deps to ensure that it happens correctly. The dependency drawing for tools is a bit wonky now but I think this'll get the job done. Closesrust-lang#39396
bors
commented
Apr 13, 2017
Collaborator
bors added a commit
that referenced
this pull request
Apr 13, 2017
rustbuild: Fix recompilation of stage0 tools dir This commit knocks out a longstanding FIXME in rustbuild which should correctly recompile stage0 compiletest and such whenever libstd itself changes. The solution implemented here was to implement a notion of "order only" dependencies and then add a new dependency stage for clearing out the tools dir, using order-only deps to ensure that it happens correctly. The dependency drawing for tools is a bit wonky now but I think this'll get the job done. Closes#39396
bors
commented
Apr 13, 2017
Collaborator
☀️ Test successful - status-appveyor, status-travis |
bors added a commit
that referenced
this pull request
Apr 16, 2017
[rustbuild] Side-step HashMap iteration to preserve command-line step order. The new `HashMap` was introduced by #41227 and it accidentally randomized step order. r? @alexcrichton
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit knocks out a longstanding FIXME in rustbuild which should correctly
recompile stage0 compiletest and such whenever libstd itself changes. The
solution implemented here was to implement a notion of "order only" dependencies
and then add a new dependency stage for clearing out the tools dir, using
order-only deps to ensure that it happens correctly.
The dependency drawing for tools is a bit wonky now but I think this'll get the
job done.
Closes#39396