Skip to content

[rustbuild] Side-step HashMap iteration to preserve command-line step order. - #41308

Merged
bors merged 1 commit into
rust-lang:masterfrom
eddyb:order-must-be-preserved
Apr 16, 2017
Merged

[rustbuild] Side-step HashMap iteration to preserve command-line step order.#41308
bors merged 1 commit into
rust-lang:masterfrom
eddyb:order-must-be-preserved

Conversation

@eddyb

Copy link
Copy Markdown
Contributor

The new HashMap was introduced by #41227 and it accidentally randomized step order.

r? @alexcrichton

@eddyb
eddyb requested a review from alexcrichtonApril 15, 2017 00:36
@arielb1arielb1 added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 15, 2017
@nagisa

Copy link
Copy Markdown
Member

@bors r+

@bors

bors commented Apr 16, 2017

Copy link
Copy Markdown
Collaborator

🔑 Insufficient privileges

@eddyb

Copy link
Copy Markdown
ContributorAuthor

@bors r=nagisa

@bors

bors commented Apr 16, 2017

Copy link
Copy Markdown
Collaborator

📌 Commit c597994 has been approved by nagisa

@bors

bors commented Apr 16, 2017

Copy link
Copy Markdown
Collaborator

⌛ Testing commit c597994 with merge fef1026...

bors added a commit that referenced this pull request Apr 16, 2017
[rustbuild] Side-step HashMap iteration to preserve command-line step order.
The new `HashMap` was introduced by #41227 and it accidentally randomized step order.
r? @alexcrichton
@bors

bors commented Apr 16, 2017

Copy link
Copy Markdown
Collaborator

☀️ Test successful - status-appveyor, status-travis
Approved by: nagisa
Pushing fef1026 to master...

@bors
bors merged commit c597994 into rust-lang:masterApr 16, 2017
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-reviewStatus: Awaiting review from the assignee but also interested parties.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@eddyb@nagisa@bors@alexcrichton@arielb1