Skip to content

Check privacy of trait items in all contexts - #41332

Merged
bors merged 3 commits into
rust-lang:masterfrom
petrochenkov:privti
Apr 26, 2017
Merged

Check privacy of trait items in all contexts#41332
bors merged 3 commits into
rust-lang:masterfrom
petrochenkov:privti

Conversation

@petrochenkov

@petrochenkovpetrochenkov commented Apr 16, 2017•
edited
Loading

Copy link
Copy Markdown
Contributor

Fixes#28514

This is a sufficiently rare scenario and it's currently guarded by private_in_public lint, so it shouldn't be a [breaking-change] in practice.

@rust-highfive

rust-highfive commented Apr 16, 2017

Copy link
Copy Markdown
Contributor

r? @arielb1

(rust_highfive has picked a reviewer for you, use r? to override)

@petrochenkov

petrochenkov commented Apr 16, 2017

Copy link
Copy Markdown
ContributorAuthor

r? @eddyb

@rust-highfiverust-highfive assigned eddyb and unassigned arielb1Apr 16, 2017
@eddyb

eddyb commented Apr 16, 2017

Copy link
Copy Markdown
Contributor

The changes LGTM, started a crater run to see if there's any real impact.

@Mark-SimulacrumMark-Simulacrum added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Apr 16, 2017
@eddyb

eddyb commented Apr 17, 2017

Copy link
Copy Markdown
Contributor

Sadly, Crater now outputs error: TypeError: Cannot call method 'trim' of undefined.
I had a successful run just a couple days ago, not sure what, if anything, changed. cc @brson

@arielb1arielb1 added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 18, 2017
@eddybeddyb added the S-waiting-on-crater Status: Waiting on a crater run to be completed. label Apr 20, 2017
@eddyb

eddyb commented Apr 20, 2017

Copy link
Copy Markdown
Contributor

Paging @brson again, to make sure he sees it when he gets back.

@nagisa

nagisa commented Apr 24, 2017

Copy link
Copy Markdown
Member

@eddyb Did you try again since?

@brson

brson commented Apr 24, 2017

Copy link
Copy Markdown
Contributor

I fixed a bug in crater that should make it work again, and started crate builds for commits fef1026 and 4f7ab0e. It should be done in a few hours if nothing else goes wrong.

@brson

brson commented Apr 25, 2017

Copy link
Copy Markdown
Contributor

https://gist.github.com/anonymous/dc7effc2a956c5eac26a804c75f315f1

@eddyb

eddyb commented Apr 25, 2017

Copy link
Copy Markdown
Contributor

@bors r+

@bors

bors commented Apr 25, 2017

Copy link
Copy Markdown
Collaborator

📌 Commit 4f7ab0e has been approved by eddyb

@arielb1arielb1 added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 25, 2017
arielb1 pushed a commit to arielb1/rust that referenced this pull request Apr 25, 2017
Ariel Ben-Yehuda
Rollup merge ofrust-lang#41332- petrochenkov:privti, r=eddyb
070c3ba
Check privacy of trait items in all contexts
Fixesrust-lang#28514
This is a sufficiently rare scenario and it's currently guarded by `private_in_public` lint, so it shouldn't be a [breaking-change] in practice.
@arielb1arielb1 mentioned this pull request Apr 25, 2017
Closed
@bors

bors commented Apr 25, 2017

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 4f7ab0e with merge c53bc6d...

@bors

bors commented Apr 25, 2017

Copy link
Copy Markdown
Collaborator

💔 Test failed - status-travis

@petrochenkov

petrochenkov commented Apr 25, 2017

Copy link
Copy Markdown
ContributorAuthor

Conflict with recently merged #41494, will fix today.

@arielb1

arielb1 commented Apr 25, 2017

Copy link
Copy Markdown
Contributor

@bors r-

@petrochenkov

petrochenkov commented Apr 25, 2017

Copy link
Copy Markdown
ContributorAuthor

@bors r=eddyb

@bors

bors commented Apr 25, 2017

Copy link
Copy Markdown
Collaborator

📌 Commit 4bd417e has been approved by eddyb

@bors

bors commented Apr 25, 2017

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 4bd417e with merge a268165...

@bors

bors commented Apr 25, 2017

Copy link
Copy Markdown
Collaborator

💔 Test failed - status-appveyor

@Mark-Simulacrum

Mark-Simulacrum commented Apr 25, 2017•
edited
Loading

Copy link
Copy Markdown
Member

Probably spurious, though odd. Filed #41545 to track this.

@bors retry

 Downloading utf8-ranges v0.1.3
error: unable to get packages from source
Caused by:
failed to get 200 response from `https://crates.io/api/v1/crates/utf8-ranges/0.1.3/download`, got 500
thread 'main' panicked at 'tests failed for https://github.com/BurntSushi/xsv', src\tools\cargotest\main.rs:78
note: Run with `RUST_BACKTRACE=1` for a backtrace.
command did not execute successfully: "C:\\projects\\rust\\build\\x86_64-pc-windows-msvc\\stage0-tools\\x86_64-pc-windows-msvc\\release\\cargotest.exe" "C:\\projects\\rust\\build\\x86_64-pc-windows-msvc\\stage0/bin\\cargo.exe" "C:\\projects\\rust\\build\\ct"
expected success, got: exit code: 101

@Mark-SimulacrumMark-Simulacrum mentioned this pull request Apr 25, 2017
Closed
@bors

bors commented Apr 25, 2017

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 4bd417e with merge 7e7114f...

bors added a commit that referenced this pull request Apr 25, 2017
@bors
Auto merge of#41332- petrochenkov:privti, r=eddyb
7e7114f
Check privacy of trait items in all contexts
Fixes#28514
This is a sufficiently rare scenario and it's currently guarded by `private_in_public` lint, so it shouldn't be a [breaking-change] in practice.
@Mark-SimulacrumMark-Simulacrum removed the S-waiting-on-crater Status: Waiting on a crater run to be completed. label Apr 25, 2017
@bors

bors commented Apr 26, 2017

Copy link
Copy Markdown
Collaborator

☀️ Test successful - status-appveyor, status-travis
Approved by: eddyb
Pushing 7e7114f to master...

@bors
bors merged commit 4bd417e into rust-lang:masterApr 26, 2017
@borsbors mentioned this pull request Apr 26, 2017
Merged
@petrochenkov
petrochenkov deleted the privti branch August 26, 2017 00:15
@petrochenkovpetrochenkov mentioned this pull request Nov 18, 2017
Merged
bors added a commit that referenced this pull request Dec 21, 2017
@bors
Auto merge of#46083- petrochenkov:morepriv, r=nikomatsakis
a12706c
Type privacy polishing
Various preparations before implementing rust-lang/rfcs#2145 containing final minor breaking changes (mostly for unstable code or code using `allow(private_in_public)`).
(Continuation of #42125, #44633 and #41332.)
It would be good to run crater on this.
r? @eddyb
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@eddybeddybeddyb approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@eddybeddyb

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@petrochenkov@rust-highfive@eddyb@nagisa@brson@bors@arielb1@Mark-Simulacrum